This code was preventing the view from updating when the dataProvider was modified in the Express DataGridTest.
It looks to me like this is a naive optimization that was added at some point, but there might be a good reason why this was there that I’m missing. Anyone who has touched this code in the past, please look at my change and make sure this does not break something… Harbs > On Oct 28, 2017, at 11:03 PM, [email protected] wrote: > > This is an automated email from the ASF dual-hosted git repository. > > harbs pushed a commit to branch develop > in repository https://gitbox.apache.org/repos/asf/royale-asjs.git > > > The following commit(s) were added to refs/heads/develop by this push: > new 313cf14 Updating the source of an ArrayList does not change the view > of the component without this change. I’m not sure why this check was there. > Please review. > 313cf14 is described below > > commit 313cf14147dfdd53b621b82b949b8544d2b6ed91 > Author: Harbs <[email protected]> > AuthorDate: Sat Oct 28 23:02:56 2017 +0300 > > Updating the source of an ArrayList does not change the view of the > component without this change. > I’m not sure why this check was there. Please review. > --- > .../org/apache/royale/html/beads/models/ArrayListSelectionModel.as | 1 - > 1 file changed, 1 deletion(-) > > diff --git > a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/models/ArrayListSelectionModel.as > > b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/models/ArrayListSelectionModel.as > index 81c606c..ec10892 100644 > --- > a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/models/ArrayListSelectionModel.as > +++ > b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/models/ArrayListSelectionModel.as > @@ -84,7 +84,6 @@ package org.apache.royale.html.beads.models > */ > public function set dataProvider(value:Object):void > { > - if (value == _dataProvider) return; > > _dataProvider = value as IArrayList; > if(!_dataProvider || _selectedIndex >= > _dataProvider.length) > > -- > To stop receiving notification emails like this one, please contact > ['"[email protected]" <[email protected]>'].
