Hi Erik,

Unfortunately, I started the refactoring to make Flex SDK optional
yesterday and don't really want to revert everything or set up another
Eclipse workspace.  It will be several days until I get Eclipse working
again, and hopefully it will make this issue go away for future Eclipse
users.

FLEX_HOME should point to a Flex SDK, not a FlexJS/Royale SDK.  ASJS_HOME
points to a FlexJS/Royale SDK.  It probably has to be a Royale SDK if you
are synced up with develop branch.  See env-template.properties.
Hopefully it is up to date after the renaming.

Also, I did not re-use old Eclipse run configs for flex-falcon after the
rename.  I built a whole new workspace against the Royale repos.  It might
be that the SWC tests were never run given how I set up my run configs.

IMO, we want the Royale compiler to be backward compatible as much as
possible with compiling old Flex apps.  Maybe some code is still needed to
fallback from royale-config.xml to flex-config.xml.  I'm pretty sure the
code already doesn't care if the tag inside a -config.xml file is
<flex-config> or <royale-config>.

HTH,
-Alex

On 11/8/17, 6:57 AM, "Erik de Bruin" <[email protected]> wrote:

>Alex, I guess it's just you and me?
>
>It appears some tests expect the 'old' Flex SDK in FLEX_HOME, while others
>expect 'royale-asjs'. That's one thing. Another is that the SWC tests are
>all failing for me, again it seems on assumptions that are no longer valid
>after the fork and rename.
>
>Thanks,
>
>EdB
>
>
>
>On Wed, Nov 8, 2017 at 3:28 PM, Harbs <[email protected]> wrote:
>
>> Sorry that’s above my pay grade.
>>
>> One day I hope to get the project setup in Eclipse and get my feet wet,
>> but I’ve not gotten there yet…
>>
>> Good luck!
>> Harbs
>>
>> > On Nov 8, 2017, at 1:31 PM, Erik de Bruin <[email protected]> wrote:
>> >
>> > Harbs,
>> >
>> > Are you talking about the 'ant' build succeeding or about running the
>> tests
>> > on the compiler project in Eclipse?
>> >
>> > Because the ant build succeeds even if a bunch of tests fail, while
>> running
>> > the tests in Eclipse will show all errors and failures.
>> >
>> > Thanks,
>> >
>> > EdB
>> >
>> >
>> >
>> >
>> >
>> > On Wed, Nov 8, 2017 at 11:41 AM, Harbs <[email protected]> wrote:
>> >
>> >> You need ROYALE_HOME for the royale-asjs repo.
>> >>
>> >> The new environment var for the compiler is: ROYALE_COMPILER_REPO
>> >>
>> >> I’m pretty sure those are the only two you need.
>> >>
>> >> FWIW, my script to set my env vars looks like this (although much of
>>it
>> is
>> >> probably no longer needed or correct).
>> >>
>> >> #!/bin/sh
>> >>
>> >> export ROYALE_COMPILER_REPO=/Users/harbs/Documents/ApacheRoyale/
>> >> royale-compiler
>> >> export 
>>FLEXUNIT_HOME=/Users/harbs/Documents/ApacheRoyale/flex-flexunit
>> >> export FLEX_HOME=/Users/harbs/Documents/ApacheRoyale/flex-sdk
>> >> export AIR_HOME=/Users/harbs/Documents/ApacheRoyale/
>> >> frameworks/AIRSDK_Compiler
>> >> export PLAYERGLOBAL_HOME=/Users/harbs/Documents/ApacheRoyale/
>> >> frameworks/libs/player
>> >> export FLASHPLAYER_DEBUGGER=/Users/harbs/Documents/ApacheRoyale/
>> frameworks/Flash\
>> >> Player\ Debugger.app/Contents/MacOS/Flash\ Player\ Debugger
>> >> export FLEXJS_HOME=/Users/harbs/Documents/ApacheRoyale/royale-asjs
>> >> export FALCONJX_HOME=/Users/harbs/Documents/ApacheRoyale/royale-
>> >> compiler/compiler-jx
>> >> export FLEXJS_TYPEDEFS_HOME=/Users/harbs/Documents/ApacheRoyale/
>> >> royale-typedefs
>> >> export GOOG_HOME=/Users/harbs/Documents/ApacheRoyale/
>> >> frameworks/google/closure-library
>> >>
>> >> export ROYALE_HOME=/Users/harbs/Documents/ApacheRoyale/royale-asjs
>> >>
>> >>> On Nov 8, 2017, at 12:29 PM, Erik de Bruin <[email protected]>
>>wrote:
>> >>>
>> >>> Hi,
>> >>>
>> >>> I'm still frustrated that not all tests on compiler are passing for
>> me. I
>> >>> think this may revolve around the various framework builds and
>> >> environment
>> >>> vars...
>> >>>
>> >>> When I set FLEX_HOME to my asjs git repo that I have built with 'ant
>> >> all',
>> >>> I get a lot of errors saying:
>> >>>
>> >>> <
>> >>> unable to open
>> >>> 
>>'/Users/erik/Documents/git/royale-asjs/frameworks/libs/framework.swc'.
>> >>> unable to open
>> >>> '/Users/erik/Documents/git/royale-asjs/frameworks/locale/
>> >> en_US/framework_rb.swc'.
>> >>>>
>> >>>
>> >>> If I point FLEX_HOME to pre-built nightly of the asjs framework, I
>>get
>> >>> different errors:
>> >>>
>> >>> <
>> >>> unknown configuration variable 'compiler.targets'.
>> >>> /Users/erik/Documents/Royale/apache-royale-0.9.0-bin/
>> >> frameworks/royale-config.xml
>> >>> (line: 33)
>> >>>>
>> >>>
>> >>> If I point FLEX_HOME to a release of the flex framework, I a lot of
>> these
>> >>> errors:
>> >>>
>> >>> <
>> >>> unable to open
>> >>> '/Users/erik/Documents/Royale/apache-flex-sdk-4.16.0-bin/
>> >> frameworks/royale-config.xml'.
>> >>>>
>> >>>
>> >>> What am I doing wrong? Can the folks that have all tests passing on
>>the
>> >>> 'royale-compiler/compiler' project maybe share their setup and
>> settings?
>> >>>
>> >>> Thanks,
>> >>>
>> >>> EdB
>> >>>
>> >>>
>> >>>
>> >>> --
>> >>> Ix Multimedia Software
>> >>>
>> >>> Jan Luykenstraat 27
>> >>> 3521 VB Utrecht
>> >>>
>> >>> T. 06-51952295
>> >>> I. 
>>https://na01.safelinks.protection.outlook.com/?url=www.ixsoftware.nl&data
>>=02%7C01%7C%7C10d1616bfd5d43ae6eee08d526b91c02%7Cfa7b1b5a7b34438794aed2c1
>>78decee1%7C0%7C0%7C636457498842089190&sdata=PNnGG%2BXD%2BmkMvzYdkTKwYjZz8
>>ZBIgLXtE0jGN%2FrOWaQ%3D&reserved=0
>> >>
>> >>
>> >
>> >
>> > --
>> > Ix Multimedia Software
>> >
>> > Jan Luykenstraat 27
>> > 3521 VB Utrecht
>> >
>> > T. 06-51952295
>> > I. 
>>https://na01.safelinks.protection.outlook.com/?url=www.ixsoftware.nl&data
>>=02%7C01%7C%7C10d1616bfd5d43ae6eee08d526b91c02%7Cfa7b1b5a7b34438794aed2c1
>>78decee1%7C0%7C0%7C636457498842089190&sdata=PNnGG%2BXD%2BmkMvzYdkTKwYjZz8
>>ZBIgLXtE0jGN%2FrOWaQ%3D&reserved=0
>>
>>
>
>
>-- 
>Ix Multimedia Software
>
>Jan Luykenstraat 27
>3521 VB Utrecht
>
>T. 06-51952295
>I. 
>https://na01.safelinks.protection.outlook.com/?url=www.ixsoftware.nl&data=
>02%7C01%7C%7C10d1616bfd5d43ae6eee08d526b91c02%7Cfa7b1b5a7b34438794aed2c178
>decee1%7C0%7C0%7C636457498842089190&sdata=PNnGG%2BXD%2BmkMvzYdkTKwYjZz8ZBI
>gLXtE0jGN%2FrOWaQ%3D&reserved=0

Reply via email to