Om,

I suggest to provide link in template.html to online version of ECharts
instead committing whole package. Can we have some problems with licensing
?

Thanks, Piotr

2018-03-16 10:17 GMT+01:00 <[email protected]>:

> This is an automated email from the ASF dual-hosted git repository.
>
> bigosmallm pushed a commit to branch feature/echarts
> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>
>
> The following commit(s) were added to refs/heads/feature/echarts by this
> push:
>      new f9b13f7  Rename lib to js
> f9b13f7 is described below
>
> commit f9b13f7ba4c7444553442aa30e5ab12d4f98d2b9
> Author: Om Muppirala <[email protected]>
> AuthorDate: Fri Mar 16 02:17:46 2018 -0700
>
>     Rename lib to js
> ---
>  examples/royale/ECharts/js/echarts.min.js | 1 +
>  examples/royale/ECharts/template.html     | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/examples/royale/ECharts/js/echarts.min.js
> b/examples/royale/ECharts/js/echarts.min.js
> new file mode 100644
> index 0000000..5b48053
> --- /dev/null
> +++ b/examples/royale/ECharts/js/echarts.min.js
> @@ -0,0 +1 @@
> +!function(t,e){"object"==typeof exports&&"undefined"!=typeof
> module?e(exports):"function"==typeof define&&define.amd?define(["
> exports"],e):e(t.echarts={})}(this,function(t){"use strict";function
> e(t,e){"createCanvas"===t&&(Gx=null),Bx[t]=e}function
> i(t){if(null==t||"object"!=typeof t)return t;var
> e=t,n=kx.call(t);if("[object Array]"===n){if(!O(t)){e=[];for(var
> o=0,a=t.length;o<a;o++)e[o]=i(t[o])}}else if(Lx[n]){if(!O(t)){var
> r=t.constructor;if(t.constructor.from)e=r.from(t);else{e=new r( [...]
> diff --git a/examples/royale/ECharts/template.html
> b/examples/royale/ECharts/template.html
> index c19aed9..57e0bb4 100644
> --- a/examples/royale/ECharts/template.html
> +++ b/examples/royale/ECharts/template.html
> @@ -3,7 +3,7 @@
>  <head>
>  <meta charset="utf-8"/>
>  <title>ECharts Example</title>
> -<script type="text/javascript" src="../../lib/echarts.min.js"></script>
> +<script type="text/javascript" src="../../js/echarts.min.js"></script>
>  ${head}
>  </head>
>  <body>
>
> --
> To stop receiving notification emails like this one, please contact
> [email protected].
>



-- 

Piotr Zarzycki

Patreon: *https://www.patreon.com/piotrzarzycki
<https://www.patreon.com/piotrzarzycki>*

Reply via email to