The problem was with a mousedown outside the renderer and a mouseup inside the renderer. That should not be handled as an itemClick.
> On May 27, 2018, at 2:29 PM, Piotr Zarzycki <[email protected]> wrote: > > I'm using that renderer a lot but didn't notice anything wrong with that, > although it looks like your fix is good. I hope to check it once all stuff > back to normal in develop. > > Thanks, > Piotr > > 2018-05-27 13:26 GMT+02:00 Harbs <[email protected]>: > >> This change looks correct to me and fixed the bug as I observed it. >> >> Any idea why was mouse up used instead of click in the first place? >> >> I assume the same fix should be applied to the swf block? >> >> Harbs >> >>> On May 27, 2018, at 2:24 PM, [email protected] wrote: >>> >>> This is an automated email from the ASF dual-hosted git repository. >>> >>> harbs pushed a commit to branch feature/revert-refactor >>> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git >>> >>> >>> The following commit(s) were added to refs/heads/feature/revert-refactor >> by this push: >>> new 3c61cf6 Item Renderer firing itemChanged when mouse is dragged >> over item renderer and released >>> 3c61cf6 is described below >>> >>> commit 3c61cf64218eade1d74a69d08894483c33374bd1 >>> Author: Harbs <[email protected]> >>> AuthorDate: Sun May 27 14:24:17 2018 +0300 >>> >>> Item Renderer firing itemChanged when mouse is dragged over item >> renderer and released >>> --- >>> .../apache/royale/html/beads/controllers/ItemRendererMouseController.as >> | 2 +- >>> .../royale/org/apache/royale/html/supportClasses/StringItemRenderer.as >> | 2 +- >>> 2 files changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/ >> royale/html/beads/controllers/ItemRendererMouseController.as >> b/frameworks/projects/Basic/src/main/royale/org/apache/ >> royale/html/beads/controllers/ItemRendererMouseController.as >>> index c9c53e5..a040368 100644 >>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/ >> royale/html/beads/controllers/ItemRendererMouseController.as >>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/ >> royale/html/beads/controllers/ItemRendererMouseController.as >>> @@ -91,7 +91,7 @@ COMPILE::JS { >>> goog.events.listen(element, >> goog.events.EventType.MOUSEOVER, this.handleMouseOver); >>> goog.events.listen(element, >> goog.events.EventType.MOUSEOUT, this.handleMouseOut); >>> goog.events.listen(element, >> goog.events.EventType.MOUSEDOWN, this.handleMouseDown); >>> - goog.events.listen(element, >> goog.events.EventType.MOUSEUP, this.handleMouseUp); >>> + goog.events.listen(element, >> goog.events.EventType.CLICK, this.handleMouseUp); >>> } >>> } >>> >>> diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/ >> royale/html/supportClasses/StringItemRenderer.as >> b/frameworks/projects/Basic/src/main/royale/org/apache/ >> royale/html/supportClasses/StringItemRenderer.as >>> index b49c826..5487068 100644 >>> --- a/frameworks/projects/Basic/src/main/royale/org/apache/ >> royale/html/supportClasses/StringItemRenderer.as >>> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/ >> royale/html/supportClasses/StringItemRenderer.as >>> @@ -28,10 +28,10 @@ package org.apache.royale.html.supportClasses >>> COMPILE::JS >>> { >>> import org.apache.royale.core.WrappedHTMLElement; >>> + import org.apache.royale.html.util.addElementToWrapper; >>> } >>> import org.apache.royale.events.Event; >>> import org.apache.royale.html.beads.ITextItemRenderer; >>> - import org.apache.royale.html.util.addElementToWrapper; >>> >>> /** >>> * The StringItemRenderer class displays data in string form >> using the data's toString() >>> >>> -- >>> To stop receiving notification emails like this one, please contact >>> [email protected]. >> >> > > > -- > > Piotr Zarzycki > > Patreon: *https://www.patreon.com/piotrzarzycki > <https://www.patreon.com/piotrzarzycki>*
