Those probably need to be changed the itemRenderer equivalents 
(numItemRenderers, etc.)

> On Sep 5, 2018, at 2:28 PM, Carlos Rovira <carlosrov...@apache.org> wrote:
> 
> Hi Harbs,
> 
> I'm seeing few problems in JewelExample, that pass unnoticed for me
> yesterday. Maybe I was testing release and not debug...don't know:
> 
> In List playground:
> * Adding an item works but give this error
>      TypeError: null is not an object (evaluating 'dataGroup.numElements')
> * Removing a item is not working, error is:
>     TypeError: null is not an object (evaluating 'parent.getElementAt')
> * Update item works right
> * Remove all works right
> 
> Table playground:
> 
> * Add item, works but:
>      TypeError: null is not an object (evaluating
> 'processedRow.numElements')
> * Remove item doesn't work and:
>      TypeError: null is not an object (evaluating
> 'processedRow.numElements')
> * Update item doesn't work and doesn't report error
> * Remove all works right
> 
> Sorry to not catch this before
> 
> can you take a look?
> 
> thanks
> 
> Carlos
> 
> 
> 
> El mar., 4 sept. 2018 a las 13:41, Carlos Rovira (<carlosrov...@apache.org>)
> escribió:
> 
>> I already did in that commit, we have both now
>> 
>> El mar., 4 sept. 2018 a las 13:31, Harbs (<harbs.li...@gmail.com>)
>> escribió:
>> 
>>> Great. I’ll add the asconfigc tasks to that later.
>>> 
>>>> On Sep 4, 2018, at 2:10 PM, Carlos Rovira <carlosrov...@apache.org>
>>> wrote:
>>>> 
>>>> I found it how to do it
>>>> New VSCode forma 2.0.0 solves this and more  :))
>>>> 
>>>> one thing it you can configure a task to be default, but I didn't commit
>>>> anyone as default since the others will be less quick to execute
>>>> 
>>>> El mar., 4 sept. 2018 a las 12:55, Harbs (<harbs.li...@gmail.com>)
>>> escribió:
>>>> 
>>>>> Awesome. :-)
>>>>> 
>>>>>> On Sep 4, 2018, at 1:42 PM, Carlos Rovira <carlosrov...@apache.org>
>>>>> wrote:
>>>>>> 
>>>>>> Hi,
>>>>>> 
>>>>>> I revert my revert ;), so I can find a non intrusive way. I'm sure
>>> VSCode
>>>>>> should have a way to configure a task but make it not default or block
>>>>> AS3
>>>>>> extension
>>>>>> when I get it I'll commit the solution
>>>>>> 
>>>>>> El mar., 4 sept. 2018 a las 12:20, Harbs (<harbs.li...@gmail.com>)
>>>>> escribió:
>>>>>> 
>>>>>>> I had some errors on missing resources.
>>>>>>> 
>>>>>>> I’ve never managed to get maven to work for me. Dunno why.
>>>>>>> 
>>>>>>> The tasks.json file overrides the defaults, so the build task uses
>>> maven
>>>>>>> instead of asconfigc.
>>>>>>> 
>>>>>>> We should either modify the tasks.json file to allow for multiple
>>> build
>>>>>>> tasks, or include it in gitignore.
>>>>>>> 
>>>>>>> Here’s info on defining arbitrary tasks:
>>>>>>> 
>>>>>>> 
>>>>> 
>>> https://docs.microsoft.com/en-us/visualstudio/ide/customize-build-and-debug-tasks-in-visual-studio?view=vs-2017
>>>>>>> <
>>>>>>> 
>>>>> 
>>> https://docs.microsoft.com/en-us/visualstudio/ide/customize-build-and-debug-tasks-in-visual-studio?view=vs-2017
>>>>>>>> 
>>>>>>> 
>>>>>>> 
>>>>>>>> On Sep 4, 2018, at 12:57 PM, Carlos Rovira <carlosrov...@apache.org
>>>> 
>>>>>>> wrote:
>>>>>>>> 
>>>>>>>> I revert latest commit since launch.json works ok with maven, what
>>>>>>> problem
>>>>>>>> did you find? Is what I use in day-by-day to work with VSCode
>>>>>>> 
>>>>>>> 
>>>>>> 
>>>>>> --
>>>>>> Carlos Rovira
>>>>>> http://about.me/carlosrovira
>>>>> 
>>>>> 
>>>> 
>>>> --
>>>> Carlos Rovira
>>>> http://about.me/carlosrovira
>>> 
>>> 
>> 
>> --
>> Carlos Rovira
>> http://about.me/carlosrovira
>> 
>> 
> 
> -- 
> Carlos Rovira
> http://about.me/carlosrovira

Reply via email to