This causes two events to be fired when an item renderer is selected.

Mouse up causes the event to be fired even when you mouse down outside the item 
renderer and then mouse up inside the item renderer. I changed it from mouse up 
to click in June.

What was the exact issue that you were trying to fix? I’m not sure what the 
right solution is here, but both events is definitely wrong.

Harbs

> On Sep 7, 2018, at 3:02 AM, [email protected] wrote:
> 
> This is an automated email from the ASF dual-hosted git repository.
> 
> aharui pushed a commit to branch develop
> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
> 
> commit 7d9a1a1330ab6732ae9d7963fb694c5594b5f24d
> Author: Alex Harui <[email protected]>
> AuthorDate: Thu Sep 6 17:01:12 2018 -0700
> 
>    try listening for both click or mouseup.  Menu needs mouse up probably 
> because it is gone before click comes through
> ---
> .../apache/royale/html/beads/controllers/ItemRendererMouseController.as  | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git 
> a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/controllers/ItemRendererMouseController.as
>  
> b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/controllers/ItemRendererMouseController.as
> index 6073264..f408a71 100644
> --- 
> a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/controllers/ItemRendererMouseController.as
> +++ 
> b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/controllers/ItemRendererMouseController.as
> @@ -92,6 +92,7 @@ COMPILE::JS {
>                               goog.events.listen(element, 
> goog.events.EventType.MOUSEOUT, this.handleMouseOut);
>                               goog.events.listen(element, 
> goog.events.EventType.MOUSEDOWN, this.handleMouseDown);
>                               goog.events.listen(element, 
> goog.events.EventType.CLICK, this.handleMouseUp);
> +                goog.events.listen(element, goog.events.EventType.MOUSEUP, 
> this.handleMouseUp);
>                       }
>               }
>               
> 

Reply via email to