I did not look closely, but it appeared from the commit message that the part
of the pom Carlos changed was inside a comment. Maven does not search comments
when updating versions, it works from the project model. I wouldn't be
surprised if Maven has a philosophy that you shouldn't comment out dependencies
in POMs, and that you should just remove them instead and put them back in when
you need them.
HTH,
-Alex
On 10/1/18, 1:06 AM, "Carlos Rovira" <carlosrov...@apache.org> wrote:
ok, I'll take that account for now on, and will only comment in this list.
thanks!
El lun., 1 oct. 2018 a las 9:58, Piotr Zarzycki
(<piotrzarzyck...@gmail.com>)
escribió:
> Probably Maven doesn't have some part of the project in chain of
hierarchy.
> We can manually adjust those poms once RC1 will be created. However I
would
> say it should be done once RC1 turns into release, because we may VOTE -1
> than process will start from scratch. - It would be harder manually revert
> it. Probably because of that commit Om can have some problems if you did
> that during his attempt of RC creation.
>
> pon., 1 paź 2018 o 09:52 Carlos Rovira <carlosrov...@apache.org>
> napisał(a):
>
> > Ok, I can left poms untouched from now on.
> >
> > it's very strange that some poms are not updated to the right version,
> > since that in concrete is linked from parent in modules.
> >
> > El lun., 1 oct. 2018 a las 9:41, Piotr Zarzycki (<
> > piotrzarzyck...@gmail.com>)
> > escribió:
> >
> > > Carlos,
> > >
> > > It shouldn't be unless Om let you know that he succeed with creating
> RC1.
> > > You should probably do not manually change anything.
> > >
> > > Piotr
> > >
> > > pon., 1 paź 2018 o 09:36 Carlos Rovira <carlosrov...@apache.org>
> > > napisał(a):
> > >
> > > > Hi,
> > > > just found this pom was not in 0.9.5
> > > >
> > > > El lun., 1 oct. 2018 a las 9:34, <carlosrov...@apache.org> escribió:
> > > >
> > > > > This is an automated email from the ASF dual-hosted git
repository.
> > > > >
> > > > > carlosrovira pushed a commit to branch develop
> > > > > in repository
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&data=02%7C01%7Caharui%40adobe.com%7Ce30f2f11b0004a3021e008d62774d12f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636739780006196516&sdata=JTNU9S3A9tNJ7%2BW%2BiE5BgjESRcqTpC6lXTueBLkMffQ%3D&reserved=0
> > > > >
> > > > >
> > > > > The following commit(s) were added to refs/heads/develop by this
> > push:
> > > > > new 229d527 Jewel example pom is not updated to 0.9.4
> > > > > 229d527 is described below
> > > > >
> > > > > commit 229d5272fe7a71fae25dbd09b0c573ee442bc494
> > > > > Author: Carlos Rovira <carlosrov...@apache.org>
> > > > > AuthorDate: Mon Oct 1 09:34:37 2018 +0200
> > > > >
> > > > > Jewel example pom is not updated to 0.9.4
> > > > > ---
> > > > > examples/royale/JewelExample/pom.xml | 6 +++---
> > > > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > > > >
> > > > > diff --git a/examples/royale/JewelExample/pom.xml
> > > > > b/examples/royale/JewelExample/pom.xml
> > > > > index 38261ad..2b94019 100644
> > > > > --- a/examples/royale/JewelExample/pom.xml
> > > > > +++ b/examples/royale/JewelExample/pom.xml
> > > > > @@ -139,7 +139,7 @@
> > > > > <!-- <dependency>
> > > > > <groupId>org.apache.royale.framework</groupId>
> > > > >
> <artifactId>Jewel-Light-NoFlat-Primary-Blue-Theme</artifactId>
> > > > > - <version>0.9.4-SNAPSHOT</version>
> > > > > + <version>0.9.5-SNAPSHOT</version>
> > > > > <type>swc</type>
> > > > > <scope>theme</scope>
> > > > > <classifier>js</classifier>
> > > > > @@ -147,7 +147,7 @@
> > > > > <dependency>
> > > > > <groupId>org.apache.royale.framework</groupId>
> > > > >
> > > <artifactId>Jewel-Light-NoFlat-Secondary-Topaz-Theme</artifactId>
> > > > > - <version>0.9.4-SNAPSHOT</version>
> > > > > + <version>0.9.5-SNAPSHOT</version>
> > > > > <type>swc</type>
> > > > > <scope>theme</scope>
> > > > > <classifier>js</classifier>
> > > > > @@ -155,7 +155,7 @@
> > > > > <dependency>
> > > > > <groupId>org.apache.royale.framework</groupId>
> > > > >
> > > > <artifactId>Jewel-Light-NoFlat-Emphasized-Emerald-Theme</artifactId>
> > > > > - <version>0.9.4-SNAPSHOT</version>
> > > > > + <version>0.9.5-SNAPSHOT</version>
> > > > > <type>swc</type>
> > > > > <scope>theme</scope>
> > > > > </dependency> -->
> > > > >
> > > > >
> > > >
> > > > --
> > > > Carlos Rovira
> > > >
https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Ce30f2f11b0004a3021e008d62774d12f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636739780006196516&sdata=tTRSEvQe599eYxrpOq9r95OPT6VBx7YLTEja1T%2B9dkQ%3D&reserved=0
> > > >
> > >
> > >
> > > --
> > >
> > > Piotr Zarzycki
> > >
> > > Patreon:
*https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ce30f2f11b0004a3021e008d62774d12f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636739780006196516&sdata=%2FAjUweA2ug%2FzKfT4qiqVlr1bymh9BuitzOCMriViYO4%3D&reserved=0
> > >
<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ce30f2f11b0004a3021e008d62774d12f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636739780006196516&sdata=%2FAjUweA2ug%2FzKfT4qiqVlr1bymh9BuitzOCMriViYO4%3D&reserved=0>*
> > >
> >
> >
> > --
> > Carlos Rovira
> >
https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Ce30f2f11b0004a3021e008d62774d12f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636739780006196516&sdata=tTRSEvQe599eYxrpOq9r95OPT6VBx7YLTEja1T%2B9dkQ%3D&reserved=0
> >
>
>
> --
>
> Piotr Zarzycki
>
> Patreon:
*https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ce30f2f11b0004a3021e008d62774d12f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636739780006196516&sdata=%2FAjUweA2ug%2FzKfT4qiqVlr1bymh9BuitzOCMriViYO4%3D&reserved=0
>
<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ce30f2f11b0004a3021e008d62774d12f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636739780006196516&sdata=%2FAjUweA2ug%2FzKfT4qiqVlr1bymh9BuitzOCMriViYO4%3D&reserved=0>*
>
--
Carlos Rovira
https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Ce30f2f11b0004a3021e008d62774d12f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636739780006196516&sdata=tTRSEvQe599eYxrpOq9r95OPT6VBx7YLTEja1T%2B9dkQ%3D&reserved=0
