On my computer java return timezone GMT +2, while flash returns GMT +3. I think
that’s the reason it’s failing after day light saving was cancelled today (both
in Israel and Spain). As I understand it, Oracle suggests [1] to update the JRE
to get the correct timezone but that looks to me like too much to expect of
every developer building from source.
To be honest, I’m not sure why we’re setting the timezone explicitly in some of
the tests. For instance, in ASDateTests_date we could probably do
setTimeZone("var date : Date = new Date('Sat Jun 30 23:59:59
2018');"),
"date.date += 1;",
"assertEqual('date.date', date.date, 1);",
Instead of
setTimeZone("var date : Date = new Date('Sat Jun 30 23:59:59 TZ
2018');"),
"date.date += 1;",
"assertEqual('date.date', date.date, 1);",
(‘TZ’ inserts Java’s understanding of the time zone.)
[1] https://www.oracle.com/technetwork/java/javase/timezones-137583.html
________________________________
From: Carlos Rovira <[email protected]>
Sent: Sunday, October 28, 2018 11:21:09 AM
To: [email protected]
Subject: Re: Unable to build with ANT
Hi,
I found a way to get ANT compilation working. "ant all" is broken so:
1.- Go to compiler: run "ant sdk"
2.- Go to typedefs: run "ant"
3.- Go to framework: run "ant"
This works for now.
I think the problem is related to the change of hour like Nicolas
suggested, since I wake up and the hour changed due to daylight saving time
and we have 1 hour less.
The problem seems to be in the test run in the compiler, skipping that part
with "ant sdk" make the rest works ok.
El dom., 28 oct. 2018 a las 10:15, Yishay Weiss (<[email protected]>)
escribió:
> Same problem here. Looking into it.
>
>
>
> ________________________________
> From: Carlos Rovira <[email protected]>
> Sent: Sunday, October 28, 2018 9:54:30 AM
> To: [email protected]
> Subject: Unable to build with ANT
>
> Hi,
>
> I'm starting my day and always build with maven and then build a fresh SDK
> with ANT to feed VSCode IDE.
> Today I'm finding the "ant all" process is failing for me [1] and seems
> something related to time zone test failing. Is the first time I see this.
> Don't see any changes that could affect in the last day, so I'm a bit lost
> here.
>
> Hope someone could bring some light on this.
>
> Thanks
>
> [1] https://paste.apache.org/TaYu
>
> --
> Carlos Rovira
> http://about.me/carlosrovira
>
--
Carlos Rovira
http://about.me/carlosrovira
