+1 (binding) Both source packages are essentially identical. All packages source and binary have proper signatures and checksums. RAT Check looks good. LICENSE and NOTICE good.
Ant Build looks successful Maven Build has issues which are described in the DISCUSS. Note there are some CC-SA files (about 8) that were formerly allowed. The license needs to be fixed in the next RC or Release. Regards, Dave > On Nov 15, 2018, at 7:19 AM, Josh Tynjala <[email protected]> wrote: > > +1 (binding) > Package > https://dist.apache.org/repos/dist/dev/royale/0.9.4/rc2/apache-royale-0.9.4-src.zip > Java 1.8 > OS: Windows 10 amd64 10.0 > Source kit signatures match: y > Source kit builds: y > README is ok: y > RELEASE_NOTES is ok: y > NOTICE is ok: y > LICENSE is ok: y > No unapproved licenses or archives: y > No unapproved binaries: y > > Package > https://dist.apache.org/repos/dist/dev/royale/0.9.4/rc2/binaries/apache-royale-0.9.4-bin-js-swf.zip > Binary kit signatures match: y > NOTICE is ok: y > LICENSE is ok: y > No unapproved licenses or archives in binary package: y > No unapproved binaries in binary package: y > > - Josh > > On 2018/11/14 18:45:43, "Alex Harui" <[email protected]> wrote: >> Hi, >> >> This is vote for the 0.9.4 release of Apache Royale. >> >> The release candidate can be found here; >> https://dist.apache.org/repos/dist/dev/royale/0.9.4/rc2/ >> >> Before voting please review the section,'What are the ASF requirements on >> approving a release?', at: >> http://www.apache.org/dev/release.html#approving-a-release >> >> At a minimum you would be expected to check that: >> - SHA and signed packages are correct >> - README, RELEASE_NOTES, NOTICE and LICENSE files are all fine >> - That the build script completes successfully >> - That you can compile and cross-compile a simple example using the SDK. >> >> The source package is a combination of the 3 main Royale repos. >> >> To use the binary package, unzip it into a folder. The -js package is >> ready-to-use in an IDE or command-line. If you need SWF output, use the >> -royale package and use Apache Ant to run the InstallAdobeSDKs script via: >> ant -f InstallAdobeSDKs.xml >> >> You may also get the binary packages via NPM. The -js package can be >> installed via: >> >> npm install >> https://dist.apache.org/repos/dist/dev/royale/0.9.4/rc2/binaries/apache-roya >> le-0.9.4-bin-js.tar.gz -g >> >> The full package with SWF support can be installed via: >> >> npm install >> https://dist.apache.org/repos/dist/dev/royale/0.9.4/rc{rc}/binaries/apache-r >> oyale-0.9.4-bin-js-swf.tar.gz -g >> >> Maven artifacts are staged here: >> https://repository.apache.org/content/repositories/orgapacheroyale-1025 >> >> Please vote to approve this release: >> +1 Approve the release >> -1 Disapprove the release (please provide specific comments to why) >> >> This vote will be open for 72 hours or until a result can be called. >> >> The vote passes if there is: >> - At least 3 +1 votes from the PMC >> - More positive votes than negative votes >> >> Remember that this is a 'beta-quality' release so I expect there >> will be many bugs found. IMO the goal is not to try to find and fix bugs >> in the RC, but to make sure we have the packaging right, and enough >> functionality that folks will have some success trying to use it. >> >> People who are not in PMC are also encouraged to test out the release and >> vote, although their votes will not be binding, they can influence how the >> PMC votes. >> >> When voting please indicate what OS, IDE, Flash Player version and AIR >> version you tested with. >> >> For your convenience, there is an ant script that automates the common >> steps to validate a release. Instead of individually downloading the >> package and signature files, unzipping, etc, you can instead: >> 1) create an empty folder, >> 2) download into that folder this file: >> https://dist.apache.org/repos/dist/dev/royale/0.9.4/rc2/ApproveRoyale.xml >> 3) run the script: >> ant -e -f ApproveRoyale.xml -Drelease.version=0.9.4 -Drc=2 >> If you want to test SWF support during the approval, use: >> ant -e -f ApproveRoyale.xml -Drelease.version=0.9.4 -Drc=2 >> -Duse-flash=true >> >> You are not required to use this script, and more testing of the packages >> and build results are always encouraged. >> >> >> >> Please put all discussion about this release in the DISCUSSION thread not >> this VOTE thread. >> >> Thanks, >> Alex Harui >> >>
