Is this so you can use Flash Builder?

IMO, we shouldn't increase the chance of error in our releases to support the 
repo as an FB SDK.  Add some script that copies the SWCs into a real Royale 
SDK.  Seems risky to have all of those category X files in the working copy.

-Alex

On 1/1/19, 10:00 PM, "Harbs" <[email protected]> wrote:

    I’m using the royale-asjs folder as my SDK. That requires having 
playerglobal within the player folder inside libs.
    
    By deleting the libs folder every time, that requires an extra step of 
re-copying the player folder into libs every time I build royale-asjs.
    
    If you have a better idea, I’m all ears.
    
    Harbs
    
    > On Jan 2, 2019, at 6:13 AM, Alex Harui <[email protected]> wrote:
    > 
    > I am curious about why this change is needed.  I would think we would 
want to clean everything out of the folder so we don't accidentally pick up 
extra files packaging a release.
    > 
    > -Alex
    > 
    > On 1/1/19, 3:16 AM, "[email protected]" <[email protected]> wrote:
    > 
    >    This is an automated email from the ASF dual-hosted git repository.
    > 
    >    harbs pushed a commit to branch develop
    >    in repository 
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&amp;data=02%7C01%7Caharui%40adobe.com%7Ccd2a00a1f1e94ea0dc8308d670778dc6%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636820056138390530&amp;sdata=mTyygJIaK%2Fg1aNVzHKaFaCDvs%2FCALz64hJaCorAAa%2Bs%3D&amp;reserved=0
    > 
    > 
    >    The following commit(s) were added to refs/heads/develop by this push:
    >         new ef95bb4  Changed clean script to only delete the swc files in 
libs
    >    ef95bb4 is described below
    > 
    >    commit ef95bb4c90f55c91920679c7c4a37842dd1904f9
    >    Author: Harbs <[email protected]>
    >    AuthorDate: Tue Jan 1 13:16:38 2019 +0200
    > 
    >        Changed clean script to only delete the swc files in libs
    > 
    >        Every ant build broke the validity of the SDK because it removed 
the player folder from libs
    >    ---
    >     frameworks/build.xml | 5 ++++-
    >     1 file changed, 4 insertions(+), 1 deletion(-)
    > 
    >    diff --git a/frameworks/build.xml b/frameworks/build.xml
    >    index db45fcc..43c6aa3 100644
    >    --- a/frameworks/build.xml
    >    +++ b/frameworks/build.xml
    >    @@ -211,7 +211,10 @@
    >                 </fileset>
    >             </delete> 
    >             <!-- Delete empty folders -->
    >    -        <delete dir="${basedir}/libs"/>
    >    +        <delete dir="${basedir}/libs" failonerror="false">
    >    +            <include name="*.swc"/>
    >    +        </delete>
    >    +        <!-- <delete dir="${basedir}/libs"/> -->
    >             <delete dir="${basedir}/locale">
    >                 <exclude name="**/metadata.properties"/>
    >             </delete>
    > 
    > 
    > 
    
    

Reply via email to