Hi Harbs, much better, I think it's now in a good shape congrats! :)
I only saw a time where trying to delete the slash didn't work, but now I can't reproduce it. If I see it again I'll try to see how I did it and report I think we only need to add a year view to the datechooser to make this component fully functional :) thanks! :) El mié., 23 ene. 2019 a las 9:08, Harbs (<[email protected]>) escribió: > Sorry about that. I keep forgetting about the sass in Jewel… :-( > > I just committed a new change which I think is much better. The formatter > now allows typing and deleting separators. > > Let me know… > Harbs > > > On Jan 23, 2019, at 1:37 AM, Carlos Rovira <[email protected]> > wrote: > > > > Harbs > > mistery solved, the problem is that you changed .css. instead .sass. > > when I build with maven, generation of css was overriding your changes. > > you must remember to update .sass and then run sass compiler, or change > > manually (but doing manually could then still be override by a sass > > generation) > > > > I know see your changes. I see ir working mostly as before the changes. > The > > improvements I see: > > * when start deleting a full date, doesn't delete all at once, what is > > better than before. > > problems to be fixed: > > * when delete and reach a slash, we still has the problem that slash is > not > > deleted, and we get stuck in that character, since algorithm always tries > > to delete and write the slash. the solution is to make the algorithm to > > delete 2 chars instead of one at both slashes positions. Can you try that > > fix? > > > > thanks > > > > Carlos > > > > > > > > > > El mié., 23 ene. 2019 a las 0:06, Carlos Rovira (< > [email protected]>) > > escribió: > > > >> I'm getting the same error as before. Maybe is some problem in my side. > >> Let me check and report. > >> Since, I'm closing for today, tomorrow I'll download all new stuff a > will > >> clean and build all. If I have problems I'll report here. > >> thanks > >> > >> El mar., 22 ene. 2019 a las 23:39, Harbs (<[email protected]>) > >> escribió: > >> > >>> Are you sure you cleaned before compiling TourDeJewel? > >>> > >>>> On Jan 23, 2019, at 12:29 AM, Harbs <[email protected]> wrote: > >>>> > >>>> What error are you getting? > >>>> > >>>>> On Jan 23, 2019, at 12:27 AM, Carlos Rovira <[email protected] > > > >>> wrote: > >>>>> > >>>>> Hi Harbs, > >>>>> > >>>>> El mar., 22 ene. 2019 a las 23:14, Harbs (<[email protected]>) > >>> escribió: > >>>>> > >>>>>>> > >>>>>>> I also added the separator sooner, so after typing “01” it’ll > become > >>>>>> “01/" rather than waiting until after typing “100” to become “01/0”. > >>>>>>> > >>>>>>> I’m not sure if the behavior is better. It’s harder to delete > >>> content. > >>>>>>> > >>>>> > >>>>> > >>>>> That's ok for me, but the problem is that still I don't see it > >>> working... I > >>>>> rebuild Core, Formatters, Jewel and Tour De Jewel, clean browser > >>> cache, run > >>>>> Tour de Jewel and still get the same behavior (no slashes) and > console > >>>>> error :( > >>>>> > >>>>> > >>>>> -- > >>>>> Carlos Rovira > >>>>> http://about.me/carlosrovira > >>>> > >>> > >>> > >> > >> -- > >> Carlos Rovira > >> http://about.me/carlosrovira > >> > >> > > > > -- > > Carlos Rovira > > http://about.me/carlosrovira > > -- Carlos Rovira http://about.me/carlosrovira
