Group doesn't support gap since items are positioned absolutely. gap starts to have sense in Horizontal and Vertical layouts
El mar., 29 ene. 2019 a las 11:50, Piotr Zarzycki (< [email protected]>) escribió: > Carlos, > > I wrote about that problem, cause I simply was searching an answer - and > this one provided by you probably resolve issue, but I'm not sure if it > should be part of framework. > > Let's think about it. User has default: > IFormItemContentArea: ClassReference("org.apache.royale.jewel.Group"); - > In that case he don't need any gap etc. > > However if he uses different content area in his application it his > responsibilities adding that gap - At least this is how I'm thinking about > that. > > Thoughts ? > Piotr > > wt., 29 sty 2019 o 11:45 Carlos Rovira <[email protected]> > napisał(a): > > > Piotr, I think your problem is with having no gap between items right? > > > > you can get it adding "gap:3" (search for that in other parts of Jewel) > > > > for example: > > > > .verticalContentFormItem > > { > > IFormItemContentArea: ClassReference("org.apache.royale.jewel.VGroup"); > > gap: 3; > > } > > > > remember to add this in sass and not in css or will be override when > > generating all themes > > > > thanks > > > > > > > > El lun., 28 ene. 2019 a las 21:03, Piotr Zarzycki (< > > [email protected]>) escribió: > > > > > Hi Guys, > > > > > > I just make changes which I have mention in other thread. > > > > > > 1. I have removed code which transfers beads through the components. > [1] > > In > > > the results: > > > IBeadLayout - Is responsible for general layout of FormItem (default: > > > HorizontalLayout) > > > IFormItemContentArea - Is responsible for content (default: Group) > > > 2. I have removed IFormItemLayout from default.css cause it wasn't used > > > 3. I have adjusted ToureDeJewel to new changes. However there is one > > > problem which I need to get your thoughts how to resolve. > > > In TourDeJewel example there is FormItem with vertical layout, so to > have > > > them laying out vertically you need: > > > > > > 1. > > > .verticalContentFormItem > > > { > > > IFormItemContentArea: ClassReference("org.apache.royale.jewel.VGroup"); > > > } > > > 2. <j:FormItem label="Favorite movies (at least 2)" className=" > > > verticalContentFormItem" />> > > > > > > In the results we have https://imgur.com/a/gV8DnyS - The same is with > > next > > > item which has content HGroup. > > > > > > Because of that I committed my changes to feature/formitemview_cleanup. > > > I think as a user - I will have to create my own Group which taking > care > > of > > > that stuff - What do you think ? > > > > > > After my changes each part of FormItem is doing the right things and > css > > > looks like that: > > > > > > j|FormItem { > > > IBeadLayout: > > > > ClassReference("org.apache.royale.jewel.beads.layouts.HorizontalLayout"); > > > IBeadView: > > > ClassReference("org.apache.royale.jewel.beads.views.FormItemView"); > > > IBeadModel: > > > ClassReference("org.apache.royale.jewel.beads.models.FormItemModel"); > > > IFormItemContentArea: > ClassReference("org.apache.royale.jewel.Group"); > > > } > > > > > > > > > [1] > > > > > > https://github.com/apache/royale-asjs/commit/2af5cc10fbe064d5176162d8c8ee54f6edd6cafb > > > > > > Thanks, > > > -- > > > > > > Piotr Zarzycki > > > > > > Patreon: *https://www.patreon.com/piotrzarzycki > > > <https://www.patreon.com/piotrzarzycki>* > > > > > > > > > -- > > Carlos Rovira > > http://about.me/carlosrovira > > > > > -- > > Piotr Zarzycki > > Patreon: *https://www.patreon.com/piotrzarzycki > <https://www.patreon.com/piotrzarzycki>* > -- Carlos Rovira http://about.me/carlosrovira
