Yep - This is what I was trying to explain in different thread. That's why I ended up with refactoring and now I'm using my own View.
I'm really curious how you refactor that part. Maybe you will end up with the same changes as me :) Please use branch for more changes if you can. I will try them out immediately cause we are using heavily Form component. Thank you for explanation so far. Piotr On Tue, Feb 26, 2019, 9:51 AM Carlos Rovira <[email protected]> wrote: > Hi Piotr, > > changes are about to trying improve what we have, so I introduced > FormLayout and FormItemLayout (many other components in Jewel that doesn't > has still a specialized layout or has NullLayout will have this change in > the future). Grouped Label and required indicator to better management. > Improved CSS styles to adapt better and reduced a bit size to save space. > > But this changes mostly left things as we had for now. I was studying as > well how make FormItems more flexible, and finally determine that with > current layout is difficult, so I'll be working in few days in a major > refactor of the Jewel FormItem to get default layouts more easy to change, > adapt and be responsive. > > The main problem now is that actual layout is more like a special case and > is not what we should have in a library. > > > > El lun., 25 feb. 2019 a las 17:23, Piotr Zarzycki (< > [email protected]>) escribió: > > > Hi Carlos, > > > > I'm following your changes, but could you later on summarize what you did > > actually ? What was your changes in Form, including yesterdays commits. > > > > Thanks, > > Piotr > > > > pon., 25 lut 2019 o 17:07 <[email protected]> napisał(a): > > > > > This is an automated email from the ASF dual-hosted git repository. > > > > > > carlosrovira pushed a commit to branch develop > > > in repository https://gitbox.apache.org/repos/asf/royale-asjs.git > > > > > > > > > The following commit(s) were added to refs/heads/develop by this push: > > > new 612eb6d labelGroup style in FormItemView > > > 612eb6d is described below > > > > > > commit 612eb6d7d30bf297413702003a261dc8c9443d89 > > > Author: Carlos Rovira <[email protected]> > > > AuthorDate: Mon Feb 25 17:07:18 2019 +0100 > > > > > > labelGroup style in FormItemView > > > --- > > > > .../src/main/royale/org/apache/royale/jewel/beads/views/FormItemView.as > > > | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git > > > > > > a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/FormItemView.as > > > > > > b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/FormItemView.as > > > index e9b4b4f..d85ea6f 100644 > > > --- > > > > > > a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/FormItemView.as > > > +++ > > > > > > b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/FormItemView.as > > > @@ -173,6 +173,7 @@ package org.apache.royale.jewel.beads.views > > > labelGroup = new HGroup(); > > > labelGroup.gap = 2; > > > labelGroup.itemsHorizontalAlign = > > > "itemsCentered"; > > > + labelGroup.className = "labelGroup"; > > > } > > > if (labelGroup != null && labelGroup.parent == > > > null) { > > > (_strand as > > > IContainerBaseStrandChildrenHost).$addElement(labelGroup); > > > > > > > > > > -- > > > > Piotr Zarzycki > > > > Patreon: *https://www.patreon.com/piotrzarzycki > > <https://www.patreon.com/piotrzarzycki>* > > > > > -- > Carlos Rovira > http://about.me/carlosrovira >
