I just tried it in our app and it's working :) Thanks Carlos! czw., 7 mar 2019 o 16:31 Piotr Zarzycki <[email protected]> napisał(a):
> Exactly. Cool thanks for solving it. I will test that tomorrow. > > czw., 7 mar 2019 o 16:27 Carlos Rovira <[email protected]> > napisał(a): > >> Hi Piotr, >> >> just solved it. The problem was caused by a addEventListener that needs to >> be removeEventListener, but due to quick copy/paste I left as original... >> >> In the other hand I limite that code only to Android >> >> >> >> El jue., 7 mar. 2019 a las 15:52, Carlos Rovira (<[email protected] >> >) >> escribió: >> >> > ok Piotr, >> > thanks, will try to solve this regression now >> > sorry for the inconvenience >> > >> > El jue., 7 mar. 2019 a las 15:49, Piotr Zarzycki (< >> > [email protected]>) escribió: >> > >> >> Hi Carlos, >> >> >> >> Nope. I can work on that tomorrow, so if you can do this earlier please >> >> make it so. >> >> >> >> Thanks, >> >> Piotr >> >> >> >> czw., 7 mar 2019 o 15:41 Carlos Rovira <[email protected]> >> >> napisał(a): >> >> >> >> > Hi Piotr, >> >> > >> >> > have you tried your solution? I think is a mix of both: >> >> > >> >> > a) we don't need this update if device is not Android, so we need to >> >> put a >> >> > solution for maxlength *nly* for that device >> >> > b) we need to solve the issue you discover, I tried and find the >> same. >> >> > >> >> > So my question is, did you try your solution to solve b) ? >> >> > I 'll work right now in solve both issues, so please let me know >> >> > >> >> > thanks >> >> > >> >> > El jue., 7 mar. 2019 a las 11:17, Piotr Zarzycki (< >> >> > [email protected]>) >> >> > escribió: >> >> > >> >> > > I need to think about that, but I just discovered that you are >> >> actually >> >> > > checking in whether maxLength is greater than zero, but you are >> >> > registering >> >> > > event instead removing i. [1] >> >> > > >> >> > > Maybe it should be remove in this place ? >> >> > > >> >> > > [1] >> >> > > >> >> > > >> >> > >> >> >> https://github.com/apache/royale-asjs/blob/2e91b52be7884ff7da91411ec5119e3b0e887f90/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/validators/StringValidator.as#L167 >> >> > > >> >> > > Thanks, >> >> > > Piotr >> >> > > >> >> > > czw., 7 mar 2019 o 10:53 Carlos Rovira <[email protected]> >> >> > > napisał(a): >> >> > > >> >> > > > Hi Piotr, >> >> > > > >> >> > > > since that modification was set only to solve maxlength on >> Android >> >> > (that >> >> > > > doesn't work as in the rest of browsers), I was thinking >> yesterday >> >> on >> >> > set >> >> > > > up the keyup listener in that code only if OSUtils reports >> Android >> >> as >> >> > the >> >> > > > OS. What do you think? >> >> > > > >> >> > > > El jue., 7 mar. 2019 a las 8:04, Piotr Zarzycki (< >> >> > > > [email protected]>) >> >> > > > escribió: >> >> > > > >> >> > > > > Hi Carlos, >> >> > > > > >> >> > > > > I bump today into issue where having following code [1] and >> >> writing >> >> > > > > anything in the TextInput is being wipe out. [2] It causes by >> that >> >> > > method >> >> > > > > where you are forcing some text length even if maxLength is 0 >> [3] >> >> - >> >> > Do >> >> > > > you >> >> > > > > see any issue if we prevent from executing that logic when >> >> maxLenght >> >> > is >> >> > > > 0 ? >> >> > > > > >> >> > > > > [1] https://paste.apache.org/2q5H >> >> > > > > [2] https://gph.is/g/4M07AWZ >> >> > > > > [3] >> >> > > > > >> >> > > > > >> >> > > > >> >> > > >> >> > >> >> >> https://github.com/apache/royale-asjs/blob/2e91b52be7884ff7da91411ec5119e3b0e887f90/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/validators/StringValidator.as#L121 >> >> > > > > >> >> > > > > Thanks, >> >> > > > > -- >> >> > > > > >> >> > > > > Piotr Zarzycki >> >> > > > > >> >> > > > > Patreon: *https://www.patreon.com/piotrzarzycki >> >> > > > > <https://www.patreon.com/piotrzarzycki>* >> >> > > > > >> >> > > > >> >> > > > >> >> > > > -- >> >> > > > Carlos Rovira >> >> > > > http://about.me/carlosrovira >> >> > > > >> >> > > >> >> > > >> >> > > -- >> >> > > >> >> > > Piotr Zarzycki >> >> > > >> >> > > Patreon: *https://www.patreon.com/piotrzarzycki >> >> > > <https://www.patreon.com/piotrzarzycki>* >> >> > > >> >> > >> >> > >> >> > -- >> >> > Carlos Rovira >> >> > http://about.me/carlosrovira >> >> > >> >> >> >> >> >> -- >> >> >> >> Piotr Zarzycki >> >> >> >> Patreon: *https://www.patreon.com/piotrzarzycki >> >> <https://www.patreon.com/piotrzarzycki>* >> >> >> > >> > >> > -- >> > Carlos Rovira >> > http://about.me/carlosrovira >> > >> > >> >> -- >> Carlos Rovira >> http://about.me/carlosrovira >> > > > -- > > Piotr Zarzycki > > Patreon: *https://www.patreon.com/piotrzarzycki > <https://www.patreon.com/piotrzarzycki>* > -- Piotr Zarzycki Patreon: *https://www.patreon.com/piotrzarzycki <https://www.patreon.com/piotrzarzycki>*
