Ok, I'm working on a local branch. This is more tricky than expected, but I think working in night hours I can get it in few days. For now I have the following separation:
-MXCore -MXRoyale (Maybe refactor to a more conveniente name like MXFramework to match better Flex) -MXCollections -RPC Will continue tomorrow El mar., 12 mar. 2019 a las 20:38, Alex Harui (<[email protected]>) escribió: > OK, give it a try. > > -Alex > > On 3/12/19, 11:47 AM, "Carlos Rovira" <[email protected]> wrote: > > Hi Alex, > > starting on the task. Seems to get proper separation I need to > separate at > least in : > > - MXRoyale (current one) > - RPC > - MXCollections > - ResourceBundles > > This is due to RPC and MXRoyale needs to use Collections and > ResourceBundles > I think that's all but maybe some other requirement could need other > separation too. > > Optionaly (should be done but maybe don't need yet) > > - Modules > - MXValidators > - MXFormatters > (this latest 2 maybe could be just one SWC) > > > > > > El mar., 12 mar. 2019 a las 18:21, Alex Harui > (<[email protected]>) > escribió: > > > Hi Carlos, > > > > The more work we require of folks using emulation, the less likely > they > > will be to use it. Please revert this change and factor out the MX > RPC > > into another SWC. > > > > Thanks, > > -Alex > > > > On 3/12/19, 10:15 AM, "Carlos Rovira" <[email protected]> > wrote: > > > > Hi Alex, > > > > I recommend themes, but it could be done in the same SWC. What's > > needed to > > avoid is to define font-sizes, colors, and other kind of sensible > > visuals > > in a global space, since this affects to other things. > > For example this part ends in our real app and that should not > be the > > case. > > Is a problem. I was pursuing Jewel Alerts and Snackbars showing > > strangely > > with different font faces and sizes, and finally found that our > app was > > affected my MXRoyale default CSS. > > > > A part from that I think Flex was oriented to themes, although > has a > > default look and feel. I think making flex users uses nor just > > MXRoyale but > > an additional SWC should not make a problem and should be even > > benefitial. > > We 're talking about just another one more SWC to the build...so > this > > seems > > to me that it doesn't should be a problem for people migrating. > But > > that's > > is only my opinion and others should see if is appropriate or > take > > other > > path. I though the plan was add Jewel look and feel at some > place in > > time. > > But I don't say that should happen if you have other path in > mind. > > > > I think one the real solution for this (a part from decide the > previous > > thing) should be to separate RPC classes from MX-SPARK SWC, > since that > > could be used with other libs in Royale. The same for validators > and > > formatters. > > > > One of the main problems is to have UI sets in class path for > people > > don't > > want to use, available by default, since when you're working > with and > > IDE > > you're getting hints for that sets what makes you development > more > > cumbersome and complicated. As an user if in VSCode I start to > write > > "Butt" > > and get hints, if I only use Jewel I expect to get just "Jewel > > Button", not > > lots of possible Buttons. So this should be done with approiate > configs > > xml, but as well with appropriate separation of classes in SWCs > > > > I could start the MX RPC separation if you think is ok. I think > you had > > this as well in mind. > > > > > > > > El mar., 12 mar. 2019 a las 16:38, Alex Harui > > (<[email protected]>) > > escribió: > > > > > Hi Carlos, > > > > > > Given that Flex users didn't have to use themes, why would we > want to > > > force them to use themes? The whole point of emulation is to > > minimize > > > changes to their code and build processes. > > > > > > -Alex > > > > > > On 3/12/19, 7:09 AM, "[email protected]" < > > [email protected]> > > > wrote: > > > > > > This is an automated email from the ASF dual-hosted git > > repository. > > > > > > carlosrovira pushed a commit to branch develop > > > in repository > > > > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&data=02%7C01%7Caharui%40adobe.com%7C926add31045c4cc4dbce08d6a71b3384%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636880132610627320&sdata=ywOr%2FVR%2FL6p0jpz4kYJZBjgWBi9Z9NWha1uVz6bF2fs%3D&reserved=0 > > > > > > > > > The following commit(s) were added to refs/heads/develop > by this > > push: > > > new ac1aec3 Warning: This kind of global styles > affect the > > rest > > > of UI sets so this should not done this way to avoid conflicts. > > Separate > > > color, sizes and other visual things in themes > > > ac1aec3 is described below > > > > > > commit ac1aec3b3e1b4739088d183b7cc1a8ddc776157a > > > Author: Carlos Rovira <[email protected]> > > > AuthorDate: Tue Mar 12 15:08:59 2019 +0100 > > > > > > Warning: This kind of global styles affect the rest of > UI > > sets so > > > this should not done this way to avoid conflicts. Separate > color, > > sizes and > > > other visual things in themes > > > --- > > > > frameworks/projects/MXRoyale/src/main/resources/defaults.css | > > 4 ---- > > > 1 file changed, 4 deletions(-) > > > > > > diff --git > > > a/frameworks/projects/MXRoyale/src/main/resources/defaults.css > > > b/frameworks/projects/MXRoyale/src/main/resources/defaults.css > > > index fa07350..0951b82 100644 > > > --- > > a/frameworks/projects/MXRoyale/src/main/resources/defaults.css > > > +++ > > b/frameworks/projects/MXRoyale/src/main/resources/defaults.css > > > @@ -29,11 +29,7 @@ > > > box-sizing: border-box; > > > } > > > > > > -* { > > > - font-family: Verdana; > > > - font-size: 12px; > > > > > > -} > > > > > > global { > > > IStatesImpl: > > > > ClassReference("org.apache.royale.core.StatesWithTransitionsImpl"); > > > > > > > > > > > > > > > > -- > > Carlos Rovira > > > > > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C926add31045c4cc4dbce08d6a71b3384%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636880132610627320&sdata=FYvXmGC3YOkehXFGT361MpAglPE1wVttLMPA698lWxk%3D&reserved=0 > > > > > > > > -- > Carlos Rovira > > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C926add31045c4cc4dbce08d6a71b3384%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636880132610627320&sdata=FYvXmGC3YOkehXFGT361MpAglPE1wVttLMPA698lWxk%3D&reserved=0 > > > -- Carlos Rovira http://about.me/carlosrovira
