Hi Piotr, El dom., 21 abr. 2019 a las 17:49, Piotr Zarzycki (< [email protected]>) escribió:
> Hi Carlos, > > Comments inline. > > On Sun, Apr 21, 2019, 1:19 PM Carlos Rovira <[email protected]> > wrote: > > > Hi Piotr, > > > > I just see a problem with Jewel FormValidator that just uploaded that was > > causing trigger CHANGE event as we move between controls in a Form. > > > > Are you saying that the only issue which you have found after my update > > was that CHANGE event were triggered when you do what in the Form? I > don't > > understand here fully. > > No. I see lots of errors in my App, but analyzing all I saw that was caused by the need of update all my validators to remove code that now can be there (like addEventListener, and things like that). So all that changes (about 30-40 file changes) where all on my app code side. The only one visible to you was FormValidator that is in Royale. > In order to fix that you had to override strand in FormValidator - I've > > seen your commit. > > > > Rest of problems was the need to update all our custom validators to the > > new code (we have many). > > So I think all is ok now. > > > > This change make we save several lines of code in most classes since we > can > > remove strand function override from almost all code. > > > > Thanks for rise this problem and fix it! :) > > > > Cool that it helped simplify stuff in your custom validators. More > helpful > > stuff will come. ;) > Yeah! :). One more thing we will need to here is to separate visuals from validation itself like Alex recommend, but this change will be more "hard" to do it. We need to give possibility to use floating errortooltips or instead just a label as sibling of the control for example, like people do in more simple forms. But I think we know have a good working Validator framework for Royale :). -- Carlos Rovira http://about.me/carlosrovira
