Re: Reverting dialogPolyfill call from dot access to bracket

[Carlos Rovira]

Hope someone could take a look at this

the change is this:

window["dialogPolyfill"]["registerDialog"](dialog);
// dialogPolyfill.registerDialog(dialog);

that is mostly the same for hljs, that is working

hljs.highlightBlock(block);

                //var hljs:Object = window["hljs"];
                //prevent renaming by compiler
                //hljs["highlightBlock"](block);

very strange isn't it?

thanks

Carlos




El lun., 6 may. 2019 a las 20:43, Carlos Rovira (<carlosrov...@apache.org>)
escribió:

> Hi,
>
> trying release mode of TDJ I saw it was failing with a blank page, this is
> due to lastest change I did calling dialogPolyFill
> you can see the line I change in my latest commit.
> This works ok in debug mode, but not in release mode
>
> I did mostly the same for hljs as Josh pointed me, but this time this not
> worked and breaks the app
>
> someone know what could be wrong?
>
> thanks
>
> --
> Carlos Rovira
> http://about.me/carlosrovira
>
>

-- 
Carlos Rovira
http://about.me/carlosrovira