VScode and Moonshine use go_to_definition_help, and I've observed it doesn't always go to the correct location. I knew it had something to do with line endings, but I never quite figured out exactly what was wrong. You're changes probably won't make anything worse.
> if you pull up an AS source file packaged with Flash Builder in Notepad on > Windows it is unreadable It is worth mentioning that Notepad in Windows 10 has recently been updated to support files with Unix line endings. - Josh On 2019/06/02 14:56:38, Alex Harui <[email protected]> wrote: > Folks working on the newer IDEs: > > I discovered that Royale is building SWCs a bit differently than Flex > apparently did. It appears that Flex assumed source code always had Unix > line-endings (just LF, not CRLF as on Windows) and thus that the > go_to_definition_help metadata in the SWCs (that is supposedly there for > code-intelligence) was set accordingly. > > I am going to make the same changes for Royale. I will probably just enable > those changes if I know we are building release artifacts unless folks think > it doesn't matter. But these changes may affect how the > go_to_definition_help offsets on Windows match up against the source code. > It looks like Adobe Flash Builder packaged the source code with Unix > line-endings so it would match the go_to_definition_help metadata but if you > pull up an AS source file packaged with Flash Builder in Notepad on Windows > it is unreadable. Flash Builder itself is smart enough to handle Unix > line-endings in source on Windows. > > Thoughts? > -Alex > >
