I get that too after picking up Piotr's change. I think somehow something changed in Rat and it is now interpreting paths differently than it used to. I'm trying a fix using **/fb.properties. I'll commit it if it works.
-Alex On 6/12/19, 11:47 AM, "Piotr Zarzycki" <[email protected]> wrote: That's weird, cause I made a fix for it. Do you have my fix ? śr., 12 cze 2019 o 20:43 Carlos Rovira <[email protected]> napisał(a): > Now I'm getting in rat.txt > > Files with unapproved licenses: > > > /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/fb.properties > > :? > > > > El mié., 12 jun. 2019 a las 20:40, Carlos Rovira (<[email protected] > >) > escribió: > > > Curious, > > > > no rebuilding all from scratch with latest changes: > > > > BUILD SUCCESSFUL > > > > Total time: 2 seconds > > > > [*ERROR*] Failed to execute goal > > org.apache.rat:apache-rat-plugin:0.13:check *(license-check)* on project > > frameworks: *Too many files with unapproved license: 1 See RAT report in: > > > /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/target/rat.txt* > > -> *[Help 1]* > > > > [*ERROR*] > > > > [*ERROR*] To see the full stack trace of the errors, re-run Maven with > > the *-e* switch. > > > > [*ERROR*] Re-run Maven using the *-X* switch to enable full debug > logging. > > > > [*ERROR*] > > > > hehe, going to see what could be :) > > > > > > El mié., 12 jun. 2019 a las 20:37, Piotr Zarzycki (< > > [email protected]>) escribió: > > > >> Yeah. That's worth on investigation/observation why you haven't seen > that > >> error locally. > >> > >> śr., 12 cze 2019 o 20:34 Carlos Rovira <[email protected]> > >> napisał(a): > >> > >> > Hi, don't understand why I don't get that fail locally. Also, > something > >> > that I was seeing since many time is that errors are logged twice. > Seems > >> > like some code in compiler is running duplicated. > >> > > >> > Coming back to hljs problem. how can I reproduce that problem locally > in > >> > order to fix it? > >> > > >> > > >> > > >> > El mié., 12 jun. 2019 a las 18:36, Alex Harui > (<[email protected] > >> >) > >> > escribió: > >> > > >> > > I have no idea why we haven't seen that rat problem before, but now > >> that > >> > > Piotr fixed it, build 1908 is back to the same error most other > builds > >> > have > >> > > had. > >> > > > >> > > > >> > > >> > F:\jenkins\jenkins-slave\workspace\Royale-asjs\examples\blog\BE0012_Using_external_javascript_libraries_in_Apache_Royale\src\main\royale\BE0012_Using_external_javascript_libraries_in_Apache_Royale.mxml(33): > >> > > col: 22 Error: Call to a possibly undefined method highlightBlock > >> > through a > >> > > reference with static type hljs. > >> > > > >> > > hljs.highlightBlock(sourceCodeMXMLText.element); > >> > > ^ > >> > > > >> > > > >> > > >> > F:\jenkins\jenkins-slave\workspace\Royale-asjs\examples\blog\BE0012_Using_external_javascript_libraries_in_Apache_Royale\src\main\royale\BE0012_Using_external_javascript_libraries_in_Apache_Royale.mxml(33): > >> > > col: 22 Error: Call to a possibly undefined method highlightBlock > >> > through a > >> > > reference with static type hljs. > >> > > > >> > > hljs.highlightBlock(sourceCodeMXMLText.element); > >> > > > >> > > -Alex > >> > > > >> > > On 6/12/19, 7:56 AM, "Piotr Zarzycki" <[email protected]> > >> > wrote: > >> > > > >> > > Carlos, > >> > > > >> > > Log is saying that this file is a problem for rat. In order to > >> > confirm > >> > > it > >> > > you need to go to Workspace on Jenkins. Report from Rat [1] > >> > > > >> > > [1] > >> > > > >> > > >> > https://builds.apache.org/job/Royale-asjs/ws/target/rat.txt > >> > > > >> > > On Wed, Jun 12, 2019, 4:43 PM Carlos Rovira < > >> [email protected] > >> > > > >> > > wrote: > >> > > > >> > > > Hi Piotr, > >> > > > > >> > > > just to make sure we're on the same page: > >> > > > * don't think fb.properties is a problem, and don't see any > log > >> > > reporting > >> > > > that file is involved in something wrong, I searched for it in > >> the > >> > > log that > >> > > > report the failure and is listed as an exclusion what is > >> completely > >> > > right. > >> > > > * I have RAT turn on > >> > > > * What I tried to express is that the folder used by Jenkins > >> (for > >> > us > >> > > our > >> > > > "royale-asjs" folder) must have some temp folder or file(s) > that > >> > > should be > >> > > > removed. When this happen in my local machine, I go to rat.txt > >> in > >> > the > >> > > > target folder that is failing and see what files report. If > the > >> > > files are > >> > > > AS3 code, I add the corresponding license header, if the > problem > >> > > comes from > >> > > > files not removed in a previous build for whatever reason, I > >> need > >> > to > >> > > remove > >> > > > them manually. > >> > > > > >> > > > You can check for this if you know why, or I can do it, > >> although I > >> > > never > >> > > > try to browse that Jenkin server folder, so I'll need some > >> guidance > >> > > in > >> > > > order to know how to connect and how to localize that server > >> > folder. > >> > > Once I > >> > > > got there, I can do the job. > >> > > > > >> > > > thanks > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > El mié., 12 jun. 2019 a las 12:09, Piotr Zarzycki (< > >> > > > [email protected]>) escribió: > >> > > > > >> > > > > Maybe it is placed in a wrong pom file ? Just a shoot in the > >> > dark. > >> > > > > > >> > > > > śr., 12 cze 2019 o 11:21 Carlos Rovira < > >> [email protected]> > >> > > > > napisał(a): > >> > > > > > >> > > > > > about that file is already excluded in main pom.xml in the > >> RAT > >> > > plugin > >> > > > > > section. For that reason build does not complain for it: > >> > > > > > > >> > > > > > <!-- FlashBuilder settings. frameworks/fb.properties > >> contains > >> > > Alex' > >> > > > path > >> > > > > > entries and should be removed --> > >> > > > > > <exclude>fb.properties</exclude> > >> > > > > > > >> > > > > > El mié., 12 jun. 2019 a las 10:55, Piotr Zarzycki (< > >> > > > > > [email protected]>) escribió: > >> > > > > > > >> > > > > > > Well that file [1] was added two years ago, so maybe it > >> still > >> > > needed. > >> > > > > > > > >> > > > > > > [1] > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > https://github.com/apache/royale-asjs/blob/develop/frameworks/fb.properties > >> > > > > > > > >> > > > > > > śr., 12 cze 2019 o 10:46 Carlos Rovira < > >> > > [email protected]> > >> > > > > > > napisał(a): > >> > > > > > > > >> > > > > > > > Hi Piotr, > >> > > > > > > > > >> > > > > > > > in my experience this use to happen when some tries > has > >> > been > >> > > done > >> > > > > that > >> > > > > > > > created files that was not removed, then maven pass > and > >> > find > >> > > that > >> > > > > kind > >> > > > > > of > >> > > > > > > > files. For example, if I try to build with VSCode > >> > CTRL+ENTER > >> > > quick > >> > > > > > build > >> > > > > > > > and generate a bin folder, then I need to remove or > I'll > >> > get > >> > > a RAT > >> > > > > > error > >> > > > > > > > when pass maven. My bet is that we have files staled > >> that > >> > > need to > >> > > > be > >> > > > > > > > removed > >> > > > > > > > > >> > > > > > > > El mié., 12 jun. 2019 a las 10:40, Piotr Zarzycki (< > >> > > > > > > > [email protected]>) escribió: > >> > > > > > > > > >> > > > > > > > > How your local build didn't report that ? Do you > have > >> RAT > >> > > > checking > >> > > > > > > > disabled > >> > > > > > > > > for local build ? > >> > > > > > > > > > >> > > > > > > > > śr., 12 cze 2019 o 10:33 Piotr Zarzycki < > >> > > > [email protected] > >> > > > > > > >> > > > > > > > > napisał(a): > >> > > > > > > > > > >> > > > > > > > > > Hi Carlos, > >> > > > > > > > > > > >> > > > > > > > > > This file is without license header > >> > > > "frameworks/fb.properties" - > >> > > > > > > This > >> > > > > > > > is > >> > > > > > > > > > Flash Builder related file actually ? > >> > > > > > > > > > > >> > > > > > > > > > śr., 12 cze 2019 o 10:25 Carlos Rovira < > >> > > > [email protected]> > >> > > > > > > > > > napisał(a): > >> > > > > > > > > > > >> > > > > > > > > >> Seems a problem with the files without license > (RAT > >> > > plugin) > >> > > > > right? > >> > > > > > > > > >> > >> > > > > > > > > >> [ERROR] Failed to execute goal > >> > > > > > > > > >> org.apache.rat:apache-rat-plugin:0.12:check > >> > > (license-check) on > >> > > > > > > project > >> > > > > > > > > >> royale-framework-parent: Too many files with > >> > unapproved > >> > > > > license: 1 > >> > > > > > > See > >> > > > > > > > > >> RAT report in: > >> > > > > > > > > >> > >> > > f:\jenkins\jenkins-slave\workspace\Royale-asjs\target\rat.txt > >> > > > > > > > > >> -> [Help 1][ERROR] [ERROR] To see the full stack > >> trace > >> > > of the > >> > > > > > > errors, > >> > > > > > > > > >> re-run Maven with the -e switch.[ERROR] Re-run > >> Maven > >> > > using the > >> > > > > -X > >> > > > > > > > > >> switch to enable full debug logging.[ERROR] > [ERROR] > >> > For > >> > > more > >> > > > > > > > > >> information about the errors and possible > >> solutions, > >> > > please > >> > > > read > >> > > > > > the > >> > > > > > > > > >> following articles:[ERROR] [Help 1] > >> > > > > > > > > >> > >> > > > > > > > >> > > > > >> > > > >> > > >> > http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException > >> > > > > > > > > >> > >> > > > > > > > > >> > >> > > > > > > > > >> > >> > > > > > > > > >> > >> > > > > > > > > >> El mié., 12 jun. 2019 a las 10:18, Apache Jenkins > >> > > Server (< > >> > > > > > > > > >> [email protected]>) escribió: > >> > > > > > > > > >> > >> > > > > > > > > >> > The Apache Jenkins build system has built > >> > Royale-asjs > >> > > (build > >> > > > > > > #1905) > >> > > > > > > > > >> > > >> > > > > > > > > >> > Status: Still Failing > >> > > > > > > > > >> > > >> > > > > > > > > >> > Check console output at > >> > > > > > > > > > >> > > > >> > > >> > https://builds.apache.org/job/Royale-asjs/1905/ > >> > > > > > > > > >> > to view the results. > >> > > > > > > > > >> > >> > > > > > > > > >> > >> > > > > > > > > >> > >> > > > > > > > > >> -- > >> > > > > > > > > >> Carlos Rovira > >> > > > > > > > > >> > >> > > > >> > > >> > http://about.me/carlosrovira > >> > > > > > > > > >> > >> > > > > > > > > > > >> > > > > > > > > > > >> > > > > > > > > > -- > >> > > > > > > > > > > >> > > > > > > > > > Piotr Zarzycki > >> > > > > > > > > > > >> > > > > > > > > > Patreon: * > >> > > > >> > > >> > https://www.patreon.com/piotrzarzycki > >> > > > > > > > > > < > >> > > > >> > > >> > https://www.patreon.com/piotrzarzycki > >> > > >* > >> > > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > -- > >> > > > > > > > > > >> > > > > > > > > Piotr Zarzycki > >> > > > > > > > > > >> > > > > > > > > Patreon: * > >> > > > >> > > >> > https://www.patreon.com/piotrzarzycki > >> > > > > > > > > < > >> > > > >> > > >> > https://www.patreon.com/piotrzarzycki > >> > > >* > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > > >> > > > > > > > -- > >> > > > > > > > Carlos Rovira > >> > > > > > > > > >> > > > >> > > >> > http://about.me/carlosrovira > >> > > > > > > > > >> > > > > > > > >> > > > > > > > >> > > > > > > -- > >> > > > > > > > >> > > > > > > Piotr Zarzycki > >> > > > > > > > >> > > > > > > Patreon: * > >> > > > >> > > >> > https://www.patreon.com/piotrzarzycki > >> > > > > > > < > >> > > > >> > > >> > https://www.patreon.com/piotrzarzycki > >> > > >* > >> > > > > > > > >> > > > > > > >> > > > > > > >> > > > > > -- > >> > > > > > Carlos Rovira > >> > > > > > > >> > > > >> > > >> > http://about.me/carlosrovira > >> > > > > > > >> > > > > > >> > > > > > >> > > > > -- > >> > > > > > >> > > > > Piotr Zarzycki > >> > > > > > >> > > > > Patreon: * > >> > > > >> > > >> > https://www.patreon.com/piotrzarzycki > >> > > > > < > >> > > > >> > > >> > https://www.patreon.com/piotrzarzycki > >> > > >* > >> > > > > > >> > > > > >> > > > > >> > > > -- > >> > > > Carlos Rovira > >> > > > > >> > > > >> > > >> > http://about.me/carlosrovira > >> > > > > >> > > > >> > > > >> > > > >> > > >> > -- > >> > Carlos Rovira > >> > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Cbb7c267aae714acc63fa08d6ef666478%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636959620434775979&sdata=ageN%2F%2F1LHSElllQ8h7QKD23ExUAVSR9rtMqnJgpsa2E%3D&reserved=0 > >> > > >> > >> > >> -- > >> > >> Piotr Zarzycki > >> > >> Patreon: *https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cbb7c267aae714acc63fa08d6ef666478%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636959620434775979&sdata=dMqIQhUowbVkrv%2FMhjT23r2XyTIJkDXmNjlihqRiwvM%3D&reserved=0 > >> <https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cbb7c267aae714acc63fa08d6ef666478%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636959620434775979&sdata=dMqIQhUowbVkrv%2FMhjT23r2XyTIJkDXmNjlihqRiwvM%3D&reserved=0>* > >> > > > > > > -- > > Carlos Rovira > > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Cbb7c267aae714acc63fa08d6ef666478%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636959620434775979&sdata=ageN%2F%2F1LHSElllQ8h7QKD23ExUAVSR9rtMqnJgpsa2E%3D&reserved=0 > > > > > > -- > Carlos Rovira > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Cbb7c267aae714acc63fa08d6ef666478%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636959620434775979&sdata=ageN%2F%2F1LHSElllQ8h7QKD23ExUAVSR9rtMqnJgpsa2E%3D&reserved=0 > -- Piotr Zarzycki Patreon: *https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cbb7c267aae714acc63fa08d6ef666478%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636959620434785975&sdata=5wGKH%2FQljZV1mCeZJHGwJuuZBTWpzJe12erxhSSBrvs%3D&reserved=0 <https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cbb7c267aae714acc63fa08d6ef666478%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636959620434785975&sdata=5wGKH%2FQljZV1mCeZJHGwJuuZBTWpzJe12erxhSSBrvs%3D&reserved=0>*
