Hi Yishay, If there's a problem with this I will address it asap. The setting was not working correctly before. I think it is now, so that may have affected the output, but perhaps there are some test cases I did not cover.
skipAsCoercions only relates to explicit coercions, and should not have an effect on the implicit coercions (But it does make me wonder if I have implemented the new config level option correctly, maybe it should be added as one of the -js-output-optimization options instead of being another top level option. I can revisit this in another thread.) For now, the equivalent is <js-complex-implicit-coercions>false</js-complex-implicit-coercions> or -js-complex-implicit-coercions=false Do you have either of those set? If so then you should not see the implicit coercions unless they are toggled on locally and therefore it is an error Can you please also use 'find in files' with your js-debug output, searching for the text: /* implicit cast */ and inspect the site of the runtime error? Is it generating the right cast on the right for the expected type on the left if it is assignment? On Thu, Jun 20, 2019 at 2:00 AM Yishay Weiss <[email protected]> wrote: > After updating the compiler we’re getting a runtime type coercion failure > which didn’t exist before. > > A quick question: should ‘skipAsCoercions’ suppress implicit casts? Could > the latest commit [1] have changed that? > > [1] > https://github.com/apache/royale-compiler/commit/73caf20e03b72bb9e1717f2339c14cb79c6082b9 > > Thanks. >
