I have confirmed that these SWCs are defined on the library-path in the
compile-js-config.xml used to build JewelJS.swc. Instead, it should be
using the external-library-path or js-external-library-path.
In compile-swf-config.xml for Jewel.swc, the dependencies are correctly
defined on external-library-path so that they aren't included in Jewel.swc.
Unfortunately, my initial attempts to use external-library-path or
js-external-library-path are running into issues. I worry that it may be
related to this comment in compile-js-config.xml where the SWCs were added
to the library-path:
<!-- asjscompc won't 'link' these classes in, but will list their requires
if these swcs are on the external-library-path then their requires
will not be listed -->
I could be wrong, but I interpret this comment to mean that goog.require()
is not added if something is on the external-library-path. That sounds like
a bug in the compiler, and this was more of a workaround than the correct
way to fix things.
--
Josh Tynjala
Bowler Hat LLC <https://bowlerhat.dev>
On Tue, Jul 9, 2019 at 2:35 PM Josh Tynjala <joshtynj...@bowlerhat.dev>
wrote:
> It looks like JewelJS.swc includes some classes in the SWC that probably
> shouldn't be there. One example (but there are many more):
> org.apache.royale.states.State.
>
> These are core classes that should be from dependencies, and I suspect
> that something might be on the library-path instead of the
> external-library-path. Because the compiler found the class in JewelJS.swc,
> it assumes that it needs defaults.css from JewelJS.swc too.
>
> To try to reproduce this issue, I created a sample app that uses only
> Basic components. I'm seeing that the compiler is trying to use
> defaults.css from Basic, Express, Jewel, and MaterialDesignLite.
>
> I'll take a look at the compiler options for some of the other SWCs to see
> if anything catches my eye.
>
> --
> Josh Tynjala
> Bowler Hat LLC <https://bowlerhat.dev>
>
>
> On Tue, Jul 9, 2019 at 3:21 AM Harbs <harbs.li...@gmail.com> wrote:
>
>> I have no jewel components in my app, but I’m suddenly seeing TONS of
>> jewel css in my app.
>>
>> Similarly, I’m seeing Basic CSS (such as Button) which did not used to be
>> included (and is messing up the visuals in my app).
>>
>> Has something changed with the logic which includes CSS?
>>
>> Harbs
>
>
