Hi Carlos, I see you did commit to 0.9.6 branch, so we are good unless there is something left in develop which should I pick. I will review all of that on Monday.
Thanks, Piotr On Sat, Sep 14, 2019, 5:26 PM Carlos Rovira <carlosrov...@apache.org> wrote: > Hi Piotr, > > seems there was a little confusion here and Greg and I did the changes in > the release version of RELEASE_NOTES. > Hope you can merge both in your process. I followed my changes since > December to try to bring all relevant things done. > Thanks > > El sáb., 14 sept. 2019 a las 15:39, Piotr Zarzycki (< > piotrzarzyck...@gmail.com>) escribió: > > > Hi Greg, > > > > I'm sorry for a late response. I'm going to take what's develop has in it > > on Monday by cherry picking - to do not break release branch, so where > you > > commit it will be good and won't miss it. > > > > Thanks, > > Piotr > > > > pt., 13 wrz 2019 o 19:24 Greg Dove <greg.d...@gmail.com> napisał(a): > > > > > Hi Piotr, > > > > > > I'm not so familiar with the release process. Do you want additions to > go > > > directly into the release branch or should that be added to develop > > > (assuming you would merge into release)? > > > > > > I see Josh added note about RoyalUnit in develop [1], which is not yet > in > > > release.[2] . So perhaps you will merge from develop? I'm not sure how > > this > > > all needs to work. > > > > > > I'm thinking to add the following to 0.9.6 release notes (changes since > > > 0.9.4) for some of the things I worked on: > > > > > > -Improvements to AMF / RemoteObject Support > > > -AMFBinaryData api now matches flash.utils.ByteArray, (the missing > > feature > > > is non-UTF String encoding support). It therefore now works for deep > > > cloning via readObject/writeObject and registerClassAlias. > > > -Updates to Royale collections library with support for sorting and > > > filtering via ArrayListView. Simple example added to Tour de Jewel > > > -A conforming runtime implementation of AS3 Vector (typed Arrays) was > > added > > > for javascript output, with options for avoiding certain runtime > checks. > > > -int, uint, Class are now represented as simple, distinct types (Class > is > > > now not 'Object', int is now not 'Number' for example), and these > support > > > indirect 'as' or 'is' type checking and instantiation, matching swf > > > behavior. > > > -General Improvements and additions in Reflection library > > > -New Apache Royale Crux MVC/DI/IOC application architecture library > > (based > > > on Swiz Framework) was added, with some simple examples > > > > > > If it's too late to add those, no worries, I can add that to the > 'Updates > > > to the RELEASE_NOTES discovered after this file was packaged' wiki > > > > > > 1. https://github.com/apache/royale-asjs/blob/develop/RELEASE_NOTES.md > > > 2. > > > > > > https://github.com/apache/royale-asjs/blob/release/0.9.6/RELEASE_NOTES.md > > > > > > > > > Thanks, > > > Greg > > > > > > On Fri, Sep 13, 2019 at 8:49 PM Piotr Zarzycki < > > piotrzarzyck...@gmail.com> > > > wrote: > > > > > > > Hi Guys, > > > > > > > > I would like to cut RC1 again on Monday, so if anything should be > > tested > > > or > > > > added please do so before Monday. > > > > > > > > Let me know if anything is against that. > > > > > > > > Thanks, > > > > Piotr > > > > > > > > On Fri, Sep 13, 2019, 12:32 AM Alex Harui <aha...@adobe.com.invalid> > > > > wrote: > > > > > > > > > I pushed changes to update the config.xml files. It seemed to work > > for > > > > > me. Try beta10 if you want to test it. > > > > > > > > > > npm install @apache-royale/royale-js-swf@0.9.6-beta10 -g > > > > > > > > > > Thanks, > > > > > -Alex > > > > > > > > > > On 9/12/19, 10:56 AM, "Alex Harui" <aha...@adobe.com.INVALID> > > wrote: > > > > > > > > > > I guess that’s expected. I didn’t realize I had a > > > PLAYERGLOBAL_HOME > > > > > environment variable that was overriding. > > > > > > > > > > The post install script would have to go replace the > > target-player > > > in > > > > > every -config.xml file (like royale-config.xml). If you add > > > > > -target-player=25.0, that will get you past it. > > > > > > > > > > Another option is to have the install download 11.1 instead of > > > 25.0. > > > > > > > > > > Thoughts? > > > > > -Alex > > > > > > > > > > > > > > > On 9/12/19, 10:30 AM, "Carlos Rovira" <carlosrov...@apache.org > > > > > > wrote: > > > > > > > > > > Hi Alex, > > > > > > > > > > I uninstall then install again. Commented all my paths > > (royale, > > > > > flash > > > > > player, AIR,...) in my .bash_profile. Then open a new > > terminal > > > > > window. > > > > > > > > > > Results: > > > > > > > > > > macbookpro:~ carlosrovira$ mxmlc > > > > > > > > > > Using Royale Compiler codebase: > > > > > > > > > > > > > > > > > > > > /usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/js/bin/../.. > > > > > > > > > > Using Royale SDK: > > > > > > > > > > > > > > > > > > > > /usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/js/bin/../.. > > > > > > > > > > MXMLJSC > > > > > > > > > > > > > > > > > > > > > > > > > +royalelib=/usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/js/bin/../../frameworks > > > > > > > > > > > > > > > > > > > > > > > > > -sdk-js-lib=/usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/js/bin/../../frameworks/js/Royale/generated-sources > > > > > > > > > > > > > > > > > > > > > > > > > /usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/frameworks/royale-config.xml(74): > > > > > col: 0 Error: unable to open > > > > > > > > > > > > > > > > > > > > '/usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/frameworks/libs/player/11.1/playerglobal.swc'. > > > > > > > > > > > > > > > > > > > > > > > > > /usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/frameworks/royale-config.xml > > > > > (line: 74) > > > > > > > > > > > > > > > </external-library-path> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > /usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/frameworks/royale-config.xml(129): > > > > > col: 0 Error: unable to open > > > > > > > > > > > > > > > > > > > > '/usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/frameworks/libs/player/11.1'. > > > > > > > > > > > > > > > > > > > > > > > > > /usr/local/lib/node_modules/@apache-royale/royale-js-swf/royale-asjs/frameworks/royale-config.xml > > > > > (line: 129) > > > > > > > > > > > > > > > </library-path> > > > > > > > > > > > > > > > > > > > > 0.68472554 seconds > > > > > > > > > > macbookpro:~ carlosrovira$ > > > > > > > > > > > > > > > > > > > > > > > > > Hope results are the expected ones :) > > > > > > > > > > > > > > > Best > > > > > > > > > > > > > > > Carlos > > > > > > > > > > El jue., 12 sept. 2019 a las 18:46, Alex Harui > > > > > (<aha...@adobe.com.invalid>) > > > > > escribió: > > > > > > > > > > > Thanks for catching the places where FlexJS was still > being > > > > used. > > > > > > > > > > > > Your output indicates that there is a ROYALE_HOME > > environment > > > > > variable so > > > > > > it appears to be using your dev versions since I don't > > think > > > > NPM > > > > > would > > > > > > store its stuff in /Users/carlosrovira/Dev. Anyway, good > > to > > > > > know that the > > > > > > environment variable can re-direct what the npm scripts > do. > > > If > > > > > you want to > > > > > > try without an environment variable that would be a > better > > > test > > > > > of what new > > > > > > users would experience and the output should reference > the > > > npm > > > > > node_modules > > > > > > folder. > > > > > > > > > > > > Thanks, > > > > > > -Alex > > > > > > > > > > > > On 9/12/19, 1:53 AM, "Carlos Rovira" < > > > carlosrov...@apache.org> > > > > > wrote: > > > > > > > > > > > > Hi, > > > > > > > > > > > > think al went fine :) > > > > > > > > > > > > this is my output: > > > > > > > > > > > > > > > > > > + @apache-royale/royale-js-swf@0.9.6-beta9 > > > > > > > > > > > > added 146 packages from 108 contributors in 426.831s > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > then I tried "mxmlc" just from command line: > > > > > > > > > > > > > > > > > > macbookpro:~ carlosrovira$ mxmlc > > > > > > > > > > > > Using Royale Compiler codebase: > > > > > > /Users/carlosrovira/Dev/Royale/Source/royale-compiler > > > > > > > > > > > > Using Royale SDK: > > > > > /Users/carlosrovira/Dev/Royale/Source/royale-asjs > > > > > > > > > > > > MXMLJSC > > > > > > > > > > > > > > > > > > > > +royalelib=/Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -sdk-js-lib=/Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/js/Royale/generated-sources > > > > > > > > > > > > Loading configuration: > > > > > > > > > > > > > > > > > > > > > > > > > > > /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/royale-config.xml > > > > > > > > > > > > > > > > > > Error: a target file must be specified. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Error: a target file must be specified. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > 0.888219402 seconds > > > > > > > > > > > > macbookpro:~ carlosrovira$ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Carlos Rovira > > > > > > > > > > > > > > > > > > > > > > > > > > > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C1c4ad6d04e534ee4bbc908d737aa8c2c%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637039078002016836&sdata=aa8EapVqmDC2iu7nmWBh20akTley4HB5QhCUK5U%2B1IE%3D&reserved=0 > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > Carlos Rovira > > > > > > > > > > > > > > > > > > > > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C1c4ad6d04e534ee4bbc908d737aa8c2c%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637039078002026826&sdata=LpDM5%2BmgtTtSoRgRYPSk7kgh8KrcBQTrn6ZZte7YQYU%3D&reserved=0 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > Piotr Zarzycki > > > > Patreon: *https://www.patreon.com/piotrzarzycki > > <https://www.patreon.com/piotrzarzycki>* > > > > > -- > Carlos Rovira > http://about.me/carlosrovira >
