I'd rather not accidentally commit something to a release branch that shouldn't go there, so to stay safe, I'll keep committing to develop first. We can always cherry pick if needed.
-- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Tue, Sep 17, 2019 at 2:29 PM Alex Harui <aha...@adobe.com.invalid> wrote: > Hmm. I thought I'd fixed that. I swear I had all examples building. > > Anyway, fixes like these should be going in the release branch, not > develop, IMO. > > Thanks, > -Alex > > On 9/17/19, 2:22 PM, "Josh Tynjala" <joshtynj...@bowlerhat.dev> wrote: > > Getting the following error when running the ApproveRoyale ant > script... > > Error: unable to open > > '/Users/joshtynjala/Desktop/royale/apache-royale-0.9.6-src/royale-asjs/examples/royale/CreditCardValidatorExample/src/main/royale/App.mxml'. > > Seems to be caused by this line in build.xml from > CreditCardValidatorExample: > > <property name="example" value="App" /> > > There is no App.mxml, but there is a CreditCardValidatorExample.mxml, > so I > think that the value is supposed to be "CreditCardValidatorExample" > instead: > > <property name="example" value="CreditCardValidatorExample" /> > > I just pushed a commit to develop to fix that for the next release. > > I will locally adjust ApproveRoyale to skip the examples and finish the > rest of the approval process. Assuming that everything else completes > successfully, a broken example build script is not enough to prevent me > from approving this release candidate. > > -- > Josh Tynjala > Bowler Hat LLC < > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.dev&data=02%7C01%7Caharui%40adobe.com%7C3a8e9e313e9744a4706a08d73bb525db%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637043521555610433&sdata=z%2BrnbF8mRz%2Bh%2Fe54Ta9HaAvaqh2rLiMVQPpcx0VPRUc%3D&reserved=0 > > > > > On Tue, Sep 17, 2019 at 6:43 AM Apache Royale CI Server < > apacheroyal...@gmail.com> wrote: > > > This is the discussion thread. > > > > Thanks, > > Piotr > > >
