We can either use: updateView() which wraps if(parent)drawImpl() or we can write if(parent)drawImpl() in every case.
The former will have less code compiled in the application, but will have an extra function call. Which one is more PAYG? Dunno. I tend to err on the side of less code. If you feel strongly that the second way is better, I’ll be happy to change the code. Harbs > On Sep 24, 2019, at 7:11 PM, Alex Harui <[email protected]> wrote: > > This also seems not PAYG? > > -Alex > > On 9/24/19, 12:29 AM, "[email protected] <mailto:[email protected]>" > <[email protected] <mailto:[email protected]>> wrote: > > This is an automated email from the ASF dual-hosted git repository. > > harbs pushed a commit to branch develop > in repository > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&data=02%7C01%7Caharui%40adobe.com%7Cb9b02ca0486e4843e38408d740c0f2bb%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637049069761027720&sdata=Lllwp6tEywI0Mx3hSCTM79s3%2BcilRhjJuYWlMsOK0L8%3D&reserved=0 > > <https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&data=02%7C01%7Caharui%40adobe.com%7Cb9b02ca0486e4843e38408d740c0f2bb%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637049069761027720&sdata=Lllwp6tEywI0Mx3hSCTM79s3%2BcilRhjJuYWlMsOK0L8%3D&reserved=0> > > > The following commit(s) were added to refs/heads/develop by this push: > new b054a0a Make values bindable > b054a0a is described below > > commit b054a0a6e3a6131a9cf78b3e0358a2dc08d34bcf > Author: Harbs <[email protected] <mailto:[email protected]>> > AuthorDate: Tue Sep 24 10:29:22 2019 +0300 > > Make values bindable > --- > .../projects/Basic/src/main/royale/org/apache/royale/svg/Circle.as | 1 > + > .../projects/Basic/src/main/royale/org/apache/royale/svg/Ellipse.as | 4 > ++++ > .../projects/Basic/src/main/royale/org/apache/royale/svg/Path.as | 2 > ++ > .../projects/Basic/src/main/royale/org/apache/royale/svg/Rect.as | 2 > ++ > .../projects/Basic/src/main/royale/org/apache/royale/svg/Text.as | 1 > + > 5 files changed, 10 insertions(+) > > diff --git > a/frameworks/projects/Basic/src/main/royale/org/apache/royale/svg/Circle.as > b/frameworks/projects/Basic/src/main/royale/org/apache/royale/svg/Circle.as > index f78fada..84984cb 100644 > --- > a/frameworks/projects/Basic/src/main/royale/org/apache/royale/svg/Circle.as > +++ > b/frameworks/projects/Basic/src/main/royale/org/apache/royale/svg/Circle.as > @@ -60,6 +60,7 @@ package org.apache.royale.svg > public function set radius(value:Number):void > { > _radius = value; > + updateView(); > } > > COMPILE::JS > diff --git > a/frameworks/projects/Basic/src/main/royale/org/apache/royale/svg/Ellipse.as > b/frameworks/projects/Basic/src/main/royale/org/apache/royale/svg/Ellipse.as > index 8c7e63a..ce17633 100644 > --- > a/frameworks/projects/Basic/src/main/royale/org/apache/royale/svg/Ellipse.as > +++ > b/frameworks/projects/Basic/src/main/royale/org/apache/royale/svg/Ellipse.as > @@ -68,6 +68,7 @@ package org.apache.royale.svg > public function set rx(value:Number):void > { > _rx = value; > + updateView(); > } > > private var _ry:Number; > @@ -88,6 +89,7 @@ package org.apache.royale.svg > public function set ry(value:Number):void > { > _ry = value; > + updateView(); > } > > override public function get width():Number > @@ -98,6 +100,7 @@ package org.apache.royale.svg > override public function set width(value:Number):void > { > _rx = value/2; > + updateView(); > } > > override public function get height():Number > @@ -108,6 +111,7 @@ package org.apache.royale.svg > override public function set height(value:Number):void > { > _ry = value/2; > + updateView(); > } > > COMPILE::JS > diff --git > a/frameworks/projects/Basic/src/main/royale/org/apache/royale/svg/Path.as > b/frameworks/projects/Basic/src/main/royale/org/apache/royale/svg/Path.as > index d6f90ea..90a2c8e 100644 > --- > a/frameworks/projects/Basic/src/main/royale/org/apache/royale/svg/Path.as > +++ > b/frameworks/projects/Basic/src/main/royale/org/apache/royale/svg/Path.as > @@ -50,6 +50,7 @@ package org.apache.royale.svg > { > _data = value; > _pathCommands = null; > + updateView(); > } > > private var _pathCommands:PathBuilder; > @@ -63,6 +64,7 @@ package org.apache.royale.svg > { > _pathCommands = value; > _data = _pathCommands.getPathString(); > + updateView(); > } > > > diff --git > a/frameworks/projects/Basic/src/main/royale/org/apache/royale/svg/Rect.as > b/frameworks/projects/Basic/src/main/royale/org/apache/royale/svg/Rect.as > index 8e0c612..15bf4a1 100644 > --- > a/frameworks/projects/Basic/src/main/royale/org/apache/royale/svg/Rect.as > +++ > b/frameworks/projects/Basic/src/main/royale/org/apache/royale/svg/Rect.as > @@ -74,6 +74,7 @@ package org.apache.royale.svg > public function set rx(value:Number):void > { > _rx = value; > + updateView(); > } > > private var _ry:Number; > @@ -95,6 +96,7 @@ package org.apache.royale.svg > public function set ry(value:Number):void > { > _ry = value; > + updateView(); > } > > /** > diff --git > a/frameworks/projects/Basic/src/main/royale/org/apache/royale/svg/Text.as > b/frameworks/projects/Basic/src/main/royale/org/apache/royale/svg/Text.as > index ca5f613..4722c95 100644 > --- > a/frameworks/projects/Basic/src/main/royale/org/apache/royale/svg/Text.as > +++ > b/frameworks/projects/Basic/src/main/royale/org/apache/royale/svg/Text.as > @@ -73,6 +73,7 @@ package org.apache.royale.svg > public function set text(value:String):void > { > _text = value; > + updateView(); > } > > COMPILE::SWF
