FWIW, I tried “as Event” and it failed. I don’t know why.

> On Dec 21, 2019, at 6:45 PM, Harbs <[email protected]> wrote:
> 
> This is wrong.
> 
> The argument is a Browser Event — not a goog.events.Event.
> 
> I don’t know why Maven is failing, but this is not the right fix.
> 
>> On Dec 20, 2019, at 3:47 PM, [email protected] wrote:
>> 
>> This is an automated email from the ASF dual-hosted git repository.
>> 
>> yishayw pushed a commit to branch EventConverter
>> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>> 
>> 
>> The following commit(s) were added to refs/heads/EventConverter by this push:
>>    new eac8f74  Also, mx needs to change
>> eac8f74 is described below
>> 
>> commit eac8f745f11c9687876255c66ba8a8d583268b60
>> Author: DESKTOP-RH4S838\Yishay <[email protected]>
>> AuthorDate: Fri Dec 20 15:46:50 2019 +0200
>> 
>>   Also, mx needs to change
>> ---
>> .../MXRoyale/src/main/royale/mx/events/utils/KeyboardEventConverter.as | 2 +-
>> .../MXRoyale/src/main/royale/mx/events/utils/MouseEventConverter.as    | 3 
>> ++-
>> 2 files changed, 3 insertions(+), 2 deletions(-)
>> 
>> diff --git 
>> a/frameworks/projects/MXRoyale/src/main/royale/mx/events/utils/KeyboardEventConverter.as
>>  
>> b/frameworks/projects/MXRoyale/src/main/royale/mx/events/utils/KeyboardEventConverter.as
>> index 533322b..0167670 100644
>> --- 
>> a/frameworks/projects/MXRoyale/src/main/royale/mx/events/utils/KeyboardEventConverter.as
>> +++ 
>> b/frameworks/projects/MXRoyale/src/main/royale/mx/events/utils/KeyboardEventConverter.as
>> @@ -95,7 +95,7 @@ package mx.events.utils
>>                      var newEvent:KeyboardEvent = new KeyboardEvent(type, 
>> key, code, nativeEvent["shiftKey"]);
>>                      if(!browserEvent)
>>                      {
>> -                            browserEvent = new 
>> goog.events.BrowserEvent(nativeEvent,nativeEvent["currentTarget"]);
>> +                            browserEvent = new 
>> goog.events.BrowserEvent(nativeEvent as 
>> goog.events.Event,nativeEvent["currentTarget"]);
>>                      }
>>                      newEvent.wrapEvent(browserEvent);
>>                      return newEvent;
>> diff --git 
>> a/frameworks/projects/MXRoyale/src/main/royale/mx/events/utils/MouseEventConverter.as
>>  
>> b/frameworks/projects/MXRoyale/src/main/royale/mx/events/utils/MouseEventConverter.as
>> index 5a22034..9b783a3 100644
>> --- 
>> a/frameworks/projects/MXRoyale/src/main/royale/mx/events/utils/MouseEventConverter.as
>> +++ 
>> b/frameworks/projects/MXRoyale/src/main/royale/mx/events/utils/MouseEventConverter.as
>> @@ -27,6 +27,7 @@ package mx.events.utils
>>    COMPILE::JS
>>    {
>>        import goog.events.BrowserEvent;
>> +        import goog.events.Event;
>>    }
>> 
>>    import mx.core.Keyboard;
>> @@ -193,7 +194,7 @@ package mx.events.utils
>>            var event:mx.events.MouseEvent = new 
>> mx.events.MouseEvent(nativeEvent["type"], nativeEvent["bubbles"], 
>> nativeEvent["cancelable"]);
>>                      if(!browserEvent)
>>                      {
>> -                            browserEvent = new 
>> goog.events.BrowserEvent(nativeEvent,nativeEvent["currentTarget"]);
>> +                            browserEvent = new 
>> goog.events.BrowserEvent(nativeEvent as 
>> goog.events.Event,nativeEvent["currentTarget"]);
>>                      }
>>            event.wrapEvent(browserEvent);
>>            return event;
>> 
> 

Reply via email to