Hi Piotr, great to hear that :) additionally I had confirmation from Josh that distribution SDK was as well working for him. So I think we got it :)
El jue., 23 ene. 2020 a las 16:28, Piotr Zarzycki (< piotrzarzyck...@gmail.com>) escribió: > Maven build for our application back to normal and I was able to produce > release/debug files. > > śr., 22 sty 2020 o 16:05 Piotr Zarzycki <piotrzarzyck...@gmail.com> > napisał(a): > > > Build is in progress. Once it's finish I will check -> > > https://builds.apache.org/job/Royale-compiler/1257/ > > > > śr., 22 sty 2020 o 15:54 Carlos Rovira <carlosrov...@apache.org> > > napisał(a): > > > >> Hi Piotr, > >> latest commit seems to fix the problem. Let me know if all is now ok > >> sorry for the inconvenience > >> Carlos > >> > >> El mié., 22 ene. 2020 a las 13:51, Carlos Rovira (< > >> carlosrov...@apache.org>) > >> escribió: > >> > >> > Hi Piotr, > >> > > >> > I can see the problem is related to my latest commit in compiler to > >> solve > >> > the GOOG_HOME problem. > >> > going to fix it > >> > > >> > El mié., 22 ene. 2020 a las 13:31, Carlos Rovira (< > >> carlosrov...@apache.org>) > >> > escribió: > >> > > >> >> Hi Piotr, > >> >> > >> >> ok, now I understand... It's clear that I broke something since > trying > >> to > >> >> build now with Maven is generating the same issue ;) > >> >> I was focused on making build works for IDEs, that didn't test normal > >> >> maven path yesterday. > >> >> I'll be looking over it to find where is the problem > >> >> Sorry for the confusion! :) > >> >> > >> >> El mié., 22 ene. 2020 a las 13:27, Carlos Rovira (< > >> >> carlosrov...@apache.org>) escribió: > >> >> > >> >>> Hi Piotr, > >> >>> > >> >>> before understand the mistake, I downloaded and tested SDK from > >> Jenkins > >> >>> (build #2552 that was the latest created) and build TDJ with VSCode > >> and all > >> >>> worked ok (the same output as with Maven distribution created > locally) > >> >>> Don't know if that report can be of help for you. > >> >>> > >> >>> > >> >>> > >> >>> El mié., 22 ene. 2020 a las 13:22, Piotr Zarzycki (< > >> >>> piotrzarzyck...@gmail.com>) escribió: > >> >>> > >> >>>> Exactly we are not discussion any stuff related to distribution :) > We > >> >>>> are > >> >>>> discussion at some point that maybe for some reason your changes > >> >>>> influence > >> >>>> somehow compiler or anything else which end up with above error. > >> Maybe > >> >>>> that > >> >>>> closure upgrade - I don't know. I look forward to hear more from > >> someone > >> >>>> what could know the reason of my issue. > >> >>>> > >> >>>> śr., 22 sty 2020 o 13:16 Carlos Rovira <carlosrov...@apache.org> > >> >>>> napisał(a): > >> >>>> > >> >>>> > Hi Piotr, > >> >>>> > > >> >>>> > El mié., 22 ene. 2020 a las 13:00, Piotr Zarzycki (< > >> >>>> > piotrzarzyck...@gmail.com>) escribió: > >> >>>> > > >> >>>> > > > >> >>>> > > > >> >>>> > > Nope. Let's pretend that you have clean PC. You have downloaded > >> your > >> >>>> > Royale > >> >>>> > > application which contains pom.xml - You do "mvn clean > install" - > >> >>>> All the > >> >>>> > > dependencies will be downloaded from Apache Maven Central > >> >>>> repository - > >> >>>> > > which is being updated by every build -> > >> >>>> > > https://builds.apache.org/job/Royale-asjs/ - Do you understand > >> now > >> >>>> what > >> >>>> > > I'm > >> >>>> > > using now ? > >> >>>> > > > >> >>>> > > > >> >>>> > Ok, but in that case, you are not trying "distribution".... so > >> really > >> >>>> don't > >> >>>> > understand. > >> >>>> > I though we were discussing the new fixed distribution that > >> creates a > >> >>>> SDK > >> >>>> > in target folder or in the folder you specify (if use > >> >>>> > -DdistributionTargetFolder var) > >> >>>> > IOW, ant and maven continue to do the same as before, since > >> there's no > >> >>>> > changes out side of distribution (just class paths set ups for > >> maven > >> >>>> > generated artifacts that until now was empty or pointing to not > >> >>>> existing > >> >>>> > resources) > >> >>>> > > >> >>>> > > >> >>>> > > No I don't have to and I shouldn't have to - I'm using > artifacts > >> >>>> from > >> >>>> > > Apache Maven Central. > >> >>>> > > > >> >>>> > > > >> >>>> > In that case you're not testing distribution. Jenkins builds the > >> same > >> >>>> as > >> >>>> > always. Other case will be if we can change Jenkins to build with > >> >>>> > distribution and then provide that SDK to download, that will be > >> the > >> >>>> proper > >> >>>> > way, and what the rest of projects using maven does in fact. > >> >>>> > > >> >>>> > > >> >>>> > > >> >>>> > > >> >>>> > > -- > >> >>>> > > Carlos Rovira > >> >>>> > > http://about.me/carlosrovira > >> >>>> > > > >> >>>> > > > >> >>>> > > > >> >>>> > > > >> >>>> > > >> >>>> > >> >>>> > >> >>>> -- > >> >>>> > >> >>>> Piotr Zarzycki > >> >>>> > >> >>>> Patreon: *https://www.patreon.com/piotrzarzycki > >> >>>> <https://www.patreon.com/piotrzarzycki>* > >> >>>> > >> >>> > >> >>> > >> >>> -- > >> >>> Carlos Rovira > >> >>> http://about.me/carlosrovira > >> >>> > >> >>> > >> >> > >> >> -- > >> >> Carlos Rovira > >> >> http://about.me/carlosrovira > >> >> > >> >> > >> > > >> > -- > >> > Carlos Rovira > >> > http://about.me/carlosrovira > >> > > >> > > >> > >> -- > >> Carlos Rovira > >> http://about.me/carlosrovira > >> > > > > > > -- > > > > Piotr Zarzycki > > > > Patreon: *https://www.patreon.com/piotrzarzycki > > <https://www.patreon.com/piotrzarzycki>* > > > > > -- > > Piotr Zarzycki > > Patreon: *https://www.patreon.com/piotrzarzycki > <https://www.patreon.com/piotrzarzycki>* > -- Carlos Rovira http://about.me/carlosrovira
