Awesome Greg!, I think this fix is very important for stability. I expect even for release related things could be a key point. Thanks! :)
El lun., 10 feb. 2020 a las 7:31, Greg Dove (<[email protected]>) escribió: > Hi Piotr, > > FYI Carlos fixed that missing import. > The other issue was not related to Crux. It is a memory leak in the > compiler that happened over multiple compilations. It occurs with the Crux > example by coincidence because more examples were added recently and the > leak builds up over the build sequence. > > A few of us were able to repro that locally and Chris Dutz had already > brought it to Carlos' attention, and Carlos had mentioned that to me and > filed an issue. > > I tried to find it last week with Java Flight Recorder, but did not have > much luck. I tried today with an evaluation copy of JProfiler and found the > main source quick quickly (wish I had tried that sooner). I see that > JProfiler is supporting at least one other Apache project, maybe we could > consider asking for open-source licences for that. > > The main leak is related to bindings, so was not really happening in the > framework build but was in the examples (with mxml and bindings). After the > change I can now I can get the same build running with lower memory limits > than those in the jenkins build. The examples builds also seem to run a lot > faster now. I could see that building locally, but the CI build is probably > at least 20 mins faster now it seems. (1.15 instead of 1.35 typical in the > past). > > > > On Sun, Feb 9, 2020 at 2:26 AM Piotr Zarzycki <[email protected]> > wrote: > > > Hi Carlos, > > > > You have probably missed some imports [1]. Apart of that build constantly > > failing on Crux example [2] > > > > [1] https://builds.apache.org/job/Royale-asjs/2634/ > > [2] https://builds.apache.org/job/Royale-asjs/2631/console > > > > Thanks, > > Piotr > > > > sob., 8 lut 2020 o 14:10 Apache Jenkins Server < > [email protected]> > > napisał(a): > > > > > The Apache Jenkins build system has built Royale-asjs (build #2634) > > > > > > Status: Still Failing > > > > > > Check console output at > https://builds.apache.org/job/Royale-asjs/2634/ > > > to view the results. > > > > > > > > -- > > > > Piotr Zarzycki > > > > Patreon: *https://www.patreon.com/piotrzarzycki > > <https://www.patreon.com/piotrzarzycki>* > > > -- Carlos Rovira http://about.me/carlosrovira
