ok Alex sounds good. Feel free to change what I did to better fit the new standards.
about selection and hover at runtime. Most of the times I expect users want hover/select, or just hover or nothing at all. I think it could be some case when a user wants to deactivate something at runtime, and hope a user can create it if needed some day. I think I had that need in flex at some point, but will be a rare case (hopefully). Thanks El jue., 20 feb. 2020 a las 20:11, Alex Harui (<[email protected]>) escribió: > There shouldn’t be a need for a SimpleListItemRenderer. Ideally, as I > tried to explain below, we would no longer bake in the > ClassSelectorListRuntime.. bead into Jewel’s ListItemRenderer. The choice > of factories and initializers will take care of it. > > > > Every time we create a new class with different baked in behavior it is an > example if “is” more than “has”. So now that you’ve confirmed that > selection is optional and never changed at runtime, I will make the > adjustments and eliminate SimpleLIstItemRenderer. IMO, Jewel should use > the “has” patterns that the rest of Royale is using. > > > > -Alex > > > > *From: *Carlos Rovira <[email protected]> > *Date: *Thursday, February 20, 2020 at 10:58 AM > *To: *Apache Royale Development <[email protected]> > *Cc: *"[email protected]" <[email protected]> > *Subject: *Re: [royale-asjs] branch develop updated: todomvc-examples: > fix compilation, but now renderers show hover/selected states > > > > Hi Alex, > > > > just fixed it, but I read this now. Maybe a solution is between both. I > think: > > > > · Jewel should has List configured by default to use a IR class > factory that allows hover/select, since is the most usual. > > · Todo, should change List bead to a class factory that does not > allow hover/select. > > I think this is right to this point. > > > > Now about the renderer itself: I added a new SimpleListItemRenderer that > does not add "ClassSelectorListRuntimeSelectableItemRendererBead", That's > the one to use in Todo example. In TDJ for normal Lists use habitual > ListItemRenderer. Does that make sense? > > > > > > > > El jue., 20 feb. 2020 a las 19:25, Alex Harui (<[email protected]>) > escribió: > > These examples weren't in the list of examples on the Ant build so I > missed them before I pushed. > > What is the purpose of the "hoverable" and "selectable" APIs in Jewel? > The APIs are in the IRuntimeSelectableItemRenderer interface to support > runtime disabling of selection visuals, but the Jewel examples appear to > never change those values, so for PAYG reasons, it would be better to > follow the "has" pattern in the other component sets. > > The default IItemRendererClassFactory for that Lists in other component > sets is set to SelectableItemRendererClassFactory, which adds a Selection > visuals bead to each ItemRenderer. > If the desire is to never have selection visuals for a List/Table, then > that component should use ItemRendererClassFactory instead of > SelectableItemRendererClassFactory and it won't add a Selection visuals > bead to each renderer, and you don't have to carry around code like the > hoverable/selectable APIs to turn off selection visuals. > > The defaults.css for Jewel should be using ItemRendererClassFactory in > places where Selection was being turned off with the old > hoverable/selectable > > That is a good example of how "has" and composition is more PAYG than > baking in default behavior and turning it off. > > If that's the purpose of hoverable/selectable in Jewel, then Jewel's > ListItemRenderer we should remove the automatic adding of the > ClassSelectorListRuntimeSelectable bead and update the CSS accordingly. > > I have time to make those changes now that I have my Maven working copy > building. > > Let me know, > -Alex > > On 2/20/20, 10:00 AM, "[email protected]" <[email protected]> > wrote: > > This is an automated email from the ASF dual-hosted git repository. > > carlosrovira pushed a commit to branch develop > in repository > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&data=02%7C01%7Caharui%40adobe.com%7C015846e7679a404652a208d7b62ebec4%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637178184199117053&sdata=PiKV0LSKu3fT2laVPdNJJDViLIVoWSiY743QPsdUAbA%3D&reserved=0 > <https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&data=02%7C01%7Caharui%40adobe.com%7C6aa06c87c5c2428770a208d7b636d9ee%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637178219014987434&sdata=OqT2BkAQIuL7afh4fEp3gQDfyfGt0wGGfGlrpSjmy3Y%3D&reserved=0> > > > The following commit(s) were added to refs/heads/develop by this push: > new 0a5fe59 todomvc-examples: fix compilation, but now renderers > show hover/selected states > 0a5fe59 is described below > > commit 0a5fe59d140c7db5dbb6218b5fcc2ea3ba248449 > Author: Carlos Rovira <[email protected]> > AuthorDate: Thu Feb 20 19:00:04 2020 +0100 > > todomvc-examples: fix compilation, but now renderers show > hover/selected states > --- > .../src/main/royale/jewel/todomvc/renderers/TodoItemRenderer.mxml > | 4 ++-- > .../src/main/royale/jewel/todomvc/renderers/TodoItemRenderer.mxml > | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git > a/examples/crux/todomvc-jewel-crux/src/main/royale/jewel/todomvc/renderers/TodoItemRenderer.mxml > b/examples/crux/todomvc-jewel-crux/src/main/royale/jewel/todomvc/renderers/TodoItemRenderer.mxml > index 89e3934..596ae88 100644 > --- > a/examples/crux/todomvc-jewel-crux/src/main/royale/jewel/todomvc/renderers/TodoItemRenderer.mxml > +++ > b/examples/crux/todomvc-jewel-crux/src/main/royale/jewel/todomvc/renderers/TodoItemRenderer.mxml > @@ -20,9 +20,9 @@ limitations under the License. > <j:ListItemRenderer xmlns:fx=" > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fns.adobe.com%2Fmxml%2F2009&data=02%7C01%7Caharui%40adobe.com%7C015846e7679a404652a208d7b62ebec4%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637178184199117053&sdata=j7eSC%2FU9lWMwkLAtHyZ8hjzJdBNVALq6k6AYUYKzo0A%3D&reserved=0 > <https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fns.adobe.com%2Fmxml%2F2009&data=02%7C01%7Caharui%40adobe.com%7C6aa06c87c5c2428770a208d7b636d9ee%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637178219014997433&sdata=m888zfrUezhBaXyJ61vmnS4HSqRkFmDwhuIZliQtydw%3D&reserved=0>" > > xmlns:j="library://ns.apache.org/royale/jewel > <https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fns.apache.org%2Froyale%2Fjewel&data=02%7C01%7Caharui%40adobe.com%7C6aa06c87c5c2428770a208d7b636d9ee%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637178219014997433&sdata=LtfquAUkEJOHq%2FmrQHxZc2e7eaG7Inx8uYfO7VqEotw%3D&reserved=0>" > > xmlns:js="library://ns.apache.org/royale/basic > <https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fns.apache.org%2Froyale%2Fbasic&data=02%7C01%7Caharui%40adobe.com%7C6aa06c87c5c2428770a208d7b636d9ee%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637178219015007424&sdata=U3sf0bPYjRuefFkHURuyUbkq4GRoG19R0DhufHnpXCU%3D&reserved=0> > " > - hoverable="false" selectable="false" width="100%" > rollOver="rollOverHandler(event)" > - rollOut="rollOutHandler(event)"> > + rollOut="rollOutHandler(event)" > + width="100%"> > > <fx:Script> > <