Re: Check on Proxy method alignment.

[Alex Harui]

OK with me.  I didn't realize that 'delete' returned a value.

On 2/26/20, 1:53 PM, "Greg Dove" <greg.d...@gmail.com> wrote:

    Quick check, does anyone have objections to aligning the Proxy
    deleteProperty method signature with swf?
    
    It should be:
    Returns
    Boolean
    
<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fhelp.adobe.com%2Fen_US%2FFlashPlatform%2Freference%2Factionscript%2F3%2FBoolean.html&amp;data=02%7C01%7Caharui%40adobe.com%7C87c8cdbde1054e11a8ff08d7bb065431%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637183508178279239&amp;sdata=O1XnoZuG6wT8Wsk54BxvjjlOIwivM0w3INfsf%2FGWLn4%3D&amp;reserved=0>
    —
    If the property was deleted, true; otherwise false.
    At the moment it is :void in js and (as expected) returns Boolean as above
    in swf.
    
    I hit this in some porting code recently and I'd like to address it.
    The change would simply be to do the following:
    
    public function deleteProperty(propName:String):Boolean
    {
       return delete valueMap[propName];
    }
    
    Which essentially makes it the same as swf (but in public namespace instead
    of flash_proxy). It only needs a few small changes in the subclasses in
    MXRoyale for JS to match.
    
    Any issues with me making that change? (I don't expect there should be)