If I understood that correctly, that's what I would expect, so I don't know why it would matter if the value was undefined or initialized to NaN. And thus, I'm not sure why the code went in the wrong direction.
On 3/26/20, 9:45 AM, "Yishay Weiss" <[email protected]> wrote: isNaN(undefined) is actually true, same as isNaN(NaN). From: Yishay Weiss<mailto:[email protected]> Sent: Thursday, March 26, 2020 6:27 PM To: [email protected]<mailto:[email protected]> Subject: RE: Numbers not initialized to NaN Ok, I’ll investigate why it’s undefined. > isNaN(percentHeight) is thus evaluated I meant !isNaN Thanks. From: Josh Tynjala<mailto:[email protected]> Sent: Thursday, March 26, 2020 6:23 PM To: Apache Royale Development<mailto:[email protected]> Subject: Re: Numbers not initialized to NaN Numbers should be initialized to NaN, unless you've added -js-default-initializers=false to your compiler options. -- Josh Tynjala Bowler Hat LLC <https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.dev&data=02%7C01%7Caharui%40adobe.com%7C6705428a9191455871d808d7d1a50d9b%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637208379135450031&sdata=xcmYsmsK2XvjI8R2c8lZn36u5Y4ksvUci7392Co1IqU%3D&reserved=0> On Thu, Mar 26, 2020 at 9:17 AM Yishay Weiss <[email protected]> wrote: > I think this might have come up in one of my previous posts so my > apologies if I’m repeating a question. In Flex.as we have the following > code: > > if (!isNaN(percentHeight) > && child.includeInLayout) > { > height = > Math.max(child.minHeight, > > Math.min(child.maxHeight, > > ((percentHeight >= 100) ? h : h * percentHeight / 100))); > } > > percentHeight, which is a Number, seems to be initialized to undefined. > isNaN(percentHeight) is thus evaluated to true which results in the wrong > height being set. > > Should I change the code to check for undefined instead of NaN, or should > the compiler initialized to NaN? >
