Hi Piotr,

latest changes in Jewel make rowHeight set "minHeight" instead of "height".
This makes variableRowHeight work as expected even if rowHeight is set up.
Still just a previous step that must be done.


El vie., 10 abr. 2020 a las 17:35, Carlos Rovira (<[email protected]>)
escribió:

>  Hi Piotr,
>
> I was taking a look at the issue. Some initial thoughts:
>
> List has "variableRowHeight: true" (defined in Theme) and rowHeight = NaN;
> by default
> (as we can see in first List example in TDJ. We can have different heights
> for each item renderer, while second example has rowHeight defined and that
> makes all items has the same height (Side note: Here there's a bug since
> defining rowHeight should remove "variableRowHeight", since both should be
> mutually exclusive).
>
> In DataGrid, we have lots of Lists becoming columns. So to make DG work as
> List I think we need to sync all rows to match the bigger height per
> renderer in all lists.
>
> I think there's no other way to do this.
>
> If not, other options is to avoid DG have "variableRowHeight" and force
> people to use "rowHeight".
>
> I don't remember what Flex allow to do here, but maybe is something to
> discuss a bit to see what could be the best for Royale Jewel DataGrid.
>
> Thanks
>
> Carlos
>
>
>
>
> El vie., 10 abr. 2020 a las 15:45, Piotr Zarzycki (<
> [email protected]>) escribió:
>
>> Hi Carlos,
>>
>> We have switched in our application to DataGrid. There are unfortunately
>> some custom adjustment to have it properly working, but we can move
>> forward
>> with that.
>> However I have found something which I believe should be fixed sooner than
>> later.
>>
>> When rowHeight is not set and there are different amount of data in data
>> grid cells rows are being cut and data are not displaying fully. I have
>> pushed to TourDeJewel example which shows the issue.
>>
>> Thanks,
>> --
>>
>> Piotr Zarzycki
>>
>> Patreon: *https://www.patreon.com/piotrzarzycki
>> <https://www.patreon.com/piotrzarzycki>*
>>
>
>
> --
> Carlos Rovira
> http://about.me/carlosrovira
>
>

-- 
Carlos Rovira
http://about.me/carlosrovira

Reply via email to