Hi Chris, I was indeed comparing the wrong jars. After looking at the ant script I can see that what needs to be compared is between jars downloaded from the archive [1] and the binaries build a second time from src [2]
The ant script fails with a message if the binaries don’t match, but does not echo a confirmation that they do match, other than that build was successful. I guess the email was a bit misleading in making me think there was a manual step involved. FWIW, the script does not compare javadocs.jar from what I could tell, but I’ll have a look at your PR as soon as I’ve got time. Thanks! [1] C:\temp7\artifacts\archive\ [2] C:\temp7\sources\target From: Christofer Dutz<mailto:[email protected]> Sent: Monday, April 13, 2020 2:55 PM To: [email protected]<mailto:[email protected]> Subject: Re: Royale Compiler Build Tools Release Step 002 Succeeded Hi Yishay, ok ... we never talked about comparing the JavaDocs ... just the binary artifacts. I updated the maven-javadoc-plugin to 3.2.0 which is the first reproducible version. Please feel free to merge the PRs (I also disabled the Javadoc in the typedefs as this doesn't make any sense there) Chris Am 13.04.20, 12:46 schrieb "Yishay Weiss" <[email protected]>: >2. Validate that the compiled artifacts match the downloaded artifacts. What does this mean? Looks to me like the jars are different [1]. I’ll see if I understand why. [1] C:\temp1>git diff C:\temp1\artifacts\archive\compiler-build-tools\target\local-release-dir\org\apache\royale\compiler\compiler-build-tools\1.2.0\compiler-build-tools-1.2.0-javadoc.jar C:\jenkins\workspace\Royale_Compiler_Build_Tools_Release_Step_001\compiler-build-tools\target\compiler-build-tools-1.2.0-javadoc.jar diff --git "a/C:\\temp1\\artifacts\\archive\\compiler-build-tools\\target\\local-release-dir\\org\\apache\\royale\\compiler\\compiler-build-tools\\1.2.0\\compiler-build-tools-1.2.0-javadoc.jar" "b/C:\\jenkins\\workspace\\Royale_Compiler_Build_Tools_Release_Step_001\\compiler-build-tools\\target\\compiler-build-tools-1.2.0-javadoc.jar" index 994c837..9010c33 100644 Binary files "a/C:\\temp1\\artifacts\\archive\\compiler-build-tools\\target\\local-release-dir\\org\\apache\\royale\\compiler\\compiler-build-tools\\1.2.0\\compiler-build-tools-1.2.0-javadoc.jar" and "b/C:\\jenkins\\workspace\\Royale_Compiler_Build_Tools_Release_Step_001\\compiler-build-tools\\target\\compiler-build-tools-1.2.0-javadoc.jar" differ
