That's interesting Brian, thanks for sharing that.

I have been working on a fix for inherited bindings, which is something
that has never worked but which I needed to work (I now have that working
locally and expect to get that in today). I am not exactly sure why what
your saw was happening, but I have made another change locally which could
theoretically reduce the possibility of the type of thing you described
from happening. I was going to revert it, as it is not central to the issue
for inherited bindings, but I will do more extensive testing with it
included and see if it is ok to leave in.






On Tue, May 19, 2020 at 5:35 AM Brian Raymes <[email protected]>
wrote:

> I cannot speak for js-release, but it happens to me with js-debug in what
> seems like 1 in every 10 builds. Possibly more often.
>
> I've made copies a couple times to compare the output. Each time, it
> appears that some "prototype._bindings" are missing. Here is example
> related to TourDeJewel:
>
> In NavigationGroupExampleItemRenderer.js, the following is missing
> entirely in a bad build:
>
> /**
>  * @export
>  */
> itemRenderers.NavigationGroupExampleItemRenderer.prototype._bindings = [
>          //
>          // contents removed for brevity
>          //
> ];
>
> Several of these "xxxxx.prototype._bindings" sections were missing from
> the generated JavaScript.
>
> Hope this helps.
>
> Brian
>
> -----Original Message-----
> From: Alex Harui <[email protected]>
> Sent: Sunday, May 17, 2020 8:26 AM
> To: [email protected]
> Subject: Re: About the cumbersome random compilation issue
>
> BTW, is this in js-debug or js-release?
>
> On 5/17/20, 8:20 AM, "Alex Harui" <[email protected]> wrote:
>
>     Save a good build. When you think you have a bad build, compare the
> output.
>
>     On 5/17/20, 3:46 AM, "Carlos Rovira" <[email protected]> wrote:
>
>         Hi,
>
>         I want to open a thread about how to solve the weird random
> compilation
>         issue where, from time to time, renderers has no content.
>
>         Since is random, this is hard to find, but seems the problem is
> each time
>         more easy to get.
>
>         I suffer in compling TDJ from time to time. And the result is that
> some
>         times all compiles ok, and other times I get some Navigator
> itemrenders
>         without content (use to be per Navigator component, so all renders
> in a
>         control are affected), other times are TabBar items, other times
> are list
>         item renders inside List playground, and so on. Some times the
> problem
>         affects many of the before mentioned controls, and other times are
> less of
>         them.
>
>         I think as TDJ grows, the problem increases, and I end compiling
> the same
>         2-3 consecutive times until I get the compilation right.
>
>         For me this problem is one requirement to reach 1.0, since it
> reveals a
>         cumbersome issue, that seems to increase with size of the source
> code
>         involved.
>
>         I want to ask here if others are finding this issue too in their
> projects,
>         examples, etc..
>
>         As well what could be the problem. Any theory?
>
>         The problem should be in a compilation task that involve
> components that
>         uses renderers inside. A based renderer control can compile ok,
> but the
>         next one not, and the next could be right again...it's all random.
>
>         It seems a java thread issue where we need to sync better to
> endure things
>         are build properly.
>
>         Any idea or thing we could try to solve this problem?
>
>         Thanks
>
>         --
>         Carlos Rovira
>
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&amp;data=02%7C01%7Caharui%40adobe.com%7C091b10b063f747ec4b8608d7fa75da82%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637253256395538387&amp;sdata=xO5EaBe5pz6F0%2BICaCefem2z8siG4%2FaZqw6Kqpo0VBg%3D&amp;reserved=0
>
>
>
>
>

Reply via email to