The current solution is definitely better. Thanks. I’d like to see if there’s another way to go about it other than subclassing like you did. Not sure yet.
> On Jun 13, 2020, at 10:53 AM, Carlos Rovira <[email protected]> wrote: > > Hi Harbs, > > I think the current solution is PAYG, since now there's a separation in two > beads and the extension is the one adding ISelectionModel support. > But since in Jewel there's still no multiselection support for now, I was > not able to see possible problems regarding that feature in Basic, I think > something should be done in that way probably. Also, I expect runtime > adding, updating or removing items in Basic List (and subcomponents like > DataGrid) will show selection problems (I mean, moving the selection to > unwanted items or giving RTE errors). Maybe it's a bug nobody still saw in > Basic since nobody tried it. > > > > El vie., 12 jun. 2020 a las 14:50, Harbs (<[email protected]>) escribió: > >> It’s currently working with the later fix you did. So this is less urgent. >> I didn’t notice the Github issue and later commit. >> >> I’ll take a look next week probably Sunday on what can be done to make it >> more PAYG. There’s also likely a similar issue for multi-select. Not sure >> yet how easy that would be to solve. >> >>> On Jun 12, 2020, at 2:19 PM, Carlos Rovira <[email protected]> >> wrote: >>> >>> Hi Harbs >>> >>> don't know if you're finally looking into this. If not I can try the >> change >>> I have in mind >>> let me know >>> thanks >>> >>> El jue., 11 jun. 2020 a las 23:43, Harbs (<[email protected]>) >> escribió: >>> >>>> I just discovered a change which looks broken to me.[1] >>>> >>>> It makes the assumption that DataItemRendererFactoryForCollectionView >> has >>>> an ISelectionModel which is not a safe assumption to make. I wish I >> would >>>> have noticed this change earlier, but have a deployed app which is >> broken >>>> due to this. >>>> >>>> I need to resolve this ASAP. I’d like to revert this change, but I’m not >>>> sure why it was made and how to resolve the reason for the change. >>>> >>>> Input please! >>>> Harbs >>>> >>>> [1] >>>> >> https://github.com/apache/royale-asjs/commit/762179106893df044db43a2e6d72555ca57ee5b4#r39845916 >>> >>> >>> >>> -- >>> Carlos Rovira >>> http://about.me/carlosrovira >> >> > > -- > Carlos Rovira > http://about.me/carlosrovira
