One recent example: Carlos recently changed BrowserResizeHandler because he implemented a newer version which is not application-specific.
A good idea and one I support. However, it does break existing applications which use BrowserResizeHandler due to a rename. I happened to notice his commit, so when my app got an error because BrowserResizeHandler was not recognized, I knew right away how to fix it. I could have just as easily missed his commit and been clueless why my app suddenly broke. If there was a PR, it also would have given a good opportunity to raise an issue with the change if I would have had one. If a change does need to be reverted, PRs also make reverting very painless. > On Jun 19, 2020, at 12:28 AM, Harbs <[email protected]> wrote: > > Not breaking things per se. More like being able to see at a glance what has > been done without wading through commit messages. > >> On Jun 19, 2020, at 12:23 AM, Christofer Dutz <[email protected] >> <mailto:[email protected]>> wrote: >> >> If you are having trouble with people breaking things and want to solve this >> problem that way, so you have the additional bandwidth to do the reviews? >> >
