Hi Maria Jose, ok, perfect Thanks! :) El jue., 2 jul. 2020 a las 18:10, Maria Jose Esteve (<[email protected]>) escribió:
> They are practically the same, they differ only in the type of > imageElement, and the set strand function to which an "if" is added. > > If it's okay with you, so as not to make you dizzy anymore, that "some" > emails are already going, I leave it separated into two and, if over time, > you see that everything is better together, I do a PR with only one. > You think? > > Thx. > Hiedra > > -----Mensaje original----- > De: Carlos Rovira <[email protected]> > Enviado el: jueves, 2 de julio de 2020 16:26 > Para: Apache Royale Development <[email protected]> > Asunto: Re: Image, does not flush when link value is null or blank > > Hi Maria Jose, > 1 bead is better than 2, if we don't have significant code in that bead > that is unnecessary for 1 of the cases. > If that is the case, perfect. If not I prefer 2 separate beads, so people > using just Image don't have to pay for code that will never use (and > viceversa for people using ImageButton but not Image) thanks > > El jue., 2 jul. 2020 a las 14:27, Maria Jose Esteve (<[email protected]>) > escribió: > > > Hi Carlos, > > I am making the corrections that Yishay makes for me in both PRs (880 > > and > > 881) > > > > For now, they are different beads: the 880 is for Image and the 881 > > for ImageButton. > > I'm going to create the interface that you tell me about and commit to > 881. > > > > In any case, we could have a single bead applicable to Image and > > ImageButton at the same time, as I mentioned in previous emails. > > > > If you like the idea I can upload the PR of this generic bead and we > > will remove the PR 880 and 881. > > Tell me how you see it best. > > > > Thank you. > > A greeting. > > > > Hiedra. > > > > -----Mensaje original----- > > De: Carlos Rovira <[email protected]> Enviado el: jueves, 2 de > > julio de 2020 11:11 > > Para: Apache Royale Development <[email protected]> > > Asunto: Re: Image, does not flush when link value is null or blank > > > > Hi Maria Jose, > > > > so we can remove PR #880? we stick with #881? did you take into > > account comments from Yishay in #881? if not please do it so we can > > review over the final state. > > About interfaces, if ther's none, you can add one to Core that covers > > that need and add to that controls (if I understand right) thanks! > > > > > > El jue., 2 jul. 2020 a las 10:35, Maria Jose Esteve > > (<[email protected]>) > > escribió: > > > > > Hi, > > > yesterday I made a PR of the ErrorImage bead for controls that > > > implement IImage. > > > I just made another PR for the controls that contain an image but > > > it's not its main element, like the ImageButton. > > > The Basic / Jewel ImageButton controls do not share any standard > > > interface for the image, but the Basic ImageButton contains the > > > _imageElement property to save it. > > > What I propose is to make this public prority and add it to Jewel > > > ImageButton. > > > Maybe there is some common interface or some way to refer to the img > > > wrapper ... > > > > > > I will read your comments in the PR. > > > > > > On the other hand, I have a PR prepared with a common ErrorImage > > > bead for IImage controls and ImageButtons ... how do you see it? (It > > > is a mixture of the two previous PR) > > > > > > Thank you. > > > Hiedra > > > > > > -----Mensaje original----- > > > De: Maria Jose Esteve > > > Enviado el: miércoles, 1 de julio de 2020 20:06 > > > Para: [email protected] > > > Asunto: RE: Image, does not flush when link value is null or blank > > > > > > Hi Carlos, > > > I did not fully understand you. > > > I'm going to mount the PR along this line, but first I want to see > > > if I can spend a little more time on the ErrorImage bead and make it > > > compatible with controls that have an 'img' element. > > > > > > Thanks. > > > Hiedra. > > > > > > -----Mensaje original----- > > > De: Carlos Rovira <[email protected]> Enviado el: miércoles, 1 > > > de julio de 2020 10:32 > > > Para: Apache Royale Development <[email protected]> > > > Asunto: Re: Image, does not flush when link value is null or blank > > > > > > Hi Maria Jose, > > > > > > El mié., 1 jul. 2020 a las 2:06, Maria Jose Esteve > > > (<[email protected]>) > > > escribió: > > > > > > > Why not use the same bead ErrorImage to detect the "" / null and > > > > be able to assign the alternate image if desired? > > > > > > > > > > > yeah! That was what I wanted to say in previous emails. So +1 After > > > your PR is merged I can check it and see if I can add some default > > > image in the jewel case, but that's something for later :) > > > > > > > > > > > > > -- > > > > Carlos Rovira > > > > http://about.me/carlosrovira > > > > > > > > > > > > > > > > > > > > > > > > > -- > > Carlos Rovira > > http://about.me/carlosrovira > > > > > -- > Carlos Rovira > http://about.me/carlosrovira > -- Carlos Rovira http://about.me/carlosrovira
