Yeah ... we should,
however it's not really an issue ... It's just something maven would like us to
do and shouldn't cause any harm in the release.
And regarding the upstream changes ... I know what the changes were as I
implemented them. And therefore I would say:
If the last release was reproducible, so should the current one, even without
my changes.
But of course it would be better to release it and to use the new version in
the release of royale.
I just wanted to point out that it's not going to have much/any effect on the
release if you do it or not.
Chris
Am 13.07.20, 10:53 schrieb "Harbs" <harbs.li...@gmail.com>:
BTW, where should this be fixed?
[WARNING] Some problems were encountered while building the effective model
for org.apache.royale.compiler:compiler-build-tools:maven-plugin:1.2.1-SNAPSHOT
[WARNING] 'build.pluginManagement.plugins.plugin.(groupId:artifactId)' must
be unique but found duplicate declaration of plugin
org.apache.maven.plugins:maven-javadoc-plugin @ line 129, column 17
[WARNING] 'build.plugins.plugin.version' for
com.theoryinpractise:reproducible-maven-plugin is missing. @ line 204, column 19
[WARNING]
[WARNING] It is highly recommended to fix these problems because they
threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support
building such malformed projects.
> On Jul 13, 2020, at 11:50 AM, Harbs <harbs.li...@gmail.com> wrote:
>
> I don’t know, but there seems to be an upstream dependency which needs to
be released. Presumably that’s the compiler-build-tools.
>
>> On Jul 13, 2020, at 11:44 AM, Christofer Dutz
<christofer.d...@c-ware.de> wrote:
>>
>> Hi all,
>>
>> well I agree that it might be good to release the build tools first, but
it seems that the builds were reproducible even without these changes.
>> So theoretically it should be possible to do the release without
releasing the build tools first.
>>
>> Chris
>>
>>
>> Am 13.07.20, 09:35 schrieb "Carlos Rovira" <carlosrov...@apache.org>:
>>
>> Hi,
>>
>> ok, now I understand why tools is going to be release, so forgot my
>> previous email.
>> as others says maven is responsible itself of updating "SNAPSHOTS", you
>> don't need to do it manually
>>
>>
>> El lun., 13 jul. 2020 a las 8:08, Piotr Zarzycki
(<piotrzarzyck...@gmail.com>)
>> escribió:
>>
>>> It is also not recommended to do that manually. Maven has special
commands
>>> for such things.
>>>
>>> On Mon, Jul 13, 2020, 8:06 AM Yishay Weiss <yishayj...@hotmail.com>
wrote:
>>>
>>>> You shouldn’t need to remove -SNAPSHOT manually. That should happen as
>>>> part of (Royale) release step 2, which run mvn release:prepare [1]
>>>>
>>>> [1]
>>>>
>>>
https://maven.apache.org/maven-release/maven-release-plugin/examples/prepare-release.html
>>>>
>>>> From: Harbs<mailto:harbs.li...@gmail.com>
>>>> Sent: Sunday, July 12, 2020 10:47 PM
>>>> To: Apache Royale Development<mailto:dev@royale.apache.org>
>>>> Subject: Re: Royale_Release_Step_002 - Build # 50 - Still Failing!
>>>>
>>>> Or in other words, how does maven-release-plugin work?
>>>>
>>>>> On Jul 12, 2020, at 10:46 PM, Harbs <harbs.li...@gmail.com> wrote:
>>>>>
>>>>> I’m not sure what’s supposed to be happening here. I thought that as
>>>> part of step 1, the release/0.9.8 branch gets the poms sans the
>>> -SNAPSHOT,
>>>> but they still say 0.9.8-SNAPSHOT
>>>>>
>>>>> I tried removing -SNAPSHOT manually, but that didn’t help either.
>>>>>
>>>>> With -SNAPSHOT, I get an error:
>>>>>
>>>>> [ERROR] Failed to execute goal
>>>> org.apache.maven.plugins:maven-release-plugin:3.0.0-M1:prepare
>>>> (default-cli) on project royale-compiler-parent: Can't release project
>>> due
>>>> to non released dependencies :
>>>>> [ERROR]
>>>>
>>>
org.apache.royale.compiler:compiler-build-tools:maven-plugin:1.2.1-SNAPSHOT:runtime
>>>>> [ERROR] in project 'Apache Royale: Compiler: Externc'
>>>> (org.apache.royale.compiler:compiler-externc:jar:0.9.8-SNAPSHOT)
>>>>>
>>>>>
>>>>> Without the -SNAPSHOT, I get an error:
>>>>> [ERROR] Failed to execute goal
>>>> org.apache.maven.plugins:maven-release-plugin:3.0.0-M1:prepare
>>>> (default-cli) on project royale-compiler-parent: You don't have a
>>> SNAPSHOT
>>>> project in the reactor projects list. -> [Help 1]
>>>>> Maven is black magic to me… ;-)
>>>>>
>>>>> Any pointers?
>>>>>
>>>>> Harbs
>>>>>
>>>>>> On Jul 12, 2020, at 10:34 PM, apacheroyal...@gmail.com wrote:
>>>>>>
>>>>>> Royale_Release_Step_002 - Build # 50 - Still Failing:
>>>>>>
>>>>>> Check console output at
>>>>
>>>
http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/Royale_Release_Step_002/50/
>>>> to view the results.
>>>>>
>>>>
>>>>
>>>
>>
>>
>> --
>> Carlos Rovira
>> http://about.me/carlosrovira
>>
>
