Hi Piotr, I'm not finding any issue for now. I'll need some test case to be able to reproduce what's happening to you in order to be able to help you.
I was reading the issue from the initial email and what you're getting is a NPE when requesting the PM. But that seems to that something could be wrong in your build and the new PM class for DataGridColumnList is not found. Otherwise, the code states that when there's no PM a new one must be instantiated, so having the definition must pull directly and having "pressModel" null will trigger the instantiation. So my question is, how are you building? Maybe there's some issue in different ways of building. El mié., 2 sept. 2020 a las 12:06, Piotr Zarzycki (< [email protected]>) escribió: > I need to resolve somehow that issue, cause our app is broken because of > that right now. You are right moving stuff to css and using > loadBeadFromValuesManager is not an option. > > Probably that duplication of initializer is something which need to be > fixed, but I'm not sure if this is the cause of that issue. > > I still think that createList is being called before something is > initialized too early. > > śr., 2 wrz 2020 o 11:45 Carlos Rovira <[email protected]> > napisał(a): > > > Hi Piotr, > > > > The PM is not added via CSS. Don't know why Peter and Alex designed it > that > > way, but I think it's ok. > > > > It's just an object that it's created when retrieved from the getter, and > > can be created at that time or, if configured in MXML you'll get it. > > > > For this one since there's no "loadBeadFromValuesManager" adding in CSS > > will not work since there's no point through all hierarchy that instruct > to > > load it from CSS. > > > > A part from that the issue seems to be the duplicated initializer, going > to > > check if I have it too, and how it's created. > > > > Thanks > > > > > > > > El mié., 2 sept. 2020 a las 11:00, Piotr Zarzycki (< > > [email protected]>) escribió: > > > > > If not trough css styles maybe we should use in [1] function > > > loadBeadFromValuesManager > > > ? > > > > > > [1] > > > > > > > > > https://github.com/apache/royale-asjs/blob/0a33c44db45c684ad2fc742e13e7222b14050f61/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/supportClasses/datagrid/DataGridColumnList.as#L109 > > > > > > śr., 2 wrz 2020 o 10:57 Piotr Zarzycki <[email protected]> > > > napisał(a): > > > > > > > I did locally also following change and I'm able to reproduce issue > in > > > > debug mode, but I'm not sure if it's sufficient to assume it's > correct. > > > > > > > > 1) I have removed code which creates [1] IListPresentationModel bead > > > > 2) I have added in _datagrid.sass in j|DataGridColumnList line: > > > > > > > > IListPresentationModel: > > > > > > ClassReference("org.apache.royale.jewel.beads.models.DataGridColumnListPresentationModel") > > > > > > > > In the results I should in my column beads arrach my > > > IListPresentationModel, but I don't have it at all... > > > > > > > > [1] > > > > > > > > > > https://github.com/apache/royale-asjs/blob/0a33c44db45c684ad2fc742e13e7222b14050f61/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/supportClasses/datagrid/DataGridColumnList.as#L109 > > > > > > > > śr., 2 wrz 2020 o 10:48 Piotr Zarzycki <[email protected]> > > > > napisał(a): > > > > > > > >> Carlos, > > > >> > > > >> I looked into columnList and one of the column. I have found that it > > > >> contains in beads array 2 instances of > > > >> DataGridColumnListItemRendererInitializer [1] > > > >> > > > >> [1] > > > >> > > > > > > https://github.com/apache/royale-asjs/blob/7b41eaee89264b54839564aa8354bb9836aa0dea/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/DataGridView.as#L287 > > > >> [2] https://ibb.co/RSXvt07 > > > >> > > > >> Thanks, > > > >> Piotr > > > >> > > > >> śr., 2 wrz 2020 o 10:23 Piotr Zarzycki <[email protected]> > > > >> napisał(a): > > > >> > > > >>> Never mind I think I figured it out. > > > >>> > > > >>> śr., 2 wrz 2020 o 10:13 Piotr Zarzycki <[email protected]> > > > >>> napisał(a): > > > >>> > > > >>>> Carlos, > > > >>>> > > > >>>> Unfortunately I cannot extract what code causing that issue. > Carlos > > > how > > > >>>> can I change default.css in framework ? I mean if I change it > after > > > build > > > >>>> my changes are wiped out - this is related to SASS ? > > > >>>> > > > >>>> I think this is issue in DataGridView - we are calling createLists > > > function > > > >>>> to early and presentation model list is not yet initialized at > that > > > moment. > > > >>>> > > > >>>> Thanks, > > > >>>> Piotr > > > >>>> > > > >>>> Thanks, > > > >>>> Piotr > > > >>>> > > > >>>> wt., 1 wrz 2020 o 18:35 Carlos Rovira <[email protected]> > > > >>>> napisał(a): > > > >>>> > > > >>>>> Hi Piotr, > > > >>>>> > > > >>>>> ok, I use to try with all examples I have available so if the > code > > is > > > >>>>> something custom you have, I need that you provide some example > > with > > > a > > > >>>>> minimal code to showcase the problem so I can know what the > problem > > > is. > > > >>>>> > > > >>>>> For now I'll let you know the issue so you can see how to > refactor > > > your > > > >>>>> code and see if you can fix yourself: > > > >>>>> 1.- maybe you're using some Presentation Model (PM) directly at > an > > > >>>>> early > > > >>>>> time in a custom code. See that I need to reference the PM after > > the > > > >>>>> column > > > >>>>> list is added, since it doesn't exists until "initComplete" > > > >>>>> 2.- See if you have it as ListPresentationModel, now that List > > needs > > > to > > > >>>>> have DataGridColumnListPresentationModel instead of the other. > > > >>>>> > > > >>>>> The big problem that was hidden is that I was using list PM in > the > > > >>>>> constructor, and that made it impossible to add a custom PM that > of > > > >>>>> course > > > >>>>> made the PM itself useless. > > > >>>>> > > > >>>>> Let me know if you find the issue, or if not try to make a simple > > > >>>>> project > > > >>>>> so I can take a look at it and reproduce the issue > > > >>>>> > > > >>>>> thanks > > > >>>>> > > > >>>>> > > > >>>>> El mar., 1 sept. 2020 a las 17:59, Piotr Zarzycki (< > > > >>>>> [email protected]>) escribió: > > > >>>>> > > > >>>>> > I forgot to mention that it is not reproducible in tourdejewel. > > > >>>>> There is > > > >>>>> > probably some case which you don't have in example code. I > > thought > > > >>>>> you will > > > >>>>> > know maybe based on what you did why it happened. Maybe > something > > > is > > > >>>>> being > > > >>>>> > called to early... > > > >>>>> > > > > >>>>> > wt., 1 wrz 2020 o 16:58 Carlos Rovira <[email protected] > > > > > >>>>> > napisał(a): > > > >>>>> > > > > >>>>> > > Hi Piotr, > > > >>>>> > > > > > >>>>> > > maybe something is stale in your build? I just tried the > > release > > > >>>>> version > > > >>>>> > > and all seems to work fine. > > > >>>>> > > Let me know what could be > > > >>>>> > > Thanks > > > >>>>> > > > > > >>>>> > > El mar., 1 sept. 2020 a las 16:56, Carlos Rovira (< > > > >>>>> > [email protected] > > > >>>>> > > >) > > > >>>>> > > escribió: > > > >>>>> > > > > > >>>>> > > > Thanks for reporting Piotr, > > > >>>>> > > > I will take a look. It's part of the fixes yesterday about > > PMs. > > > >>>>> > > > > > > >>>>> > > > > > > >>>>> > > > El mar., 1 sept. 2020 a las 16:25, Piotr Zarzycki (< > > > >>>>> > > > [email protected]>) escribió: > > > >>>>> > > > > > > >>>>> > > >> Hi, > > > >>>>> > > >> > > > >>>>> > > >> I have pulled all changes from Royale and build our app. > > Debug > > > >>>>> build > > > >>>>> > is > > > >>>>> > > >> working perfectly fine, but release build is failing. I > > cannot > > > >>>>> find > > > >>>>> > > cause > > > >>>>> > > >> of issue, but here is the details. > > > >>>>> > > >> > > > >>>>> > > >> I'm getting NPE in this line [1] - It looks like > > > >>>>> > > >> DataGridColumnListPresentationModel is null. > > > >>>>> > > >> > > > >>>>> > > >> TypeError: Cannot set property 'rowHeight' of null > > > >>>>> > > >> > > > >>>>> > > >> Any ideas ? > > > >>>>> > > >> > > > >>>>> > > >> [1] > > > >>>>> > > >> > > > >>>>> > > >> > > > >>>>> > > > > > >>>>> > > > > >>>>> > > > > > > https://github.com/apache/royale-asjs/blob/94693e9583680ffa992ead9fc4663bb9e25b97aa/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/DataGridView.as#L237 > > > >>>>> > > >> > > > >>>>> > > >> Thanks, > > > >>>>> > > >> -- > > > >>>>> > > >> > > > >>>>> > > >> Piotr Zarzycki > > > >>>>> > > >> > > > >>>>> > > > > > > >>>>> > > > > > > >>>>> > > > -- > > > >>>>> > > > Carlos Rovira > > > >>>>> > > > http://about.me/carlosrovira > > > >>>>> > > > > > > >>>>> > > > > > > >>>>> > > > > > >>>>> > > -- > > > >>>>> > > Carlos Rovira > > > >>>>> > > http://about.me/carlosrovira > > > >>>>> > > > > > >>>>> > > > > >>>>> > > > > >>>>> > -- > > > >>>>> > > > > >>>>> > Piotr Zarzycki > > > >>>>> > > > > >>>>> > > > >>>>> > > > >>>>> -- > > > >>>>> Carlos Rovira > > > >>>>> http://about.me/carlosrovira > > > >>>>> > > > >>>> > > > >>>> > > > >>>> -- > > > >>>> > > > >>>> Piotr Zarzycki > > > >>>> > > > >>> > > > >>> > > > >>> -- > > > >>> > > > >>> Piotr Zarzycki > > > >>> > > > >> > > > >> > > > >> -- > > > >> > > > >> Piotr Zarzycki > > > >> > > > > > > > > > > > > -- > > > > > > > > Piotr Zarzycki > > > > > > > > > > > > > -- > > > > > > Piotr Zarzycki > > > > > > > > > -- > > Carlos Rovira > > http://about.me/carlosrovira > > > > > -- > > Piotr Zarzycki > -- Carlos Rovira http://about.me/carlosrovira
