Hi Carlos, I think for Ant we use the config, which is checked in under src/??? ... the maven plugin generates that on the fly from the configuration. Perhaps comparing the generated one with also the ant version could help shed some light on this.
Chris Am 08.09.20, 20:39 schrieb "Carlos Rovira" <[email protected]>: Hi Chris, thanks. I must say that I don't know much more about config.xml since I think that is provided by maven directly right?. but I'll try to check it tomorrow to see differences with and without the dependency El mar., 8 sept. 2020 a las 18:59, Christofer Dutz (< [email protected]>) escribió: > Hi Carlos, > > The thing is, Maven doesn't know about release and debug builds. So the > network of dependencies should be identical in both cases ... > Perhaps there are situations where the debug compiler doesn't fail but the > release version does. > > Would be interesting to know which these differences are. Then I could > help harden the tooling to detect this sort of thing. > > Perhaps comparing the generated config.xml could help shed some light on > this? > But I think it would be cool if some of you did this as I personally have > almost no knowledge of good and bad config.xml configurations ;-) > > Chris > > > Am 08.09.20, 17:57 schrieb "Carlos Rovira" <[email protected]>: > > Hi Chris, > > you're right, having a runnable test will show this problem early so > +1 to > add it. > Also, the problem itself could be related to the latest updates we did > in > maven?, I mean, debug works ok, but release needs to add jewel swc > dependency to the pom, so it seems to me something related to how maven > builds the project. Some months ago it worked, but nowadays it is > failing, > so for that reason I point to it. Maybe you probably know better than > me if > that could be the case. > Thanks Chris > > El mar., 8 sept. 2020 a las 12:43, Christofer Dutz (< > [email protected]>) escribió: > > > Hi all, > > > > I think I should get started on building a replacement for the > geckodriver > > test I added years ago (and disabled recently) ... cause this was > exactly > > the type of thing I tried to address with that. > > The build seems to be compiling correctly, but the compiled > application > > wasn't runnable (correct?) > > > > I think if we had a test, that would simply click through the basics > of > > our examples, we would have found this issue relatively quickly > after the > > change that caused it occurred. > > > > What do you think? > > > > Chris > > > > > > Am 08.09.20, 12:01 schrieb "Carlos Rovira" <[email protected] > >: > > > > Hi Greg, > > > > thanks for fixing it! > > The fail is very strange, since it compiles ok (so Jewel SWC is > > known), but > > the output is not getting the Jewel definitions right? > > So maybe just a Maven issue? Maybe Chris could know more about > this. > > Anyway, the example is working for now, so I'll can breath for > the the > > ApacheCon talk :) > > > > El mar., 8 sept. 2020 a las 1:44, Greg Dove (< > [email protected]>) > > escribió: > > > > > I am confident (now) that this is not related to the changes > that > > Josh has > > > been working on. > > > > > > I discovered the 'fix' by accident today and pushed a change > for > > that. > > > I realized that the working build I was checking against was > an old > > ant > > > build, so I was not comparing 'apples with apples' because I > was > > checking > > > against the current maven build. > > > > > > If this was working previously with maven build, then perhaps > > something > > > changed in the maven configuration/hierarchy since the last > time you > > > checked that. > > > > > > Actually, my guess is that this was because I assume you > copied it > > from the > > > todomvc in the jewel examples. The 'jewel' examples all > inherit the > > Jewel > > > dependency from their parent pom, but in the crux examples > they do > > not. > > > How it automatically became specified as 'external', and > therefore > > still > > > compiled without errors in the crux example, I am less sure at > this > > > point.... > > > > > > > > > > > > > > > > > > > > > On Mon, Sep 7, 2020 at 8:31 PM Carlos Rovira < > > [email protected]> > > > wrote: > > > > > > > Hi Greg, > > > > > > > > if it's related to export maybe @Josh Tynjala < > > [email protected] > > > > > > > > could > > > > give some light here. I think he worked recently in some > compiler > > commits > > > > on that topic. > > > > > > > > Yesterday I was investigating the issue and the > “CruxQuickStart” > > example > > > > works ok, while the “todomvc-jewel-crux” example does not. I > was > > trying > > > to > > > > compare both to see any difference, but I couldn’t find any > issue > > that > > > > makes "todomvc-jewel-crux" work again in release. > > > > > > > > ApacheCon talk that will use this example is Sep, 31th. > > > > > > > > Thanks for taking a look :) > > > > > > > > Carlos > > > > > > > > El lun., 7 sept. 2020 a las 7:01, Greg Dove (< > [email protected] > > >) > > > > escribió: > > > > > > > > > I am not sure what the problem is yet Carlos, but it seems > > related to > > > > > export, in this case with missing export of jewel base > classes. > > > > > > > > > > The issue is that 'window.org.apache.royale.jewel' is > undefined > > and so > > > it > > > > > is failing to get 'org.apache.royale.jewel.View' via > reflection > > > > > (getDefinitionByName call). > > > > > This happens after the View subclass is 'added to stage' > and is > > part of > > > > the > > > > > Crux view processing that includes iterating over ancestor > > classes, > > > which > > > > > is the part that is having a problem. > > > > > This *did *work in the past for the Crux TODOMVC app (I > have an > > old > > > > release > > > > > build of that app from early May 2020 that works). > > > > > Why it is not working now is something that will probably > take > > me some > > > > time > > > > > to figure out, and I am a bit limited in terms of > availability > > for that > > > > at > > > > > the moment, so can't promise to spend a lot of time on it, > just > > to try > > > on > > > > > weekends. > > > > > > > > > > When is the ApacheCon track? > > > > > > > > > > > > > > > On Thu, Sep 3, 2020 at 11:35 PM Carlos Rovira < > > [email protected] > > > > > > > > > wrote: > > > > > > > > > > > Hi, > > > > > > > > > > > > Trying new changes in the compiler this morning I > noticed that > > > > > > "examples/crux/todomvc-jewel-crux" is failing in release > mode > > (debug > > > > > seems > > > > > > to work ok): > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > *getDefinitionByName.js:34 Uncaught TypeError: Cannot > read > > property > > > > > 'View' > > > > > > of undefined at Pv (getDefinitionByName.js:34) at > Rv.M.Jj > > > > > > (TypeDefinition.as:389) at SD.fromTypeDefinition > > > > > > (TypeDescriptor.as:167) at > Function.mw.getTypeDescriptor > > > > > > (TypeCache.as:60) at Function.$x.constructBean > > > (BeanFactory.as:616) > > > > > > at Function.Yx.setUp (CruxManager.as:106) at > > $x.setUpEventHandler > > > > > > (BeanFactory.as:517) at oF.S.fireListeners > > > (EventDispatcher.as:131) > > > > > > at dv (eventtarget.js:372) at hC.M.Eo > > (JSStageEvents.as:209)* > > > > > > > > > > > > This is the example I need to prepare for the forthcoming > > ApacheCon > > > > event > > > > > > in one of the tracks, so I was looking at what could be > the > > problem > > > and > > > > > > trying to fix it. > > > > > > I reverted the compiler to try to find a point where the > > example > > > works > > > > > > again, but I couldn't. > > > > > > > > > > > > So I hope others could help me to detect what could be > the > > cause of > > > > this > > > > > > issue. > > > > > > > > > > > > Thanks in advance for your help. > > > > > > > > > > > > -- > > > > > > Carlos Rovira > > > > > > http://about.me/carlosrovira > > > > > > > > > > > > > > > > > > > > > > > -- > > > > Carlos Rovira > > > > http://about.me/carlosrovira > > > > > > > > > > > > > -- > > Carlos Rovira > > http://about.me/carlosrovira > > > > > > -- > Carlos Rovira > http://about.me/carlosrovira > > -- Carlos Rovira http://about.me/carlosrovira
