Hi, since I think we're all in the same page I'll be removing this TLC methods today thanks
El lun., 14 sept. 2020 a las 10:37, Carlos Rovira (<[email protected]>) escribió: > Hi Piotr, > > each property is in its Presentation Model, we are just duplicating a few > in TLC exposing as TLC's official API. > > About PMs: Right now each component used to have its own definition of PM > with some particularity, if not due to some new property, maybe about > initialization or default values. > > So the plan is just to remove the duplicated APIs from the TLC. That's > mostly "rowHeight" and "variableRowHeight" from List and DataGrid (maybe > could be something more since I'm talking from memory). > > You always can continue using them in a new instance of the bead like I > posted in the initial email of the thread, since PMs are working fine now. > > > El lun., 14 sept. 2020 a las 9:33, Piotr Zarzycki (< > [email protected]>) escribió: > >> Hi Carlos, >> >> Where would you move them ? I mean those properties would be in specific >> to >> the component presentation models ? >> >> sob., 12 wrz 2020 o 16:06 Hugo Ferreira <[email protected]> >> napisał(a): >> >> > Hi, >> > >> > I use row Height and yes, it's very strange not to be a bead. >> > For me go ahead. I will ajuste the code on my side after upgrade with >> the >> > new change. >> > >> > Carlos Rovira <[email protected]> escreveu no dia sábado, >> 12/09/2020 >> > à(s) 11:52: >> > >> > > Hi, >> > > >> > > While working on a fix for Presentation Models in Jewel I noticed >> that we >> > > have many PM variables that are not used most of the time in >> component's >> > > TLC. This happens in List, DataGrid, DataGridColumnList and TabBar >> > > >> > > For example, we should do: >> > > >> > > <j:TabBar> >> > > <j:beads> >> > > <j:TabBarPresentationModel rowHeight="60"/> >> > > </j:beads> >> > > </j:TabBar> >> > > >> > > instead of >> > > >> > > <j:TabBar rowHeight="60"> >> > > >> > > to keep with PAYG. >> > > >> > > Also we have just some variables, but not all exposed >> > > >> > > variables exposed in TLCs are: >> > > >> > > - rowHeight >> > > - variableRowHeight >> > > >> > > This even makes it inconsistent since we probably want to add more PM >> > > particularities in the future, and doesn't have sense to me to have >> just >> > > some in TLC. >> > > >> > > If there's no opposition I'll be removing those jewel vars in the next >> > > days. >> > > >> > > Thanks >> > > >> > > >> > > >> > > -- >> > > Carlos Rovira >> > > http://about.me/carlosrovira >> > > >> > >> >> >> -- >> >> Piotr Zarzycki >> > > > -- > Carlos Rovira > http://about.me/carlosrovira > > -- Carlos Rovira http://about.me/carlosrovira
