Hi,
if the experience of the old TabBar is not what you expect, the new will be
exactly the same. Just need a bead cause of PAYG.
Another thing is if we need to improve TabBar navigation. If that's what
you're talking about, I'm with you, and more time needs to be invested on
it. But that's another topic and nothing related to the changes done in the
past iteration. Moreover, that change was needed to have the TabBar in the
current state to work over the navigation issues.
If you say me the actual TabBar is working differently from the one before
the changes, then we need to see what's going on and if it's a bug or
simply some case was left behind.
El dom., 1 nov. 2020 a las 20:09, Piotr Zarzycki (<piotrzarzyck...@gmail.com>)
escribió:
> Carlos,
>
> I have 25 tabs. How you will navigate when you have 25 - Can you try and
> tell me what's your experience?
>
> On Sun, Nov 1, 2020, 7:31 PM Carlos Rovira <carlosrov...@apache.org>
> wrote:
>
> > Hi Piotr,
> > is just PAYG. adding the bead gets back to the previous state. Don't
> > understand what's your problem here
> > I just decouple the component to avoid baking optional things. If you
> have
> > just 3 tabs (must of us have just that) you don't need scrolling. If you
> > need scrolling, just add the bead.
> >
> > HTH
> >
> >
> > El vie., 30 oct. 2020 a las 12:13, Piotr Zarzycki (<
> > piotrzarzyck...@gmail.com>) escribió:
> >
> > > I think scrolling is not an option at least not for us. I cannot
> imagine
> > > navigate using scrollbar trough 100 tabs. I think navigation buttons
> > should
> > > be introduced in that case. We have this implemented and it was working
> > > when TabBar structure was in previous state.
> > >
> > > Anyway I will just in my own code extend current TabBar and get back to
> > > previous structure, but consider that case and check how usable is
> > actually
> > > scrollbar. To me personally it is unusable, it has bad experience for
> > user.
> > >
> > > pt., 30 paź 2020 o 12:04 Carlos Rovira <carlosrov...@apache.org>
> > > napisał(a):
> > >
> > > > Hi Piotr,
> > > >
> > > > ok I was not understanding your question.
> > > > TabBar was refactored to allow more bead config instead of having all
> > > > things baked in the main component.
> > > > So your problem is about scrolling, and that's not baked anymore. You
> > > just
> > > > need to add a *ScrollingViewport* bead.
> > > > That was shown in TDJ scrolling example
> > > >
> > > > <j:TabBar width="100%" localId="tabbar3"
> > > dataProvider="{scrolltabBarData}">
> > > > <j:beads> <j:ScrollingViewport/> <j:AssignTabContent
> > > > selectedContentProperty
> > > > ="hash">
> > > >
> > > > HTH
> > > >
> > > >
> > > > El vie., 30 oct. 2020 a las 10:15, Piotr Zarzycki (<
> > > > piotrzarzyck...@gmail.com>) escribió:
> > > >
> > > > > Sorry I was writing this one in a hurry. I meant here Do not look
> too
> > > css
> > > > > classes, focus on structure of HTML. ;)
> > > > >
> > > > > czw., 29 paź 2020 o 20:26 Piotr Zarzycki <
> piotrzarzyck...@gmail.com>
> > > > > napisał(a):
> > > > >
> > > > > > Carlos,
> > > > > >
> > > > > > Do not look into the case classes - I have removed them. Look
> > closer
> > > to
> > > > > > the structure - is it the same?
> > > > > >
> > > > > > On Thu, Oct 29, 2020, 6:50 PM Carlos Rovira <
> > carlosrov...@apache.org
> > > >
> > > > > > wrote:
> > > > > >
> > > > > >> Hi Piotr,
> > > > > >>
> > > > > >> can't recognize the html output you're showing in the pastes.
> > > > > >> This is one from TDJ:
> > > > > >>
> > > > > >> https://paste.apache.org/hi1t6
> > > > > >>
> > > > > >> As you can see is far more complex
> > > > > >>
> > > > > >>
> > > > > >> El jue., 29 oct. 2020 a las 12:58, Piotr Zarzycki (<
> > > > > >> piotrzarzyck...@gmail.com>) escribió:
> > > > > >>
> > > > > >> > Hello Carlos,
> > > > > >> >
> > > > > >> > We are using in our app TabBar quite extensively. Lately I
> have
> > > > > noticed
> > > > > >> > that you have changed structures of that component
> > significantly.
> > > > > >> >
> > > > > >> > Following code [1] was translated to this one [2] - now it's
> > being
> > > > > >> > translated to this one [3].
> > > > > >> >
> > > > > >> > The reason for that was to simplify things or something else ?
> > > > > >> >
> > > > > >> > How would you than resolve problem where there is horizontal
> tab
> > > bar
> > > > > >> with
> > > > > >> > 100 tabs ?
> > > > > >> >
> > > > > >> > [1] https://paste.apache.org/8yxhd
> > > > > >> > [2] https://paste.apache.org/ssgte
> > > > > >> > [3] https://paste.apache.org/am9r5
> > > > > >> >
> > > > > >> > Thanks,
> > > > > >> > --
> > > > > >> >
> > > > > >> > Piotr Zarzycki
> > > > > >> >
> > > > > >>
> > > > > >>
> > > > > >> --
> > > > > >> Carlos Rovira
> > > > > >> Apache Member & Apache Royale PMC
> > > > > >> *Apache Software Foundation*
> > > > > >> http://about.me/carlosrovira
> > > > > >>
> > > > > >
> > > > >
> > > > > --
> > > > >
> > > > > Piotr Zarzycki
> > > > >
> > > >
> > > >
> > > > --
> > > > Carlos Rovira
> > > > Apache Member & Apache Royale PMC
> > > > *Apache Software Foundation*
> > > > http://about.me/carlosrovira
> > > >
> > >
> > >
> > > --
> > >
> > > Piotr Zarzycki
> > >
> >
> >
> > --
> > Carlos Rovira
> > Apache Member & Apache Royale PMC
> > *Apache Software Foundation*
> > http://about.me/carlosrovira
> >
>
--
Carlos Rovira
Apache Member & Apache Royale PMC
*Apache Software Foundation*
http://about.me/carlosrovira
