+1 Voting +1 even if there is an issue in there which we should address in future releases (See in the NOTES at the end). I ran the approval script and additionally did my manual review steps.
Output from the approval script: Package https://dist.apache.org/repos/dist/dev/royale/compiler-build-tools/1.2.1/rc1/apache-royale-compiler-build-tools-1.2.1-source-release.zip Java 9 OS: Mac OS X x86_64 10.15.7 Source kit signatures match: y Source kit builds: y README is ok: ${readme.ok} RELEASE_NOTES is ok: ${releasenotes.ok} NOTICE is ok: y LICENSE is ok: y No unapproved licenses or archives in source package: y No unapproved binaries in source package: y Package https://dist.apache.org/repos/dist/dev/royale/compiler-build-tools/1.2.1/rc1/binaries/compiler-build-tools-1.2.1.jar Binary signatures match: y NOTICE is ok: y LICENSE is ok: y main: BUILD SUCCESSFUL Total time: 2 minutes 39 seconds Additionally manually doing the review: [OK] Download all staged artifacts under the url specified in the release vote email into a directory we’ll now call download-dir. [OK] Verify the signature is correct: Additional Apache tutorial on how to verify downloads can be found here. [OK] Check if the signature references an Apache email address. [OK] Verify the SHA512 hashes. [OK] Unzip the archive [OK] Verify the existence of LICENSE, NOTICE, RELEASE_NOTES files in the extracted source bundle. [OK] Verify the content of LICENSE, NOTICE, RELEASE_NOTES files in the extracted source bundle. [OK] Run RAT externally to ensure there are no surprises. [MINOR] Search for SNAPSHOT references. [OK] Search for Copyright references, and if they are in headers, make sure these files containing them are mentioned in the LICENSE file. [OK] Build the project according to the information in the README.md file. (Using "mvn install" due to lack of README) NOTES: - Having the manually patched version of the maven-scm-provider-jgit in the build actually makes it not reproducible. In order to be able to do so the used must manually checkout the sources, apply the patch (which isn't documented in the pom.xml) and build and use that version from now-on. I strongly opt for either getting rid of this plugin, or to get the patch into the mainstream build for that project. . The RELEASE_NOTES are just empty. Perhaps remove them or start filling them. Am 23.11.20, 16:28 schrieb "Harbs" <harbs.li...@gmail.com>: Hi, This is the vote for the 1.2.1 release of Apache Royale Compiler Build Tools. The release candidate can be found here; https://dist.apache.org/repos/dist/dev/royale/compiler-build-tools/1.2.1/rc1/ Before voting please review the section,'What are the ASF requirements on approving a release?', at: http://www.apache.org/dev/release.html#approving-a-release At a minimum you would be expected to check that: - SHA and signed packages are correct - NOTICE and LICENSE files are all fine - That "mvn clean install" in the root of the source package completes successfully - That you can modify other compiler poms to use that version of compiler-build-tools and build the compiler. The KEYS file is at https://dist.apache.org/repos/dist/release/royale/KEYS Maven artifacts are staged here: https://repository.apache.org/content/repositories/orgapacheroyale-1078/ Please vote to approve this release: +1 Approve the release -1 Disapprove the release (please provide specific comments to why) This vote will be open for 72 hours or until a result can be called. The vote passes if there is: - At least 3 +1 votes from the PMC - More positive votes than negative votes People who are not in PMC are also encouraged to test out the release and vote, although their votes will not be binding, they can influence how the PMC votes. When voting please indicate what OS, IDE, Flash Player version and AIR version you tested with. For your convenience, there is an ant script that automates the common steps to validate a release. Instead of individually downloading the package and signature files, unzipping, etc, you can instead: 1) create an empty folder, 2) download into that folder this file: https://dist.apache.org/repos/dist/dev/royale/compiler-build-tools/1.2.1/rc1/ApproveBuildTools.xml 3) run the script: ant -e -f ApproveBuildTools.xml -Drelease.version=1.2.1 -Drc=1 You are not required to use this script, and more testing of the packages and build results are always encouraged. Please put all discussion about this release in the DISCUSSION thread not this VOTE thread. Thanks, Harbs
