Hi Edward, Did you fix that ? If you have made PR - which one is fixing that ? I would like to merge it to move forward with release.
Thanks, Piotr pt., 9 lip 2021 o 14:44 Edward Stangler <estang...@bradmark.com> napisał(a): > > Yes, I've reproduced with a stand-alone test case based on the tests. > > I know what the problem is, now. > > The fix is easy, and I've tested it, but I need a little more time with it. > > > > On 7/9/2021 6:53 AM, Yishay Weiss wrote: > Good to know you are working on it. Were you able to run the tests? If > not, it may be enough to run an app with an includeIn and a state change. > As you can see up thread contanerviiew.addviewport is what's failing. > > My CLT-L09. On O2. > > > -------- Original message -------- > From: Edward Stangler <estang...@bradmark.com><mailto: > estang...@bradmark.com> > Date: Fri, 9 Jul 2021, 05:07 > To: Yishay Weiss <yishayj...@hotmail.com><mailto:yishayj...@hotmail.com>, > dev@royale.apache.org<mailto:dev@royale.apache.org> > Subject: Re: Mustella Tests > > I think the last few comments in PR 1041 are the same issue. I started to > explain why I made this commit. > > Basically, the commit was needed so that I could do more important work in > other areas, to fix several difficult issues. (I have uncommitted work > from that time period.) For one thing, it made debugging much much > easier. And it helped in some other ways. (I understand what Alex > mentioned, but I think the commit was an improvement. But I need to see if > I left something out of the commit. Obviously, if this test error remains, > the commit needs to be rolled back.) > > Sorry for the delay in addressing this. I'm working on it right now > (trying to get the tests running on my PC). > > > > On 7/8/2021 7:52 AM, Yishay Weiss wrote: > > Looks like reverting 6d1c020577cec69b6207a5b46356b6a2b74f308c fixes it > > > > @Edward Stangler<mailto:estang...@bradmark.com> , do you think you can > have a look? > > > > Here’s what I needed to do to run Mustella tests: > > > > 1. Make sure the following env vars are defined (I’m giving my values > for reference) > > > > AIR_HOME=C:\MoonshineSDKs\Flex_SDK\Flex_4.16.1_AIR_32.0 > > FLASHPLAYER_DEBUGGER=C:\dev\content_debugger\flashplayer_32_sa_debug.exe > > GOOG_HOME=C:\dev\full_royale_sdk\royale-asjs\js\lib\google\closure-library > > PLAYERGLOBAL_HOME=C:\dev\player > > > > 1. Make sure %PLAYERGLOBAL_HOME%/11.1/playerglobal.swc exists > 2. Make sure ~/mm.cfg exists and contains the following line > > > > TraceOutputFileEnable=1 > > > > 1. cd …/royale-asjs/ > 2. ant basictests > > > > From: Yishay Weiss<mailto:yishayj...@hotmail.com> > Sent: Thursday, July 8, 2021 9:23 AM > To: dev@royale.apache.org<mailto:dev@royale.apache.org> > Subject: RE: Mustella Tests > > > > Ok, got it. I do not have a Mac. I’ll look at the Git log for changes to > containerview. > > > > Enjoy your vacation! > > > > From: Alex Harui<mailto:aha...@adobe.com.INVALID> > Sent: Wednesday, July 7, 2021 8:37 PM > To: dev@royale.apache.org<mailto:dev@royale.apache.org> > Subject: Re: Mustella Tests > > > > I'm on a family trip and took my windows laptop instead of my Mac. I > debugged into it and now wonder how it passed on the Mac. There were > changes to basic containerview that don't seem right for swf. > Maybe you can debug on Mac in containerview addviewport or maybe Mac isn't > output log and we are looking at old log. > > Sent via the Samsung Galaxy A51 5G, an AT&T 5G smartphone > Get Outlook for Android<https://aka.ms/AAb9ysg> > > ________________________________ > From: Yishay Weiss <yishayj...@hotmail.com><mailto:yishayj...@hotmail.com> > Sent: Tuesday, July 6, 2021 8:56:42 AM > To: dev@royale.apache.org<mailto:dev@royale.apache.org> < > dev@royale.apache.org><mailto:dev@royale.apache.org> > Subject: RE: Mustella Tests > > Did you rule out fp versions and different env vars? > > From: Alex Harui<mailto:aha...@adobe.com.INVALID> > Sent: Tuesday, July 6, 2021 9:12 AM > To: dev@royale.apache.org<mailto:dev@royale.apache.org><mailto: > dev@royale.apache.org><mailto:dev@royale.apache.org> > Subject: Re: Mustella Tests > > I got the same error on my Windows machine, but it passed on my Mac. Very > strange because I don't think we have much mac vs win code. Not sure if > I'll have time to debug into it. > > -Alex > > On 7/5/21, 2:42 AM, "Yishay Weiss" <yishayj...@hotmail.com><mailto: > yishayj...@hotmail.com> wrote: > > > Hi Guys, > > We’re close to having a release out. The hurdle right now is that > Mustella tests are failing on the CI. Does anyone have time to test if they > are passing locally on their pc? Right now it fails for me with > > > >scriptName=halo.scripts::ButtonTestScript&id=SetupButtonTest&result=fail&elapsed=13&phase=body&started=1625149537338&extraInfo=&msg=ArgumentError: > Error #2024: An object cannot be added as a child of itself.^ > > Looking at ButtonTest I think this is caused by a state change that > manifests in an includeIn command. I don't know if includeIn stopped > working in swf (this test passed previously) or if I’m missing some env var > on CI. > > I will probably revisit this by the end of the week if nobody else > beats me to it. > > Thanks. > > > > > > > -- Piotr Zarzycki
