Good point, and yes, that made some of the tests pass. I am not familiar with 
the differences between mx swf and js, so I don’t know why we need a JS clause 
there at all…

From: Josh Tynjala<mailto:joshtynj...@bowlerhat.dev>
Sent: Thursday, November 4, 2021 6:44 PM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>; 
yish...@apache.org<mailto:yish...@apache.org>
Subject: Re: Re: mxtests failing

If removing the override fixes the mxtests, maybe it would help if
super.handleChildrenAdded() is also called on SWF? Like this instead:

super.handleChildrenAdded(event);
COMPILE::JS {
        listenToChildren();
}

I don't know much about the framework internals, so that's just kind of a
wild guess.

--
Josh Tynjala
Bowler Hat LLC <https://bowlerhat.dev>


On Thu, Nov 4, 2021 at 9:31 AM Yishay Weiss <yish...@apache.org> wrote:

> It's definitely being caused by changes done ResizeBranch. If I remove
> this override from BoxLayout.as it will work
>
>                 override protected function
> handleChildrenAdded(event:Event):void
>                 {
>                         COMPILE::JS {
>                                 super.handleChildrenAdded(event);
>                                 listenToChildren();
>                         }
>                 }
>
> But that would break ChildResize functionality.
>
> One interesting finding is that adding an element to the main test
> application helps pass some of the tests, as shown in the test_mxtests
> branch that I pushed. Edward, you have some experience dealing with the swf
> side of things so any input would be welcome.
>
> Thanks.
>
> On 2021/11/02 17:38:39 Yishay Weiss wrote:
> > fdb shows this line
> >
> > =121                    var targets:Array =
> actualTarget.stage.getObjectsUnderPoint(stagePt);
> >
> > in DispatchMouseEvent fails because actualTarget.stage in null
> (actualTarget is ComboBoxList)
> >
> > This rings familiar, so if anyone has a recollection, please share.
> Otherwise, I'll continue to search the offending commit.
> >
> > On 2021/11/02 12:42:51, Yishay Weiss <yish...@apache.org> wrote:
> > > Could be the ChildResize merge (CI shows it started failing after
> that). I'll have a look.Thanks.
> > >
> > > On 2021/11/02 05:26:09, Edward Stangler <estang...@bradmark.com>
> wrote:
> > > > Anyone else having problems with:  ant mxtests
> > > >
> > > > Flash Debug Player comes up, but nothing happens.  It's a recent
> > > > change;  it was working not too long ago.  Other tests run fine.
> > > >
> > > > flashlog.txt:
> > > >
> > > > TestCase Start: ComboBoxTestScript$SetupComboBoxTest
> > > > RESULT:
> > > >
> scriptName=halo.scripts::ComboBoxTestScript&id=SetupComboBoxTest&result=pass&elapsed=108&phase=body&started=1635825506757&extraInfo=&msg=
> > > > TestCase Start: ComboBoxTestScript$ComboBoxTest1
> > > > RESULT:
> > > >
> scriptName=halo.scripts::ComboBoxTestScript&id=ComboBoxTest1&result=fail&elapsed=2&phase=body&started=1635825506894&extraInfo=null&msg=AssertPropertyValue(body:step
> > > > 3)  haloComboBoxTests.testCombo.dropdown.visible false != true
> > > > TestCase Start: ComboBoxTestScript$ComboBoxTest2
> > > > runid.properties ERROR handler with: [SecurityErrorEvent
> > > > type="securityError" bubbles=false cancelable=false eventPhase=2
> > > > text="Error #2048: Security sandbox violation:
> > > >
> file:///C|/somewhere/royale%2Dasjs/mustella/tests/mxtests/basicTests/BasicTests.swf<file:///C:/somewhere/royale%2Dasjs/mustella/tests/mxtests/basicTests/BasicTests.swf>
> > > > cannot load data from
> > > > http://localhost:80/runid.properties?0.94145911047235131635825506356
> ."]
> > > >
> > > >
> > > >
> > >
> >
>

Reply via email to