Hello,
@Hugo, look at the commit I did yesterday, Jewel TriStateCheckBox, it actively
uses sass.
I don't know if all the changes are correct, if they are not they will be very
close..., I looked at the current implementations and tried to follow your
guide:
In this case, being an extension of the Jewel CheckBox control, it wasn't too
complicated. This is what I understood:
1) projects/Jewel/src/main/sass/components/_checkbox.sass (when Jewel is
compiled, the "default" style is generated in defaults.css).
2) themes/JewelTheme/src/main/sass/components-primary/_checkbox.sass (Here I
configured the colors and properties related to the themes)
3) I have some pending changes to commit to make it complete in
components-emphasized and components-secondary (they don't currently exist, but
I think they should exist as well. In my local project it works fine)
You will have to compile, as Greg says, with the -Poption-with-sass-compile
profile, to verify it completely.
Let me know if you have any problems and I'll try to help you.
Hiedra.
-----Mensaje original-----
De: Hugo Ferreira <hferreira...@gmail.com>
Enviado el: domingo, 5 de diciembre de 2021 22:58
Para: Apache Royale Development <dev@royale.apache.org>
Asunto: Re: [royale-asjs] branch develop updated: Fixed the brackets position
according to Royale best practices
Thank you.
I guess that this is what I have to add to the _datagrid.sass file:
.first.jewel.list::-webkit-scrollbar
display: none
.first.jewel.list
-ms-overflow-style: none;
scrollbar-width: non
.middle.jewel.list::-webkit-scrollbar
display: none
.middle.jewel.list
-ms-overflow-style: none
scrollbar-width: none
Can you confirm that the location and syntax is correct?
Greg Dove <greg.d...@gmail.com> escreveu no dia domingo, 5/12/2021 à(s)
19:23:
> Sure, if you look in Jewel/src/main/sass you should see things related
> to that.
>
> it includes structured components styling in the subdirectory.
> The sass build is part of the maven build, which generates the
> defaults.css. It is not currently included in ant. So the defaults.css
> gets updated and committed via that process. So the process is
> normally - change the sass definitions, run the maven sass build, and
> then commit the changes to the sass definitions and the defaults.css
> output from sass, iirc. It is just a different way of generating the
> defaults.css which is then all that is needed for the swc.
> Are you using maven or ant to build?
>
>
> The Jewel themes are also built using sass, but because these change
> infrequently (and because they add extra time to the build) there is a
> maven profile (-Poption-with-sass-compile) that needs to be switched
> on to include them in the overall build.
>
> I'm just going from memory for the above, and it has been a while
> since I worked on this stuff, so I might be wrong about some things...
>
>
>
>
>
>
> On Mon, Dec 6, 2021 at 7:46 AM Hugo Ferreira <hferreira...@gmail.com>
> wrote:
>
> > Hi Greg,
> >
> > Thank you for pointing that out.
> > I'm not familiar with sass but I'll check it out.
> > Can you point to the file that I need to change ?
> >
> >
> > Greg Dove <greg.d...@gmail.com> escreveu no dia domingo, 5/12/2021
> > à(s)
> > 16:25:
> >
> > > Hi Hugo,
> > >
> > > You probably never saw it yet but Jewel style setup is a little
> different
> > > and is structured in a sass build. So I think you don't normally
> > > make changes in defaults.css directly, because it will likely get
> overwritten
> > > next time the sass build gets run. I will check this later today
> > > and confirm... just in case I am wrong (it has been some time
> > > since I
> worked
> > > directly on Jewel stuff)
> > >
> > >
> > >
> > >
> > >
> > >
> > > On Sun, 5 Dec 2021, 11:33 pm , <hugoferre...@apache.org> wrote:
> > >
> > > > This is an automated email from the ASF dual-hosted git repository.
> > > >
> > > > hugoferreira pushed a commit to branch develop in repository
> > > > https://gitbox.apache.org/repos/asf/royale-asjs.git
> > > >
> > > >
> > > > The following commit(s) were added to refs/heads/develop by this
> push:
> > > > new a458681 Fixed the brackets position according to
> > > > Royale
> best
> > > > practices
> > > > a458681 is described below
> > > >
> > > > commit a458681985b31c6f9c8c7b62b87978d8b8e33178
> > > > Author: Hugo Ferreira <hferre...@solidsoft.pt>
> > > > AuthorDate: Sun Dec 5 10:33:29 2021 +0000
> > > >
> > > > Fixed the brackets position according to Royale best
> > > > practices
> > > > ---
> > > > frameworks/projects/Jewel/src/main/resources/defaults.css | 12
> > > > ++++--------
> > > > 1 file changed, 4 insertions(+), 8 deletions(-)
> > > >
> > > > diff --git
> a/frameworks/projects/Jewel/src/main/resources/defaults.css
> > > > b/frameworks/projects/Jewel/src/main/resources/defaults.css
> > > > index 7eddae9..cd85807 100644
> > > > --- a/frameworks/projects/Jewel/src/main/resources/defaults.css
> > > > +++ b/frameworks/projects/Jewel/src/main/resources/defaults.css
> > > > @@ -576,24 +576,20 @@ j|VirtualComboBoxPopUp {
> > > > content: "\200b";
> > > > }
> > > >
> > > > -.first.jewel.list::-webkit-scrollbar
> > > > -{
> > > > +.first.jewel.list::-webkit-scrollbar {
> > > > display: none;
> > > > }
> > > >
> > > > -.first.jewel.list
> > > > -{
> > > > +.first.jewel.list {
> > > > -ms-overflow-style: none;
> > > > scrollbar-width: none;
> > > > }
> > > >
> > > > -.middle.jewel.list::-webkit-scrollbar
> > > > -{
> > > > +.middle.jewel.list::-webkit-scrollbar {
> > > > display: none;
> > > > }
> > > >
> > > > -.middle.jewel.list
> > > > -{
> > > > +.middle.jewel.list {
> > > > -ms-overflow-style: none;
> > > > scrollbar-width: none;
> > > > }
> > > >
> > >
> >
>
