For consistency, we should probably have the same list of externs being included in both Ant and Maven builds. I made that change 5 years ago, but I think that my goal was to include as many missing JS APIs in js.swc as I possibly could so that app developers can use those APIs directly in AS3 code without workarounds.
-- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Mon, Dec 27, 2021 at 4:58 AM Yishay Weiss <yishayj...@hotmail.com> wrote: > I fixed mvn build, but I think there other such issues might arise because > I only added mediasource to mvn. There are probably more in said commit > that should be addressed the same way. Josh, can you comment? > > From: Yishay Weiss<mailto:yishayj...@hotmail.com> > Sent: Monday, December 27, 2021 2:39 PM > To: dev@royale.apache.org<mailto:dev@royale.apache.org> > Subject: RE: Build failed in Jenkins: Royale » Royale-typedefs » Apache > Royale: TypeDefs: GCL #1133 > > Looks like it was added to ant typedefs build in commit > 1e1e346d7a35dbecc860a5ee276e0461bd239868 > > I don’t see the same commit addressing mvn build. Let me quickly see if I > can figure it out. > > From: Harbs<mailto:harbs.li...@gmail.com> > Sent: Monday, December 27, 2021 2:25 PM > To: Apache Royale Development<mailto:dev@royale.apache.org> > Subject: Re: Build failed in Jenkins: Royale » Royale-typedefs » Apache > Royale: TypeDefs: GCL #1133 > > That’s a js type. > > Weird that Maven complains about that, but ant doesn’t. > > Any thoughts as to why? > > > On Dec 27, 2021, at 1:19 PM, Yishay Weiss <yishayj...@hotmail.com> > wrote: > > > > Harbs, I think you missed an import for MediaSource > > > > > > > > > F:\jenkins\jenkins-slave\712657a4\workspace\Royale\Royale-typedefs\GCL\src\main\royale\goog\html\SafeUrl.as(62): > col: 54 Error: Type was not found or was not a compile-time constant: > MediaSource. > > > > > > > > public static function > fromMediaSource(mediaSource:MediaSource):SafeUrl{return null} > > > > > > From: Apache Jenkins Server<mailto:jenk...@builds.apache.org> > > Sent: Monday, December 27, 2021 12:35 PM > > To: royale-bui...@royale.apache.org<mailto: > royale-bui...@royale.apache.org> > > Subject: Build failed in Jenkins: Royale » Royale-typedefs » Apache > Royale: TypeDefs: GCL #1133 > > > > See < > https://ci-builds.apache.org/job/Royale/job/Royale-typedefs/org.apache.royale.typedefs$royale-typedefs-gcl/1133/display/redirect?page=changes > > > > > > Changes: > > > > [Harbs] Added typedefs for sanitize > > > > [Harbs] not native > > > > > > ------------------------------------------ > > [INFO] > > [INFO] -----------< org.apache.royale.typedefs:royale-typedefs-gcl > >----------- > > [INFO] Building Apache Royale: TypeDefs: GCL 0.9.9-SNAPSHOT > [6/12] > > [INFO] --------------------------------[ swc > ]--------------------------------- > > [INFO] > > [INFO] --- maven-clean-plugin:3.1.0:clean (default-clean) @ > royale-typedefs-gcl --- > > [INFO] Deleting > F:\jenkins\jenkins-slave\712657a4\workspace\Royale\Royale-typedefs\GCL\target > > [INFO] > > [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @ > royale-typedefs-gcl --- > > [INFO] > > [INFO] --- royale-maven-plugin:0.9.9-SNAPSHOT:generate-extern > (default-generate-extern) @ royale-typedefs-gcl --- > > [INFO] > > [INFO] --- royale-maven-plugin:0.9.9-SNAPSHOT:generate-playerglobal > (default-generate-playerglobal) @ royale-typedefs-gcl --- > > [INFO] > > [INFO] --- maven-remote-resources-plugin:1.7.0:process > (process-resource-bundles) @ royale-typedefs-gcl --- > > [INFO] Preparing remote bundle org.apache:apache-jar-resource-bundle:1.4 > > [INFO] Copying 3 resources from 1 bundle. > > [INFO] > > [INFO] --- maven-resources-plugin:3.1.0:resources (default-resources) @ > royale-typedefs-gcl --- > > [INFO] Using 'UTF-8' encoding to copy filtered resources. > > [INFO] skip non existing resourceDirectory > F:\jenkins\jenkins-slave\712657a4\workspace\Royale\Royale-typedefs\GCL\src\main\resources > > [INFO] Copying 3 resources > > [INFO] > > [INFO] --- royale-maven-plugin:0.9.9-SNAPSHOT:compile-as > (default-compile-as) @ royale-typedefs-gcl --- > > [INFO] > > [INFO] --- royale-maven-plugin:0.9.9-SNAPSHOT:compile-js > (default-compile-js) @ royale-typedefs-gcl --- > > [INFO] > > [INFO] --- royale-maven-plugin:0.9.9-SNAPSHOT:compile-extern > (default-compile-extern) @ royale-typedefs-gcl --- > > [INFO] Executing COMPC in tool group Royale with args: > [-load-config=F:\jenkins\jenkins-slave\712657a4\workspace\Royale\Royale-typedefs\GCL\target\compile-extern-config.xml, > -compiler.targets=SWF] > > args: > > > -load-config=F:\jenkins\jenkins-slave\712657a4\workspace\Royale\Royale-typedefs\GCL\target\compile-extern-config.xml > > -compiler.targets=SWF > > target:SWF > > COMPC > > Loading configuration: > F:\jenkins\jenkins-slave\712657a4\workspace\Royale\Royale-typedefs\GCL\target\compile-extern-config.xml > > > > > F:\jenkins\jenkins-slave\712657a4\workspace\Royale\Royale-typedefs\GCL\src\main\royale\goog\html\SafeUrl.as(62): > col: 54 Error: Type was not found or was not a compile-time constant: > MediaSource. > > > > public static function > fromMediaSource(mediaSource:MediaSource):SafeUrl{return null} > > ^ > > > > > F:\jenkins\jenkins-slave\712657a4\workspace\Royale\Royale-typedefs\GCL\src\main\royale\goog\html\SafeUrl.as(62): > col: 54 Type was not found or was not a compile-time constant: MediaSource. > > > > public static function > fromMediaSource(mediaSource:MediaSource):SafeUrl{return null} > > ^ > > > > 0.220461444 seconds > > > >
