Hi Yishay, I have added something but it was usually very minor things. Nothing I believe which should be mentioned - general small improvements.
Thanks, Piotr pon., 28 lut 2022 o 12:45 Yishay Weiss <yishayj...@hotmail.com> napisał(a): > Does anybody else want to add their changes? From memory, Harbs has made > release optimizations and sanitizations, Alex has added support for modules > in release, and Greg and Piotr have made various improvements in compiler > and emulation. > > Thanks. > > From: Josh Tynjala<mailto:joshtynj...@bowlerhat.dev> > Sent: Thursday, February 24, 2022 7:06 PM > To: Yishay Weiss<mailto:yishayj...@hotmail.com> > Cc: dev@royale.apache.org<mailto:dev@royale.apache.org> > Subject: Re: Swc Compiler Version and Binary Reproducibility > > Sounds good. I've updated the release notes with summaries of my changes > in 0.9.9. > > -- > Josh Tynjala > Bowler Hat LLC<https://bowlerhat.dev> > > > On Thu, Feb 24, 2022 at 1:09 AM Yishay Weiss <yishayj...@hotmail.com > <mailto:yishayj...@hotmail.com>> wrote: > The effective pom for the CI swcs does show server version 0.9.8 which > seems wrong. It could be I was doing something wrong on the CI. > > I also had to update the years on NOTICE files and added my 0.9.9 changes > to RELEASE_NOTES.md. > > I think we need to update the rest of the RELEASE_NOTES files in the all > repos, and when that’s done we can update the top level RELEASE_NOTES under > royale-asjs\releasemgr\RELEASE_NOTES. > > After that’s done I’ll start a new RC and will keep an eye on server > versions for typedefs. > > Thanks. > > From: Yishay Weiss<mailto:yishayj...@hotmail.com> > Sent: Thursday, February 24, 2022 8:14 AM > To: Josh Tynjala<mailto:joshtynj...@bowlerhat.dev>; Apache Royale > Development<mailto:dev@royale.apache.org> > Subject: RE: Swc Compiler Version and Binary Reproducibility > > Ok, I’ll check that. Thanks for the explanation. > > From: Josh Tynjala<mailto:joshtynj...@bowlerhat.dev> > Sent: Wednesday, February 23, 2022 8:26 PM > To: Apache Royale Development<mailto:dev@royale.apache.org> > Cc: yishayj...@hotmail.com<mailto:yishayj...@hotmail.com><mailto: > yishayj...@hotmail.com<mailto:yishayj...@hotmail.com>> > Subject: Re: Swc Compiler Version and Binary Reproducibility > > Could it be that the 8 and 9 are derived from the last part of Royale's > recent version numbers: 0.9.8 and 0.9.9? > > In your tutorialspoint link, it prints 1.6.0_25, so I can see why you > think it might always be the Java version. However, I suspect that's > specifically because tutorialspoint is calling getImplementationVersion() > on the java.lang package, so the result will match whichever JDK it is > from, since it is a core language class. I think that > getImplementationVersion() is based on the version of the .jar file where > the class/package is located. So, for Royale classes, it should return > something like 0.9.8 or 0.9.9. > > Anyway, it seems like the differing build numbers between CI and your > local machine means that you have a different version of the compiler > checked out locally than what the CI has. > > > -- > Josh Tynjala > Bowler Hat LLC<https://bowlerhat.dev> > > > On Wed, Feb 23, 2022 at 10:04 AM Yishay Weiss <yishayj...@hotmail.com > <mailto:yishayj...@hotmail.com><mailto:yishayj...@hotmail.com<mailto: > yishayj...@hotmail.com>>> wrote: > The typedef swcs produced on my machine are different to the ones produced > on CI which breaks the build process. I noticed this difference in the > catalog (though it’s not the only one) > > <compiler name="Apache Royale: Compiler: Compiler-Common" > version="0.9" build="8"/> > <compiler name="Apache Royale: Compiler: Compiler-Common" > version="0.9" build="9"/> > > Can somebody explain why the build# is different? > > I had a look at SWCTarget.java in the compiler and it looks like it’s > getting its information from VersionInfo which ultimately relies on Java’s > getImplementationVersion() [1]. > > I checked java -version both on my machine and on the CI and they both > output 1.8.0_201, so I don’t understand why the version is different. > > Any clues? > > [1] Java.lang.getImplementationVersion() Method (tutorialspoint.com< > http://tutorialspoint.com><http://tutorialspoint.com>)< > https://www.tutorialspoint.com/java/lang/package_getimplementationversion.htm > > > > > -- Piotr Zarzycki
