It looks like I created a property in the royale-asjs build named
royaleunit.browser to allow someone request a specific installed web
browser to run RoyaleUnit tests. If royaleunit.browser is not set,
RoyaleUnit will use Playwright. So -Dbrowser won't affect it (but maybe it
was used before I added Playwright support). You could add
-Droyaleunit.browser, but I recommend avoiding that on the CI server and
just let it use Playwright. I added royaleunit.browser mostly to give folks
the ability to customize their local build environment, if desired.
Looking over royale-asjs, it appears that ${browser} is still used for
examples and release candidate stuff, though.
--
Josh Tynjala
Bowler Hat LLC <https://bowlerhat.dev>
On Tue, Nov 15, 2022 at 5:50 AM Yishay Weiss <yishayj...@hotmail.com> wrote:
> Hi,
>
>
>
> I have imported most of the settings from Alex’s CI instance. People can
> look at current state in
>
>
>
> http://apacheroyale.francecentral.cloudapp.azure.com:8080
>
>
>
> Or play around with it using RDP. The credentials are same as Alex’s CI.
>
>
>
> Currently I’m trying to figure out a royale-asjs failure [1] which I
> suspect has to do with browser instances for unit tests.
>
>
>
> @Josh Tynjala <joshtynj...@bowlerhat.dev>, I found your post on the
> playwright [2] changes you made. Do these mean playwright is the default,
> and does this param [3] interfere with that?
>
>
>
> [1]
> http://apacheroyale.francecentral.cloudapp.azure.com:8080/job/royale-asjs/13/console
>
> [2] Using Playwright for RoyaleUnit JS testing-Apache Mail Archives
> <https://lists.apache.org/thread/l3rkhq8q9vrtocot907mrq4cbxj3z1bk>
>
> [3] '"-Dbrowser=C:\Program Files\Mozilla Firefox\firefox.exe"'
>
>
>
> Thanks
>
>
>
