On Mon, 27 Jul 2026 at 09:27, Yishay Weiss <[email protected]> wrote: > > Hi Sebb, > > Fair point on the missing provenance info. For the record, this RC was built > from: > > tag: org.apache.royale.compiler-jburg-types-1.1.1-rc2 > commit: 3d9fca8a1 > https://github.com/apache/royale-compiler/tree/3d9fca8a1/compiler-jburg-types > > Reviewers can verify the source ZIP against the tag with, for example: > > git archive --format=zip --prefix=apache-royale-compiler-jburg-types-1.1.1/ \ > 3d9fca8a1:compiler-jburg-types > /tmp/from-tag.zip > > The vote-email templates on our Jenkins jobs and Ant release scripts have > been updated to include tag, commit id and GitHub URL going forward. > > Does this addendum resolve your -1, or would you prefer a fresh RC?
The addition of source commit it to the vote email thread does not affect the RC, only the voting process. Rather than restart the process, reviewers can add to the vote thread whether or not they have compared the source bundle contents with the source commit id. > Thanks, > Yishay > ________________________________ > From: sebb <[email protected]> > Sent: Friday, July 24, 2026 2:51 PM > To: [email protected] <[email protected]> > Subject: Re: [VOTE] Release Apache Royale Compiler JBurg Types 1.1.1 > > -1 > > Just realised that there is no source to compare the artifact against. > > A vote email must include a link to the source code tag which was used > to create the release. > (This needs a Git commit id or SVN revision) > > Reviewers need to be able to check that there are no spurious files in > the source release, and that the files agree with the repo tag. > This is vital for provenance. > > Sebb > > On Fri, 24 Jul 2026 at 12:06, Apache Royale Release > <[email protected]> wrote: > > > > Hi, > > This is the vote for the 1.1.1 release of Apache Royale Compiler JBurg > > Types. The release candidate can be found here; > > https://dist.apache.org/repos/dist/dev/royale/compiler-jburg-types/1.1.1/rc2/ > > (SVN revision 86200) > > > > Before voting please review the section,'What are the ASF requirements on > > approving a release?', at: > > http://www.apache.org/dev/release.html#approving-a-release > > > > At a minimum you would be expected to check that: > > - SHA and signed packages are correct > > - NOTICE and LICENSE files are all fine > > - That "mvn clean install" in the root of the source package completes > > successfully > > - That you can modify other compiler poms to use that version of > > compiler-jburg-types and build the compiler. > > > > The KEYS file is at https://downloads.apache.org/royale/KEYS > > > > Maven artifacts are staged here: > > https://repository.apache.org/content/repositories/orgapacheroyale-1103 > > > > Please vote to approve this release: > > +1 Approve the release > > -1 Disapprove the release (please provide specific comments to why) > > > > This vote will be open for 72 hours or until a result can be called. > > > > The vote passes if there is: > > - At least 3 +1 votes from the PMC > > - More positive votes than negative votes > > > > Remember that this is a 'beta-quality' release so expect there will be many > > bugs found. IMO the goal is not to try to find and fix bugs in the RC, but > > to make sure we have the packaging right, and enough functionality that > > folks will have some success trying to use it. People who are not in PMC > > are also encouraged to test out the release and vote, although their votes > > will not be binding, they can influence how the PMC votes. > > > > When voting please indicate what OS, IDE, Flash Player version and AIR > > version you tested with. > > > > For your convenience, there is an ant script that automates the common > > steps to validate a release. Instead of individually downloading the > > package and signature files, unzipping, etc, you can instead: > > 1) create an empty folder, > > 2) download into that folder this file: > > https://dist.apache.org/repos/dist/dev/royale/compiler-jburg-types/1.1.1/rc2/ApproveJBurgTypes.xml > > 3) run the script: > > ant -e -f ApproveJBurgTypes.xml -Drelease.version=1.1.1 -Drc=2 > > > > You are not required to use this script, and more testing of the packages > > and build results are always encouraged. > > > > Please put all discussion about this release in the DISCUSSION thread not > > this VOTE thread. > > > > Thanks, > > Yishay Weiss
