So both Kiet and I suffered from a non-fresh working clone. RAT is sensitive to files that mvn clean and git checkout leave behind. For Kiet, you were building with -Pgeoindexing, and then without. Without -Pgeoindexing, RAT sees a subfolder, not a submodule, and does not exclude the Eclipse files.
david. On Thu, Jan 19, 2017 at 2:46 PM, Aaron D. Mihalik <[email protected]> wrote: > oh, "optional geoindexing". It looks like you had eclipse build > rya.geoindexing > > So, two options: > > 1. Start building rya.geoindexing , ie: mvn clean install -Pgeoindexing > > 2. Blow away every file in the rya.geoindexing project that is not in git > ie: git clean -dxfn extras/rya.geoindexing/ > > For #2, the command I gave is a 'dry-run'. you should see a list like > this: > > Would remove extras/rya.geoindexing/.classpath > Would remove extras/rya.geoindexing/.project > Would remove extras/rya.geoindexing/.settings/ > Would remove extras/rya.geoindexing/target/ > > If you're satisfied with the list of files that it'll remove, re-run the > command as: git clean -dxf extras/rya.geoindexing/ > > On Thu, Jan 19, 2017 at 12:54 PM Ly, Kiet <[email protected]> wrote: > > > [ERROR] Failed to execute goal org.apache.rat:apache-rat- > plugin:0.11:check > > (check-licenses) on project rya.extras: Too many files with unapproved > > license: 12 See RAT report in: > > /Users/lyk/Projects/Github/rya/rya-master/extras/target/rat.txt -> > [Help 1] > > > > Look like rat check license on eclipse artifact and output file. Bad rat > > config. > > > > On 1/19/17, 12:32 PM, "Josh Elser" <[email protected]> wrote: > > > > David/Kiet, > > > > Can either of you share the report file that RAT generates (in > target/) > > for the given module where it failed? This describes what failed the > > check. > > > > Like Puja says, this shouldn't be happening under normal > circumstances. > > It's something that was verified before the first release. > > > > Puja Valiyil wrote: > > > Fresh checkouts shouldn't have any rat errors-- it's building with > > rat > > > enabled on apaches build servers. > > > > > > On Wednesday, January 18, 2017, Ly, Kiet<[email protected]> > wrote: > > > > > >> I just used mvn clean install -DskipTests -Drat.skip=true. Master > > branch > > >> has a lot of rat errors. > > >> > > >> On 1/18/17, 5:43 PM, "David Lotts"<[email protected]< > javascript:;>> > > >> wrote: > > >> > > >> If your maven build err's with RAT complaints about > > tinkerpop.rya then > > >> delete it. > > >> > > >> The sub-project formerly known as "tinkerpop.rya" has > recently > > been > > >> removed > > >> from master. There is a new tinkerpop sub-project under a > > different > > >> name, I > > >> think. > > >> > > >> Anyway, I discovered that git won't delete the folder on > > checkout (in a > > >> previously used git clone) because it had a "target" > > subfolder, which > > >> is > > >> explicitly ignored. > > >> > > >> So manually remove tinkerpop.rya: > > >> rm -rf ./extras/tinkerpop.rya > > >> > > >> And RAT will no longer complain. > > >> > > >> david. > > >> > > >> > > >> > > >> Confidentiality Notice:: This email, including attachments, may > > include > > >> non-public, proprietary, confidential or legally privileged > > information. > > >> If you are not an intended recipient or an authorized agent of an > > intended > > >> recipient, you are hereby notified that any dissemination, > > distribution or > > >> copying of the information contained in or transmitted with this > > e-mail is > > >> unauthorized and strictly prohibited. If you have received this > > email in > > >> error, please notify the sender by replying to this message and > > permanently > > >> delete this e-mail, its attachments, and any copies of it > > immediately. You > > >> should not retain, copy or use this e-mail or any attachment for > any > > >> purpose, nor disclose all or any part of the contents to any other > > person. > > >> Thank you. > > >> > > > > > > > > > >
